BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Create possibility to provide render settings via BlenderSceneDelegate #41

Merged
Bogdan Nagirniak merged 10 commits from BLEN-349 into hydra-render 2023-05-19 20:19:17 +02:00
Conversation 0 Commits 10 Files Changed 17 +12 -4
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e5d8d3f879 - Show all commits

16
scripts/modules/bpy_hydra.py
View File

@ -23,14 +23,13 @@ class CustomHydraRenderEngine(HydraRenderEngine):
def get_sync_settings(self, engine_type): def get_sync_settings(self, engine_type):
Georgiy Markelov commented 2023-05-17 20:34:50 +02:00
Review
Copy Link

Consider to add a note that these settings refer to keys that Hydra asks.

Consider to add a note that these settings refer to keys that Hydra asks.
👍 1
return { return {
'setting1': True, 'MaterialXFilenameKey': "MaterialXFilename",
'setting2': "2",
} }
def get_render_settings(self, engine_type): def get_render_settings(self, engine_type):
return { return {
'setting1': 1, 'enableTinyPrimCulling': True,
'setting2': "2", 'maxLights': 8,
} }
``` ```
""" """
@ -80,9 +79,18 @@ class HydraRenderEngine(bpy.types.RenderEngine):
pass pass
def get_sync_settings(self, engine_type): def get_sync_settings(self, engine_type):
"""
Brian Savery (AMD) commented 2023-05-18 00:39:27 +02:00
Outdated
Review
Copy Link

We need explanations of how these methods should be used / overridden

We need explanations of how these methods should be used / overridden
Provide settings for Blender scene delegate. Available settings:
`MaterialXFilenameKey` - if provided then MaterialX file will be provided directly to render delegate
without converting to HdMaterialNetwork
"""
return {} return {}
def get_render_settings(self, engine_type): def get_render_settings(self, engine_type):
"""
Provide render settings for render delegate. List of settings should be available in render delegate
documentation or in `pxr.UsdImagingGL.Engine.GetRendererSettingsList()`
"""
return {} return {}
# final render # final render