Fix rendering of Final render for Storm delegate #61

Bogdan Nagirniak · 2023-07-06T14:15:22+02:00

Bogdan Nagirniak commented

2023-07-06 14:15:22 +02:00

Purpose

Final render for Storm delegate returns empty image.

Technical steps

Added comment in bpy_hydra.py that if bl_use_gpu_context is enabled then update() should be empty and engine cretaion and syncing has to moved to render(). Corresponded PR for Storm Hydra addon BogdanNagirniak/blender-addons#17.
Renamed FinalEngineGL -> FinalEngineGPU as more related.
Fixed FinalEngineGPU::render() to works with Storm delegate.
Fixed CullStyle for mesh and material.
Improved logging.

### Purpose Final render for Storm delegate returns empty image. ### Technical steps 1. Added comment in `bpy_hydra.py` that if `bl_use_gpu_context` is enabled then `update()` should be empty and engine cretaion and syncing has to moved to `render()`. Corresponded PR for Storm Hydra addon https://projects.blender.org/BogdanNagirniak/blender-addons/pulls/17. 2. Renamed `FinalEngineGL -> FinalEngineGPU` as more related. 3. Fixed `FinalEngineGPU::render()` to works with Storm delegate. 4. Fixed CullStyle for mesh and material. 5. Improved logging.

Bogdan Nagirniak self-assigned this 2023-07-06 14:15:22 +02:00

Brian Savery (AMD) was assigned by Bogdan Nagirniak

2023-07-06 14:15:22 +02:00

Georgiy Markelov was assigned by Bogdan Nagirniak

2023-07-06 14:15:22 +02:00

Vasyl Pidhirskyi was assigned by Bogdan Nagirniak

2023-07-06 14:15:22 +02:00

Bogdan Nagirniak added 7 commits 2023-07-06 14:15:42 +02:00

8ab42153cd Fix rendering of Final render for Storm delegate.

Initial fixes

fd68f0ca34 Moved cull_style to MaterialData

2e68ca68d0 Adding depth component

6ee0f4793d Continuing

9da35493ac Fixing depth

1d6cd374d9 Removed unused code

bdacb8d2ad Polishing code. Renamed: FinaleEngineGL -> FinalEngineGPU

Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-06 14:16:04 +02:00

Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-06 14:16:04 +02:00

Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-06 14:16:05 +02:00

Brian Savery (AMD) reviewed 2023-07-07 19:05:06 +02:00

scripts/modules/bpy_hydra.py Outdated

						
				@ -92,6 +92,9 @@ class HydraRenderEngine(bpy.types.RenderEngine):

				    # final render

				    def update(self, data, depsgraph):

				        # Note: if bl_use_gpu_context = True, leave this function empty and move engine creation

Brian Savery (AMD) commented

2023-07-07 19:05:06 +02:00

is bl_use_gpu_context is true why not just automatically use render()

Then say something here like "if use gpu context is true, this function is ignored and render() is used"

is bl_use_gpu_context is true why not just automatically use render() Then say something here like "if use gpu context is true, this function is ignored and render() is used"

Brian Savery (AMD) requested changes 2023-07-07 19:05:51 +02:00

Brian Savery (AMD) left a comment

see comment

Georgiy Markelov approved these changes 2023-07-07 20:33:32 +02:00

Georgiy Markelov left a comment

works fine. comment in code

source/blender/render/hydra/scene_delegate/material.cc

						
				@ -91,1 +91,4 @@

				pxr::HdCullStyle MaterialData::cull_style() const

				{

				  return double_sided ? pxr::HdCullStyle::HdCullStyleNothing : pxr::HdCullStyle::HdCullStyleBack;