BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Add automated tests for Storm, with both Hydra and USD export methods #66

Closed
Brecht Van Lommel wants to merge 3 commits from brecht:hydra-tests into hydra-render
pull from: brecht:hydra-tests
merge into: BogdanNagirniak:hydra-render

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 3 Files Changed 2 +128
Brecht Van Lommel commented 2023-07-10 20:15:47 +02:00
Collaborator
Copy Link

Needs WITH_OPENGL_RENDER_TESTS CMake option to be enabled.

I couldn't actually get it to work yet but I assume it will work after
BogdanNagirniak/blender#61.

Needs WITH_OPENGL_RENDER_TESTS CMake option to be enabled. I couldn't actually get it to work yet but I assume it will work after BogdanNagirniak/blender#61.
Brecht Van Lommel added 1 commit 2023-07-10 20:15:51 +02:00 
Needs WITH_OPENGL_RENDER_TESTS CMake option to be enabled.

I couldn't actually get it to work yet but I assume it will work after
BogdanNagirniak/blender#61.
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-11 17:38:21 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-11 17:38:21 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-11 17:38:21 +02:00
Bogdan Nagirniak commented 2023-07-12 15:42:47 +02:00
Owner
Copy Link

How to run this automated test?

How to run this automated test?
Brecht Van Lommel commented 2023-07-12 15:53:53 +02:00
Author
Collaborator
Copy Link

The general docs for running tests are here:
https://wiki.blender.org/wiki/Tools/Tests/Setup

Assuming you have the test files downloaded.

  • Set WITH_OPENGL_RENDER_TESTS=ON and rebuild.
  • make test will work, but ctest -C Release -R storm from the build folder will be faster to run just the Storm tests
  • There will be a tests/report.html in the build folder with the results (all the tests will fail because there is no reference image yet)
The general docs for running tests are here: https://wiki.blender.org/wiki/Tools/Tests/Setup Assuming you have the test files downloaded. * Set `WITH_OPENGL_RENDER_TESTS=ON` and rebuild. * `make test` will work, but `ctest -C Release -R storm` from the build folder will be faster to run just the Storm tests * There will be a `tests/report.html` in the build folder with the results (all the tests will fail because there is no reference image yet)
Brecht Van Lommel added 1 commit 2023-07-13 15:31:29 +02:00
Brecht Van Lommel added 1 commit 2023-07-13 20:12:56 +02:00
Brecht Van Lommel commented 2023-07-13 20:15:57 +02:00
Author
Collaborator
Copy Link

If I combine this with #65 the tests can now actually run. Some tests crash and fail in various ways, revealing issues in both the Hydra scene delegate and USD exporter.

But we can work through those later.

If I combine this with #65 the tests can now actually run. Some tests crash and fail in various ways, revealing issues in both the Hydra scene delegate and USD exporter. But we can work through those later.
Brecht Van Lommel commented 2023-07-13 20:16:35 +02:00
Author
Collaborator
Copy Link

I'll just merge this since it's not going to break anything else, can always iterate on this later, and juggling all these branches is a pain.

I'll just merge this since it's not going to break anything else, can always iterate on this later, and juggling all these branches is a pain.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Georgiy Markelov
Vasyl Pidhirskyi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#66
No description provided.
Delete Branch "brecht:hydra-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?