Fix rendering of Final render for Storm delegate #61

Merged
Bogdan Nagirniak merged 11 commits from BLEN-437 into hydra-render 2023-07-12 23:18:03 +02:00

Purpose

Final render for Storm delegate returns empty image.

Technical steps

  1. Added comment in bpy_hydra.py that if bl_use_gpu_context is enabled then update() should be empty and engine cretaion and syncing has to moved to render(). Corresponded PR for Storm Hydra addon BogdanNagirniak/blender-addons#17.
  2. Renamed FinalEngineGL -> FinalEngineGPU as more related.
  3. Fixed FinalEngineGPU::render() to works with Storm delegate.
  4. Fixed CullStyle for mesh and material.
  5. Improved logging.
### Purpose Final render for Storm delegate returns empty image. ### Technical steps 1. Added comment in `bpy_hydra.py` that if `bl_use_gpu_context` is enabled then `update()` should be empty and engine cretaion and syncing has to moved to `render()`. Corresponded PR for Storm Hydra addon https://projects.blender.org/BogdanNagirniak/blender-addons/pulls/17. 2. Renamed `FinalEngineGL -> FinalEngineGPU` as more related. 3. Fixed `FinalEngineGPU::render()` to works with Storm delegate. 4. Fixed CullStyle for mesh and material. 5. Improved logging.
Bogdan Nagirniak self-assigned this 2023-07-06 14:15:22 +02:00
Brian Savery (AMD) was assigned by Bogdan Nagirniak 2023-07-06 14:15:22 +02:00
Georgiy Markelov was assigned by Bogdan Nagirniak 2023-07-06 14:15:22 +02:00
Vasyl Pidhirskyi was assigned by Bogdan Nagirniak 2023-07-06 14:15:22 +02:00
Bogdan Nagirniak added 7 commits 2023-07-06 14:15:42 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-06 14:16:04 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-06 14:16:04 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-06 14:16:05 +02:00
Brian Savery (AMD) reviewed 2023-07-07 19:05:06 +02:00
@ -92,6 +92,9 @@ class HydraRenderEngine(bpy.types.RenderEngine):
# final render
def update(self, data, depsgraph):
# Note: if bl_use_gpu_context = True, leave this function empty and move engine creation
Collaborator

is bl_use_gpu_context is true why not just automatically use render()

Then say something here like "if use gpu context is true, this function is ignored and render() is used"

is bl_use_gpu_context is true why not just automatically use render() Then say something here like "if use gpu context is true, this function is ignored and render() is used"
Brian Savery (AMD) requested changes 2023-07-07 19:05:51 +02:00
Brian Savery (AMD) left a comment
Collaborator

see comment

see comment
Georgiy Markelov approved these changes 2023-07-07 20:33:32 +02:00
Georgiy Markelov left a comment
Collaborator

works fine. comment in code

works fine. comment in code
@ -91,1 +91,4 @@
pxr::HdCullStyle MaterialData::cull_style() const
{
return double_sided ? pxr::HdCullStyle::HdCullStyleNothing : pxr::HdCullStyle::HdCullStyleBack;
Collaborator

Check please value with mesh::cull_style()

Check please value with `mesh::cull_style()`
BogdanNagirniak marked this conversation as resolved
Bogdan Nagirniak added 2 commits 2023-07-09 14:19:53 +02:00
Bogdan Nagirniak added 1 commit 2023-07-10 13:18:48 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-12 15:43:07 +02:00
Brian Savery (AMD) approved these changes 2023-07-12 20:02:01 +02:00
Bogdan Nagirniak added 1 commit 2023-07-12 22:06:09 +02:00
Bogdan Nagirniak merged commit bd3f747044 into hydra-render 2023-07-12 23:18:03 +02:00
Sign in to join this conversation.
No Label
No Milestone
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#61
No description provided.