BogdanNagirniak
/
blender
forked from blender/blender
0
0
Fork 3
Code Pull Requests Activity

Add scene setting to export through either Hydra or USD, for debugging #65

Merged
Brecht Van Lommel merged 7 commits from brecht/blender:hydra-usd-export into hydra-render 2023-07-14 19:41:17 +02:00
Conversation 5 Commits 7 Files Changed 19 +404 -136
Brecht Van Lommel commented 2023-07-10 20:15:30 +02:00
Collaborator
Copy Link

The Hydra Storm add-on already had a setting to use a USD file, with
associated sync_usd API function. But this way works for all Hydra
engines and doesn't require manually exporting a USD file each time.

This remove sync_usd, and unless there is another use for this the Storm
add-on needs to be updated to remove the development settings that use
this.

The Hydra Storm add-on already had a setting to use a USD file, with associated sync_usd API function. But this way works for all Hydra engines and doesn't require manually exporting a USD file each time. This remove sync_usd, and unless there is another use for this the Storm add-on needs to be updated to remove the development settings that use this.
Brecht Van Lommel added 1 commit 2023-07-10 20:15:34 +02:00
0ed2525b04 Add scene setting to export through either Hydra or USD, for debugging 
The Hydra Storm add-on already had a setting to use a USD file, with
associated sync_usd API function. But this way works for all Hydra
engines and doesn't require manually exporting a USD file each time.

This remove sync_usd, and unless there is another use for this the Storm
add-on needs to be updated to remove the development settings that use
this.
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-07-11 17:38:08 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-11 17:38:09 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-11 17:38:09 +02:00
Brian Savery (AMD) approved these changes 2023-07-11 23:50:55 +02:00
Brian Savery (AMD) left a comment
Collaborator
Copy Link

Thank you this is what we needed here.

Thank you this is what we needed here.
Georgiy Markelov requested changes 2023-07-12 15:40:19 +02:00
Georgiy Markelov left a comment
Collaborator
Copy Link

Build errors
image

Build errors ![image](/attachments/5fc5cf8b-3239-4021-bd8b-35a7106c80f8)
image.png
34 KiB
Brecht Van Lommel added 1 commit 2023-07-12 18:10:31 +02:00
Brecht Van Lommel commented 2023-07-12 18:11:14 +02:00
Author
Collaborator
Copy Link

I was working of a newer version of main that has this file converted to C++. I now merged main into hydra-render, and then updated this PR as well.

I was working of a newer version of main that has this file converted to C++. I now merged main into `hydra-render`, and then updated this PR as well.
Georgiy Markelov commented 2023-07-13 14:26:04 +02:00
Collaborator
Copy Link

Please update this PR with latest hydra-render one more time.

Also I have messages Unable to delete file and Unable to remove directory in console when USD export method selected.

Please update this PR with latest `hydra-render` one more time. Also I have messages `Unable to delete file` and `Unable to remove directory` in console when `USD` export method selected.
Brecht Van Lommel added 3 commits 2023-07-13 18:34:56 +02:00
Brecht Van Lommel added 1 commit 2023-07-13 18:43:13 +02:00
Brecht Van Lommel commented 2023-07-13 18:44:53 +02:00
Author
Collaborator
Copy Link

The recent background collor change doesn't work with USD. This could be made to work, but for now I've limited it to Storm as well, as I don't think this should be used for other renderers. They can define their own background color.

The recent background collor change doesn't work with USD. This could be made to work, but for now I've limited it to Storm as well, as I don't think this should be used for other renderers. They can define their own background color.
Brecht Van Lommel commented 2023-07-13 20:19:39 +02:00
Author
Collaborator
Copy Link

Also I have messages Unable to delete file and Unable to remove directory in console when USD export method selected.

This should also be fixed.

> Also I have messages `Unable to delete file` and `Unable to remove directory` in console when `USD` export method selected. This should also be fixed.
Bogdan Nagirniak commented 2023-07-13 20:30:49 +02:00
Owner
Copy Link

Please, update and fix conflicts

Please, update and fix conflicts
Brecht Van Lommel added 1 commit 2023-07-14 12:02:19 +02:00
Bogdan Nagirniak approved these changes 2023-07-14 17:42:26 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good.

Tested - works good.
Georgiy Markelov approved these changes 2023-07-14 19:37:43 +02:00
Brecht Van Lommel merged commit 85470c770f into hydra-render 2023-07-14 19:41:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Vasyl Pidhirskyi
Brian Savery (AMD)
Bogdan Nagirniak
Georgiy Markelov
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#65
No description provided.
Delete Branch "brecht/blender:hydra-usd-export"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?