BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Refactor to move files, fix licenses, follow style guide #75

Closed
Brecht Van Lommel wants to merge 0 commits from brecht:hydra-move-license into hydra-render
pull from: brecht:hydra-move-license
merge into: BogdanNagirniak:hydra-render

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 6 Commits - Files Changed -
Brecht Van Lommel commented 2023-07-25 18:39:16 +02:00
Collaborator
Copy Link

There should be not functional changes, but a lot of code is moved and changed. See the individual commits for more details.

There should be not functional changes, but a lot of code is moved and changed. See the individual commits for more details.
Brian Savery (AMD) approved these changes 2023-07-25 21:01:36 +02:00
Georgiy Markelov commented 2023-07-26 15:02:14 +02:00
Collaborator
Copy Link

Builds and works fine. But new class layout doesn't follow this https://wiki.blender.org/wiki/Style_Guide/C_Cpp#:~:text=%7B%20...%20%7D-,Class%20Layout,-Classes%20should%20be

Builds and works fine. But new class layout doesn't follow this https://wiki.blender.org/wiki/Style_Guide/C_Cpp#:~:text=%7B%20...%20%7D-,Class%20Layout,-Classes%20should%20be
Brecht Van Lommel commented 2023-07-26 15:24:07 +02:00
Author
Collaborator
Copy Link

In which way does it not follow the style guide?

The main thing was to move the members to the top, /* non-static data members */ in the style guide.

In which way does it not follow the style guide? The main thing was to move the members to the top, `/* non-static data members */` in the style guide.
Georgiy Markelov commented 2023-07-26 15:37:02 +02:00
Collaborator
Copy Link

Yes, I meant them. I thought they supposed to be under private section in the end of a class.

Yes, I meant them. I thought they supposed to be under `private` section in the end of a class.
Brecht Van Lommel commented 2023-07-26 15:43:18 +02:00
Author
Collaborator
Copy Link

Ok, the style guide is a bit sparse, but they indeed should be at the top.

Ok, the style guide is a bit sparse, but they indeed should be at the top.
Bogdan Nagirniak commented 2023-07-26 16:23:59 +02:00
Owner
Copy Link

Tested - works good, please fix conflicts for final test and approve.

Tested - works good, please fix conflicts for final test and approve.
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-26 16:24:16 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-26 16:24:17 +02:00
Brecht Van Lommel force-pushed hydra-move-license from c3d3ffd9d7 to a4e2dfe1e0 2023-07-26 18:20:52 +02:00 Compare
Bogdan Nagirniak approved these changes 2023-07-27 12:58:27 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good

Tested - works good
Brecht Van Lommel force-pushed hydra-move-license from a4e2dfe1e0 to 335f3f3413 2023-07-27 15:07:39 +02:00 Compare
Brecht Van Lommel commented 2023-07-27 15:08:30 +02:00
Author
Collaborator
Copy Link

Merged manually as individual commits.

Merged manually as individual commits.
Bogdan Nagirniak referenced this issue from a commit 2023-08-01 21:35:29 +02:00
Hydra code cleanup

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Georgiy Markelov
Vasyl Pidhirskyi
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#75
No description provided.
Delete Branch "brecht:hydra-move-license"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?