BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Collection of bugfixes #76

Merged
Brecht Van Lommel merged 6 commits from brecht/blender:hydra-fixes into hydra-render 2023-07-27 13:38:26 +02:00
Conversation 2 Commits 6 Files Changed 18 +120 -83
Brecht Van Lommel commented 2023-07-25 19:21:30 +02:00
Collaborator
Copy Link

See the individual commits for details.

Note I have a PR upstream for fixing the OpenGL core profiles issues. This makes the VAO workaround for object selection obsolete, and additionally will fix warnings reported to the console.
https://github.com/PixarAnimationStudios/OpenUSD/pull/2550

I also have a fix for the grease pencil test crashing with Storm, that was committed directly to main in blender/blender@aef3d1c.

With these fixes combined, all the Storm regression tests complete without crashing.

See the individual commits for details. Note I have a PR upstream for fixing the OpenGL core profiles issues. This makes the VAO workaround for object selection obsolete, and additionally will fix warnings reported to the console. https://github.com/PixarAnimationStudios/OpenUSD/pull/2550 I also have a fix for the grease pencil test crashing with Storm, that was committed directly to main in blender/blender@aef3d1c. With these fixes combined, all the Storm regression tests complete without crashing.
Brian Savery (AMD) approved these changes 2023-07-25 20:58:10 +02:00
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-26 16:24:41 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-26 16:24:41 +02:00
Bogdan Nagirniak commented 2023-07-26 16:35:29 +02:00
Owner
Copy Link

To test this, do I need to take your PR https://github.com/PixarAnimationStudios/OpenUSD/pull/2550 + apply https://projects.blender.org/blender/blender/src/branch/main/build_files/build_environment/patches/usd.diff ?

To test this, do I need to take your PR https://github.com/PixarAnimationStudios/OpenUSD/pull/2550 + apply https://projects.blender.org/blender/blender/src/branch/main/build_files/build_environment/patches/usd.diff ?
Brecht Van Lommel force-pushed hydra-fixes from 8cf3550be1 to 3b325ca349 2023-07-26 16:56:15 +02:00 Compare
Brecht Van Lommel commented 2023-07-26 17:10:35 +02:00
Author
Collaborator
Copy Link

The changes in this PR should work with the current precompiled USD libraries. I only mentioned that upstream PR for context.

If you want to test that USD patch you can of course. But it can be tedious to build the libraries so I'm not asking for that. And it shouldn't block this PR in any case. The patch would need to be applied in addition to 3 existing ones. blender/blender#110474 is where I integrate it with our library building.

The changes in this PR should work with the current precompiled USD libraries. I only mentioned that upstream PR for context. If you want to test that USD patch you can of course. But it can be tedious to build the libraries so I'm not asking for that. And it shouldn't block this PR in any case. The patch would need to be applied in addition to 3 existing ones. blender/blender#110474 is where I integrate it with our library building.
Bogdan Nagirniak approved these changes 2023-07-27 13:12:26 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested with current USD - works ok.

Tested with current USD - works ok.
Brecht Van Lommel merged commit 62d2f0960f into hydra-render 2023-07-27 13:38:26 +02:00
Brecht Van Lommel deleted branch hydra-fixes 2023-07-27 13:38:26 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Georgiy Markelov
Vasyl Pidhirskyi
Bogdan Nagirniak
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#76
No description provided.
Delete Branch "brecht/blender:hydra-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?