BogdanNagirniak/blender
0
0
Fork 3
forked from blender/blender
Code Pull Requests Activity

Various Python integration changes #77

Closed
Brecht Van Lommel wants to merge 6 commits from brecht:hydra-python-changes into hydra-render
pull from: brecht:hydra-python-changes
merge into: BogdanNagirniak:hydra-render

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 5 Commits 6 Files Changed 8 +184 -198
Brecht Van Lommel commented 2023-07-25 19:59:24 +02:00
Collaborator
Copy Link

See individual commits for details.

See individual commits for details.
Brecht Van Lommel added 5 commits 2023-07-25 19:59:28 +02:00 
Otherwise the UI draw lock functionality does not work. Also renames
engine_sync to engine_update for consistency.
More consistent, and avoids paths being added multiple times if multiple
hydra render engines are registered.
Not sure why this was needed.
* Makes it more consistent with other types that can be subclassed.
* Give bl_ prefix to delegate_id.
* Lazily import _bpy_hydra.
* Tweaks to API docs example.
And remove some unnecessary includes.
Brecht Van Lommel commented 2023-07-25 19:59:58 +02:00
Author
Collaborator
Copy Link

Note this needs BogdanNagirniak/blender-addons#24.

Note this needs BogdanNagirniak/blender-addons#24.
Brian Savery (AMD) approved these changes 2023-07-25 20:51:34 +02:00
Georgiy Markelov commented 2023-07-26 13:54:25 +02:00
Collaborator
Copy Link

I have missing viewport render button and final render also doesn't work (no reaction from Blender).

I have missing viewport render button and final render also doesn't work (no reaction from Blender).
Brecht Van Lommel added 1 commit 2023-07-26 15:45:30 +02:00
Brecht Van Lommel commented 2023-07-26 15:47:19 +02:00
Author
Collaborator
Copy Link

Final render should work now. I added a temporary commit that will not be needed when this gets committed after #76, which removes the need for context there.

I didn't see a missing viewport render button, which one exactly?

Final render should work now. I added a temporary commit that will not be needed when this gets committed after #76, which removes the need for context there. I didn't see a missing viewport render button, which one exactly?
Georgiy Markelov commented 2023-07-26 16:38:12 +02:00
Collaborator
Copy Link

I rechecked and the button is on its place. Sorry, seems like it was issue on my side. Everything works fine now.

I rechecked and the button is on its place. Sorry, seems like it was issue on my side. Everything works fine now.
Bogdan Nagirniak approved these changes 2023-07-27 11:17:25 +02:00
Bogdan Nagirniak left a comment
Owner
Copy Link

Tested - works good. Created corresponded PR for RPR delegate https://github.com/bnagirniak/RPRHydraRenderBlenderAddon/pull/23

Tested - works good. Created corresponded PR for RPR delegate https://github.com/bnagirniak/RPRHydraRenderBlenderAddon/pull/23
Bogdan Nagirniak requested review from Georgiy Markelov 2023-07-27 11:17:39 +02:00
Bogdan Nagirniak requested review from Vasyl Pidhirskyi 2023-07-27 11:17:40 +02:00
Brecht Van Lommel commented 2023-07-27 15:08:23 +02:00
Author
Collaborator
Copy Link

Merged manually as individual commits.

Merged manually as individual commits.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Bogdan Nagirniak
Georgiy Markelov
Vasyl Pidhirskyi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: BogdanNagirniak/blender#77
No description provided.
Delete Branch "brecht:hydra-python-changes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?