- Germany
-
Game Engineering Student, modeller, coder and gamer :D
- Joined on
2021-01-09
Not sure about the copyright. Technically this is no longer property of bf, so if you want, you can put in your name (or Web3D Consortium as you're a member there) and current year
Hi Vincent, thanks for the recent changes. I looked through the code, as far as i can tell it looks good. Few minor typos in docstrings and comments (which also could get simplified).
for better readability put the return into it's own line
why is this temporary folder needed? Could you add that to the comment?
warn is deprecated, use warning instead
Could also get simplified: "Legacy Algorithm for preparing and normalizing image filepaths: Get the full path, reference path (e.g. relative), filename"
I saw your report a few days back, and right now it seems like i'm experiencing maybe a somewhat similar issue in blender 4.2.3 (though with a regular mouse, not NDOF):
When setting Max Shader…
By the way, i still fully encourage a feature implementing above mentioned Visual same/Correct selector for axis-presets, however the selection should be the users choice to make in my opinion.
@yottzumm just as a clarifification to finally be on the same page, i did a quick mockup in blender for my last message.
This is the result you desire, right? ![grafik](/attachments/48521a94-28…
That’s why I want the ability to change the grid.
You can't change the grid of blender, that part of code is core blender; also it does not affect anything else than visual orientation and…
Regarding postponing if the script still needs the change: If no negatives are heard within a few months i'll approve a PR for the change or implement it (probably the proposed compromise) myself.…
I acknowledge that my interpretation regarding the issues matter was wrong. I'll be honest here: From a developers perspective i agree on making the proposed change to +z up and +y forward as it…
Yeah it has, but that's only import, right?
Thanks for the hint, will take a look. Though may take some time, will have to focus on the upcoming exam season for now...