Charlie Jolly CharlieJolly
  • Joined on 2008-07-29
Charlie Jolly commented on pull request blender/blender#111401 2023-08-24 01:29:17 +02:00
WIP: Nodes: Add Hexagon Grid Texture node

As I see it, in this version, the node has a bunch of outputs that duplicate each other. It would be more practical (?) to output only 2 position vectors:

  1. Positions in the space of…
Charlie Jolly commented on pull request blender/blender#110802 2023-08-23 10:28:08 +02:00
WIP: Node: Gabor Noise Texture

Some kind of gain and bias function would be useful to do this I think. Users can run this through a float curve but I'm not sure there is a perfect solution here.

Charlie Jolly commented on pull request blender/blender#111401 2023-08-23 02:40:43 +02:00
WIP: Nodes: Add Hexagon Grid Texture node

@blender-bot package

Charlie Jolly pushed to hex at CharlieJolly/blender 2023-08-23 01:42:47 +02:00
a3a0627692 Nodes: Add Hexagon Grid Texture node
6e20beba22 UI: Statistics Overlay Improvements
709ec52c7d Core: foreach_id: Add a new callback flag to skip processing at readfile time.
710b47fe7c Tweak SpaceNode foreach_id callback handling of nodetree ID pointer.
1857df8d5b Cleanup: Use FunctionRef for PBVH filtering callback
Compare 20 commits »
Charlie Jolly commented on pull request blender/blender#111401 2023-08-22 18:56:47 +02:00
WIP: Nodes: Add Hexagon Grid Texture node

I used Gabor branch so I could update the old Hex patch, hence the gabor commits. These can be ignored.

Charlie Jolly created pull request blender/blender#111401 2023-08-22 18:55:23 +02:00
Nodes: Add Hexagon Grid Texture node
Charlie Jolly pushed to hex at CharlieJolly/blender 2023-08-22 18:52:28 +02:00
58dcf5d245 Nodes: Add Hexagon Grid Texture node
Charlie Jolly created branch hex in CharlieJolly/blender 2023-08-22 18:52:28 +02:00
Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-22 11:44:15 +02:00
07b94d48e6 Merge branch 'main' into gabor
fa3dd4bdb5 I18N: Add back wrongly removed translation marker in recent cleanup.
b4d138c959 Minor comment changes
2af2a11651 Vulkan: Use Correct Image Aspects
8bae4427ed Fix #111238: Arrow keys in some menus work in the opposite direction
Compare 13 commits »
Charlie Jolly commented on pull request blender/blender#111168 2023-08-22 04:47:37 +02:00
Fix #111017: Gap between color square and frame of box in the color ramp

@CharlieJolly I think what we could do is having a 2 px line so it always line up :P

Worth a try! Lol

Charlie Jolly commented on pull request blender/blender#111168 2023-08-22 04:39:10 +02:00
Fix #111017: Gap between color square and frame of box in the color ramp

@CharlieJolly But the line seems to be 1 pixel to the right of the center of the arrow with or without the 1px added...

This was one of my very first contributions to Blender so I have a…

Charlie Jolly commented on pull request blender/blender#111168 2023-08-22 04:32:58 +02:00
Fix #111017: Gap between color square and frame of box in the color ramp

Originally the extra pixel was used to align the arrow with the color ramp line. Additionally all these widgets suffer from not having a clickable area outside the main ramp, but I guess that's…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-22 04:26:14 +02:00
WIP: Node: Gabor Noise Texture

@blender-bot package

Charlie Jolly pushed to gabor at CharlieJolly/blender 2023-08-22 04:24:14 +02:00
fcd07d1c09 Additional comments and tidy
8fe47fde3a Merge branch 'main' into gabor
70430f9a56 Change scale factor back
ec8bf9ba73 Use a define for seed offset
fec2f071d3 Don't scale phasor based on impulses as this is already normalised by default
Compare 32 commits »
Charlie Jolly commented on pull request blender/blender#110802 2023-08-22 03:52:54 +02:00
WIP: Node: Gabor Noise Texture

Added to gabor_kernel function

Charlie Jolly commented on pull request blender/blender#110802 2023-08-22 03:35:57 +02:00
WIP: Node: Gabor Noise Texture

Note added.

Charlie Jolly opened issue blender/blender#111353 2023-08-21 18:06:43 +02:00
GPU Codegen parser warning
Charlie Jolly commented on pull request blender/blender#110802 2023-08-21 17:39:14 +02:00
WIP: Node: Gabor Noise Texture

I assume this is the same for all codebases or just glsl?

Charlie Jolly commented on pull request blender/blender#110802 2023-08-21 17:12:16 +02:00
WIP: Node: Gabor Noise Texture

See previous comment. Due to the way the impulse sum, it is a compromise between a scale factor that is too low and clips and is too high and creates a mid level grey 0.5 texture when scale factor…

Charlie Jolly commented on pull request blender/blender#110802 2023-08-21 17:07:06 +02:00
WIP: Node: Gabor Noise Texture

Locally I have updated the comment.

  /* Scale height of noise by the number of impulses. This is empircal as there is no easy way
   * to analytically determine the scaling factor for the…