Jacques Lucke JacquesLucke
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Jacques Lucke commented on pull request blender/blender#105513 2023-03-07 10:19:07 +01:00
Ignore build files for VS and VS Code

My vscode config files are always in the .vscode which is ignore for me already. I never ran into the problem that vscode adds files to the repo. You should demonstrate how to reproduce how…

Jacques Lucke pushed to index-mask-refactor at JacquesLucke/blender 2023-03-05 12:20:53 +01:00
e13543782c cleanup
Jacques Lucke pushed to index-mask-refactor at JacquesLucke/blender 2023-03-05 11:52:08 +01:00
5edfeada7a remove dependence on memory_resource because it's not available on macos
Jacques Lucke pushed to index-mask-refactor at JacquesLucke/blender 2023-03-05 11:40:48 +01:00
0610294156 cleanup
204b5aee6f evaluate expression on separate chunks
784b05e01f Merge branch 'main' into index-mask-refactor
4b0f5c2aad Fix build error introduced in previous commit.
f5e9a78216 GPU: Fix wrong barrier in tests
Compare 179 commits »
Jacques Lucke pushed to index-mask-refactor at JacquesLucke/blender 2023-02-28 19:39:24 +01:00
fb9e4d19f6 test other algorithm to determine possible chunks to check
Jacques Lucke closed issue blender/blender#97728 2023-02-28 14:46:20 +01:00
Geometry nodes: Point distribute on faces change density with object`s surface scale and seed.
Jacques Lucke commented on issue blender/blender#97728 2023-02-28 14:46:19 +01:00
Geometry nodes: Point distribute on faces change density with object`s surface scale and seed.

For Plane and one polygon it produces kinda 98—102 points. But for sphere it can produce 68—120 points…

When making such statements, please always provide a simple way to reproduce…

Jacques Lucke closed issue blender/blender#100770 2023-02-28 14:27:19 +01:00
Crash when creating Geometry Nodes group input with Python
Jacques Lucke commented on issue blender/blender#100770 2023-02-28 14:27:17 +01:00
Crash when creating Geometry Nodes group input with Python

This crash has been fixed by 52bd198153ede3c7131df895bb08e4828aab1e9b. To add group inputs one now has to use node_tree.inputs.new.

Jacques Lucke commented on issue blender/blender#101067 2023-02-28 12:26:33 +01:00
bool nodes 's edge out have rubish edge

@howardt Maybe I don't understand it correctly, but Self Intersection is turned off in the node, so why does your explanation make sense?

Jacques Lucke commented on pull request blender/blender#104420 2023-02-28 12:17:55 +01:00
Fix #104219: Node links are sometimes created from the wrong socket

This should mention which coordinate space is used.

Jacques Lucke commented on pull request blender/blender#105266 2023-02-27 20:55:09 +01:00
Mesh: Set bounds eagerly for cube and grid primitive nodes

I didn't check in detail yet, but this does not feel correct. It would only be correct if there was an infinite amount of vertices. The same likely applies to other primitives. It should still be possible to compute the bounding box efficiently in these cases, but it's not that trivial.

Jacques Lucke approved blender/blender#105195 2023-02-27 15:56:37 +01:00
I18n: add per-socket translation contexts for nodes

Besides what was mentioned in the code comments, this looks good to me.

Jacques Lucke commented on pull request blender/blender#105195 2023-02-27 15:54:43 +01:00
I18n: add per-socket translation contexts for nodes

That sounds reasonable. I guess the reason for why the std::stringstream was used is that you assigned it to a StringRef which does not have c_str method, because it might not be null-termin…

Jacques Lucke opened issue blender/blender#105251 2023-02-27 15:40:46 +01:00
Simulation Disk Cache Format
Jacques Lucke pushed to index-mask-refactor at JacquesLucke/blender 2023-02-27 14:54:52 +01:00
9b5d4a6de6 add utilities
Jacques Lucke pushed to index-mask-refactor at JacquesLucke/blender 2023-02-27 14:39:04 +01:00
2b9c0db965 initial finding of chunks to process
34cc0635a4 move foreach_segment to implementation file
38aa47a05f Merge branch 'main' into index-mask-refactor
c79c35b4d3 Merge branch 'blender-v3.5-release'
79bce99260 Fix #104857: crash when datafiles/assets folder does not exist
Compare 37 commits »
Jacques Lucke pushed to main at blender/blender 2023-02-27 14:03:11 +01:00
c79c35b4d3 Merge branch 'blender-v3.5-release'
79bce99260 Fix #104857: crash when datafiles/assets folder does not exist
9044ba0ae5 Compositor: Compositor Output should Follow Active Node.
f738843362 Metal: Fix possible uniform lookup issue.
Compare 4 commits »