Jacques Lucke JacquesLucke
  • Hennigsdorf near Berlin
  • Joined on 2013-11-18
Jacques Lucke commented on pull request blender/blender#104428 2023-02-08 18:47:33 +01:00
Geometry Nodes: Edges to Face Groups Node

It looks like these two nested loop call join more often than necessary.

Jacques Lucke suggested changes for blender/blender#104428 2023-02-08 18:47:33 +01:00
Geometry Nodes: Edges to Face Groups Node
Jacques Lucke commented on pull request blender/blender#104428 2023-02-08 18:47:33 +01:00
Geometry Nodes: Edges to Face Groups Node

Comment style.

Jacques Lucke commented on pull request blender/blender#104428 2023-02-08 18:47:32 +01:00
Geometry Nodes: Edges to Face Groups Node

Should be possible to parallelize this now.

Jacques Lucke commented on pull request blender/blender#104428 2023-02-08 18:47:32 +01:00
Geometry Nodes: Edges to Face Groups Node

Can probably use AtomicDisjointSet::calc_reduced_ids?

Jacques Lucke commented on pull request blender/blender#104428 2023-02-08 18:47:32 +01:00
Geometry Nodes: Edges to Face Groups Node

typo

Jacques Lucke commented on pull request blender/blender#104474 2023-02-08 18:36:28 +01:00
Assets: bundle essentials with Blender

@blender-bot package

Jacques Lucke commented on pull request blender/blender#104465 2023-02-08 18:29:06 +01:00
Cleanup: Use utility function to find groups in node tree

Ah I see, well either add this to the pull request description or just do the code change now already. Don't see much of a reason not to do it now already.

Jacques Lucke commented on pull request blender/blender#104465 2023-02-08 17:33:22 +01:00
Cleanup: Use utility function to find groups in node tree

This should internally avoid to enter the same node group multiple times. For very large node trees, with lots of nesting that could be quite heavy.

Jacques Lucke commented on pull request blender/blender#104465 2023-02-08 17:33:22 +01:00
Cleanup: Use utility function to find groups in node tree

Currently this uses the term group and tree. While we generally use those terms synonymously, it would be better to be consistent within a single function declaration.

Jacques Lucke commented on issue blender/blender#104444 2023-02-08 16:32:43 +01:00
Rotation C++ API

For now it is implemented as AngleRadian to leave no doubt.

Don't have a very strong opinion, but I'm fine with AngleRadian. Currently, I don't see a need for AngleDegree so I'd just…

Jacques Lucke commented on issue blender/blender#87006 2023-02-08 16:07:05 +01:00
Geometry Node: Changing modifier input values with python no cause update

@erik85 While I'm not generally against deferring updates, it something that has to be done with great care because it's a bit against current principles of the RNA/Python API. In this specific…

Jacques Lucke commented on pull request blender/blender#104474 2023-02-08 15:59:01 +01:00
Assets: bundle essentials with Blender
Jacques Lucke created pull request blender/blender#104474 2023-02-08 15:58:12 +01:00
Assets: bundle essentials with Blender
Jacques Lucke created branch bundled-assets in JacquesLucke/blender 2023-02-08 15:53:20 +01:00
Jacques Lucke pushed to bundled-assets at JacquesLucke/blender 2023-02-08 15:53:20 +01:00
f0ebd3d5f6 use publish directory
4525481e59 Merge branch 'main' into bundled-assets
Compare 2 commits »
Jacques Lucke created pull request blender/blender#104471 2023-02-08 14:52:52 +01:00
WIP: Core: use generic copy-on-write system to avoid unnecessary data copies
Jacques Lucke pushed to temp-copy-on-write at JacquesLucke/blender 2023-02-08 14:51:57 +01:00
06e1b3f9f6 Merge branch 'main' into temp-copy-on-write-customdata
43f308f216 Make update: Ignore submodules
aab707ab70 Un-ignore modules in .gitmodules configuration
4ed8a360e9 Fix references to the main branch in the .gitmodules
4d3bfb3f41 Subdivision Surface: fix a serious performance hit when mixing CPU & GPU.
Compare 9968 commits »