Code wise looking fine, but I'll leave up the decision to remove this in 4.3 to the animation & rigging module.
This function is now always called since it's on both branches of the if (region == nullptr)
check.
You figured it out correctly :)
I think instead of completely freeing the preview, it's better to just clear it so the icon-id won't change. So we need a way to clear the preview with the…
The earlier fix was not sufficient and the problem came back, see #124167. I reverted the fix and worked out a new one: #125084.
Alternative solution: As before, don't set ToolDef.data_block
(meaning the tool is not identified as a "brush" tool internally) and force display of the brush asset selector. Problem here is…
TODO: The initial click event doesn't trigger the tool operator correctly yet.
This has been quite a struggle to figure out. Issue is, when setting ToolDef.data_block
, this marks the…
Will this be exposed in API as well? I would like ability to filter by type for some of my ideas.
Yes this metadata is accessible from Python (which is how we need to access it as well).
Is this still an issue with the new brush assets system in main
? Brushes shouldn't be affected in any way by undo/redo there anymore.