Michael Parkin-White Michael-Parkin-White-Apple
  • Joined on 2020-05-06
Michael Parkin-White commented on issue blender/blender#121020 2024-04-29 17:58:03 +02:00
Viewport: Hair ribbon from geometry node have clipped ends

Looks like a small stride error during indexbuf building for triangles. PR has been submitted, but not sure if this fix would work universally for all cases. (As it may depend on if this code is…

Michael Parkin-White commented on issue blender/blender#121020 2024-04-29 17:14:12 +02:00
Viewport: Hair ribbon from geometry node have clipped ends

So this is happening on Metal, but I imagine the same issue would occur in OpenGL if use_strip_prims was also false in OpenGL.

`source/blender/draw/intern/draw_cache_impl_curves.cc - static…

Michael Parkin-White commented on issue blender/blender#121065 2024-04-29 17:08:50 +02:00
Metal: Workbench curve drawing artifacts

Same issue as #121020 afaik, so will keep discussion there.

Michael Parkin-White commented on issue blender/blender#121020 2024-04-27 10:08:39 +02:00
Viewport: Hair ribbon from geometry node have clipped ends

Currently a little tricky to see where this is going wrong. The backend seems to be rendering what it is given, although the geometry is doubling up on certain strands, when i'm unsure if it…

Michael Parkin-White commented on issue blender/blender#121065 2024-04-26 10:24:20 +02:00
Metal: Workbench curve drawing artifacts

Can have a look into this

Michael Parkin-White commented on issue blender/blender#121020 2024-04-24 16:02:58 +02:00
Viewport: Hair ribbon from geometry node have clipped ends

Will have a look into this

Michael Parkin-White commented on issue blender/blender#120038 2024-04-15 14:08:45 +02:00
EEVEE Next tests hang on macOS buildbot

As an additional note, I've now been able to consistently reproduce this on my local machine using the Tree Creature asset in EEVEE Next, instead of via the render tests. The stracktrace is…

Michael Parkin-White commented on pull request blender/blender#120432 2024-04-15 14:06:29 +02:00
Fix #120038: Possible fix for macOS buildbot test crash

Thanks Brecht, then I do believe we should still land this patch regardless, as it should not be changing GPU dispatch behavior on this flag.

(The flag is still situationally used to wait and…

Michael Parkin-White commented on pull request blender/blender#119784 2024-04-11 12:19:57 +02:00
Metal: Add AMD support for subpass transition

Thanks Jeroen, will resolve!

Good to confirm shadows working on Intel GPUs too. Will be performing a test pass on Intel later today to see where we are at overall.

Michael Parkin-White commented on pull request blender/blender#120432 2024-04-10 13:40:40 +02:00
Fix #120038: Possible fix for macOS buildbot test crash

Although, I do feel this patch makes sense to land regardless, as it should harden the category of errors and stalls when running in debug, as the flag now being disabled was not intended to be…

Michael Parkin-White commented on pull request blender/blender#120432 2024-04-09 17:50:51 +02:00
Fix #120038: Possible fix for macOS buildbot test crash

Hmm unfortunately timeout seems to still occur, will continue attempting to reproduce.

Michael Parkin-White commented on pull request blender/blender#120432 2024-04-09 15:40:32 +02:00
Fix #120038: Possible fix for macOS buildbot test crash

Please note that I was unable to reproduce the original crash, so this may not resolve the same issue, but is a best-guess at what may have been the root cause.

Michael Parkin-White commented on issue blender/blender#120038 2024-04-09 14:42:06 +02:00
EEVEE Next tests hang on macOS buildbot

So looking, the change is correctly in, but unsure why this is still hanging, investigating now, but will see if I can reproduce easily.

Michael Parkin-White commented on issue blender/blender#120038 2024-04-09 14:11:54 +02:00
EEVEE Next tests hang on macOS buildbot

Looking into this now, I do recall a separate fix for this, which should have resolved it. There was a small edge-case where if an event signal was in a single command buffer with no other…

Michael Parkin-White commented on pull request blender/blender#119784 2024-03-22 14:52:33 +01:00
Metal: Add AMD support for subpass transition

Apologies, left over, already addressed, will remove.

Michael Parkin-White commented on issue blender/blender#109363 2024-03-19 14:53:37 +01:00
GP Fill Tool not working on Mac with Metal GPU Backend

PR issued with the fix. Strokes should now render the same as OpenGL. There were a few small issues present, thickness and color parameters were being incorrectly propagated, and the datatype…

Michael Parkin-White commented on issue blender/blender#109363 2024-03-19 13:47:50 +01:00
GP Fill Tool not working on Mac with Metal GPU Backend

Thanks @brecht this helps clarify why the issue has been occurring, and should help with reproduction. @fclem I'll get on this.

My guess is what has happened is a possible change in the…

Michael Parkin-White commented on pull request blender/blender#117292 2024-03-19 10:47:05 +01:00
WIP: EEVEE: GPU: Add support for multiple async compilation threads

Should this be closed? or is this still looked after?

Yeah we can close this one, unless it is useful as WIP to potentially inform a future solution? Although this particular implementation…

Michael Parkin-White commented on issue blender/blender#119591 2024-03-18 11:00:35 +01:00
Erroneous Shadow with Eevee and Sun Lamp and Material with Shadow Mode None

Able to reproduce in both EEVEE and EEVEE Next, which is odd as they both use separate shadow techniques. Will investigate what is going on, imagine its possibly an issue with precision and that…

Michael Parkin-White commented on issue blender/blender#118868 2024-03-16 17:26:15 +01:00
EEVEE-Next: Render passes aren't being outputted on macOS

Patch above should resolve. Render pass rendering was fine, but CPU readback was not taking into account the texture view layer during sampling. Resulting in the same top-most layer being read…