Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim created pull request blender/blender#122694 2024-06-04 01:40:45 +02:00
Cleanup: make format
Sean Kim created branch make-format in Sean-Kim/blender 2024-06-04 01:39:09 +02:00
Sean Kim pushed to make-format at Sean-Kim/blender 2024-06-04 01:39:09 +02:00
06fe7abfcb Cleanup: make format
0566bf11b3 Cycles: Add debugging option to load custom OIDN weights
4439e39530 Fix: assignment in a condition
14c8f01d29 Fix: VSE handles can be moved if channel is locked
296ac0e9ef Cycles: improve light tree with large spot blend
Compare 10 commits »
Sean Kim commented on pull request blender/blender#122062 2024-06-03 23:24:53 +02:00
Sculpt: Add stroke stabilization to lasso tools

I'm not sure if this change is too wide-reaching to be included as part of this single PR, I included it here since it shouldn't have any external implications as the RNA loc property on the operator is already stored as float and not short or int

Sean Kim commented on pull request blender/blender#122062 2024-06-03 23:17:56 +02:00
Sculpt: Add stroke stabilization to lasso tools

@blender-bot package

Sean Kim pushed to lasso-stabilize at Sean-Kim/blender 2024-06-03 23:13:37 +02:00
308742e8fa Fix factor application in algorithm
Sean Kim commented on issue blender/blender#82139 2024-06-03 22:26:26 +02:00
Sculpt Mode TODO tasks

Consolidated some of the gesture tool TODOs into the standalone task #80390

Sean Kim commented on pull request blender/blender#122062 2024-06-01 04:20:53 +02:00
Sculpt: Add stroke stabilization to lasso tools

Though, fixing the factor calculation seems to expose a deeper issue when using high values (> 0.9), at the moment I think the gist of the problem is that everything is translated back down into…

Sean Kim commented on pull request blender/blender#122062 2024-06-01 03:13:56 +02:00
Sculpt: Add stroke stabilization to lasso tools

Great functionality... 👍

Quick question tho... Did a quick test and I noticed some "stepping" on the stroke, specially on higher radius value...

Is there a way to have a…

Sean Kim approved blender/blender#122437 2024-06-01 02:49:55 +02:00
UI: Reorganize mesh sculpt mode menus

Looks good from the code side of things

Sean Kim commented on issue blender/blender#122493 2024-05-31 03:09:08 +02:00
Line Trim tool has no Extrude Mode option exposed

In doing some testing, this appears to be how the existing trim tools behave on oblique angles like this; it's just more apparent visually when doing so with the Line Trim tool

Sean Kim commented on issue blender/blender#122493 2024-05-31 02:59:16 +02:00
Line Trim tool has no Extrude Mode option exposed

Verifying that I can repro this on a default cube

Sean Kim commented on issue blender/blender#122493 2024-05-31 02:51:54 +02:00
Line Trim tool has no Extrude Mode option exposed

Thanks for the report, I'll look into this.

Sean Kim commented on pull request blender/blender#122062 2024-05-31 02:43:27 +02:00
Sculpt: Add stroke stabilization to lasso tools

@blender-bot package

Sean Kim pushed to lasso-stabilize at Sean-Kim/blender 2024-05-31 02:40:44 +02:00
544114aa54 Rename variable and change to int2
Sean Kim deleted branch remove-constexpr from Sean-Kim/blender 2024-05-31 02:08:19 +02:00
Sean Kim pushed to main at blender/blender 2024-05-31 02:08:16 +02:00
af195f91c2 Cleanup: Remove accidentially added constexpr qualifier
Sean Kim merged pull request blender/blender#122419 2024-05-31 02:08:16 +02:00
Cleanup: Remove accidentially added constexpr qualifier
Sean Kim commented on pull request blender/blender#122062 2024-05-31 01:56:51 +02:00
Sculpt: Add stroke stabilization to lasso tools

I created a design task here: blender/blender#122521 with the points you've brought up & removed the sample code from this PR.

Sean Kim opened issue blender/blender#122521 2024-05-31 01:52:53 +02:00
Design: Support access to active tool operator properties