Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on issue blender/blender#120761 2024-04-18 08:20:53 +02:00
Sculpt Hide Tool doesn't hide all adjacent faces when single vertex is selected

I think I understand conceptually how this is happening and can probably have PR for this tomorrow. The hide tool only tags PBVH nodes for being updated when one of the node's own vertices changes…

Sean Kim pushed to hide-show-grow-shrink at Sean-Kim/blender 2024-04-18 03:16:20 +02:00
ad12f65b32 Fix bug with indexing, add larger iteration size support
Sean Kim opened issue blender/blender#120761 2024-04-18 02:33:44 +02:00
Sculpt Hide Tool doesn't hide all adjacent faces when single vertex is selected
Sean Kim commented on pull request blender/blender#120282 2024-04-18 01:19:36 +02:00
Sculpt: Add increase / decrease visibility operator

There's a bug somewhere in the current implementation when there's more than one PBVH node, I'm not yet sure exactly what's causing it.

Sean Kim commented on pull request blender/blender#120733 2024-04-17 11:37:59 +02:00
Fix #120731: sculpt trim tool crash

This allocation is already occurring in the existing code inside init_operation and is cleaned up when the unique_ptr goes out of scope by the GestureData destructor, but I agree that moving…

Sean Kim suggested changes for blender/blender#120733 2024-04-17 10:58:45 +02:00
Fix #120731: sculpt trim tool crash

Ugh, sorry. Don't know how I missed this crash before submitting the PR. Appreciate you taking a stab at the fix.

Sean Kim commented on pull request blender/blender#120733 2024-04-17 10:58:44 +02:00
Fix #120731: sculpt trim tool crash

The order of initialze_cursor_info and then init_operation is actually still needed. This fix would just introduce other errors on the following line:

Sean Kim pushed to hide-show-grow-shrink at Sean-Kim/blender 2024-04-17 02:52:43 +02:00
7eda982930 Address PR comments
903fef337f Merge branch 'main' of projects.blender.org:blender/blender into hide-show-grow-shrink
c3ee098c78 Fix #120655: GPv3: Conversion: invalid handling of generated 'offset radius' nodetree.
f465943872 Cleanup: GPv3 conversion: Remove unused public functions.
ddb2519339 BKE mesh legacy conversion: use new BKE_node_tree_add_in_lib when needed.
Compare 259 commits »
Sean Kim pushed to polyline-hide at Sean-Kim/blender 2024-04-17 00:33:12 +02:00
f8ac68bfb0 Merge branch 'main' of projects.blender.org:blender/blender into polyline-hide
d3fb68f518 Icons: Add Sculpt gesture icons
6091127a29 UI: Remove Redundant Hidden File Check for Linux/Mac
38f70e9cf2 Cleanup: Use Span for despgraph build argument
3d59514729 EEVEE-Next: Fix discrepancy between lookdev and forward
Compare 42 commits »
Sean Kim created pull request blender/blender#120718 2024-04-16 20:21:31 +02:00
Icons: Add Sculpt gesture icons
Sean Kim created branch icon-changes in Sean-Kim/blender 2024-04-16 20:19:37 +02:00
Sean Kim pushed to icon-changes at Sean-Kim/blender 2024-04-16 20:19:37 +02:00
0bfc1449b4 Icons: Add Sculpt gesture icons
d2df694439 EEVEE-Next: DoF: Avoid out of bound access in scatter vertex shader
420508b235 Fix (unreported) LibOverride: Assert when clearing a liboverride.
003489c693 Fix #120701: Overrides: Running Make Override operator in viewport without a selection created duplicates.
b1fb8eccb4 UI: Add tooltips to inputs of Color shader nodes
Compare 10 commits »
Sean Kim commented on issue blender/blender#120182 2024-04-16 19:28:48 +02:00
More Boolean Solvers

From the sculpting side of things, this comment and others in the issue may be helpful in gathering some requirement…

Sean Kim commented on pull request blender/blender#120282 2024-04-16 19:17:07 +02:00
Sculpt: Add increase / decrease visibility operator

Seems pretty reasonable, I'm sure this will be helpful for people. I don't fully understand the "duplicates" part of the multires neighbors system, I have to look at that to be more confident…

Sean Kim commented on pull request blender/blender#120282 2024-04-16 18:33:09 +02:00
Sculpt: Add increase / decrease visibility operator

Ah, I think I see how to do this from the documentation - Using mesh::face_corner_prev / mesh::face_corner_next, right?

Sean Kim commented on pull request blender/blender#119483 2024-04-16 17:53:36 +02:00
Sculpt: Add polyline hide operator

Updated the keymap so that with RCS enabled, the interactions remain the same (i.e. starting the tool & adding points with LMB and canceling with RMB / ESC)

Sean Kim pushed to polyline-hide at Sean-Kim/blender 2024-04-16 17:51:35 +02:00
a911660e8d Fix RCS tool interaction
Sean Kim commented on issue blender/blender#120681 2024-04-16 17:20:27 +02:00
Sculpt Gesture Fairing

@nickberckley - I wouldn't describe the current behavior of Line Project as being equivalent to Fair Tangency. The type of projection it's doing is simply moving affected vertices to the plane…

Sean Kim commented on pull request blender/blender#119483 2024-04-16 02:03:26 +02:00
Sculpt: Add polyline hide operator

I think there's an issue with the right click select keymap, it works quite differently-- I have to hold down right click for the whole operation and add points with LMB.

Thanks for the…