Sean Kim Sean-Kim
  • Joined on 2023-12-14
Sean Kim commented on issue blender/blender#108111 2024-02-08 08:29:13 +01:00
Update 'dyntopo_detail_size_edit' to support Relative/Brush Detail settings

Another question after getting it mostly working - currently moving left when selecting detail size on the Constant / Manual mode lowers the value which makes a larger resulting triangle and…

Sean Kim commented on issue blender/blender#108111 2024-02-08 02:03:03 +01:00
Update 'dyntopo_detail_size_edit' to support Relative/Brush Detail settings

@JulienKaspar - Just a few notes here about this

The important part is that it works with a limited range of values. Relative detail goes from 0-40 and Brush detail from 0.5-100%. Constant…

Sean Kim pushed to 112371-invisible-sculpt at Sean-Kim/blender 2024-02-08 00:41:10 +01:00
c27f9fa812 Merge branch 'blender-v4.1-release' of projects.blender.org:blender/blender into 112371-invisible-sculpt
34687be693 Move visibility check earlier in function
b6091f134c Fix #117956: Revert Last Chance Placeholder Default
e7dcad8599 Fix: Release all OIDN GPU resources when recreating denoiser
bd8a44e169 Lights: Option to use old point light falloff
Compare 157 commits »
Sean Kim created repository Sean-Kim/blender-developer-docs 2024-02-07 23:59:00 +01:00
Sean Kim commented on pull request blender/blender#117746 2024-02-07 23:41:14 +01:00
Sculpt: Disable sculpt brushes on invisible objects

Oh true, will move this there.

Sean Kim commented on issue blender/blender#112371 2024-02-07 02:01:57 +01:00
Sculpting/Painting on invisible objects

Copying this list from the current PR, the following operators all need to still be changed to cancel when interacting with hidden geometry

  • SCULPT_OT_expand
  • SCULPT_OT_trim_box_gesture
Sean Kim commented on pull request blender/blender#117746 2024-02-07 01:57:35 +01:00
Sculpt: Disable sculpt brushes on invisible objects

Edited the title of the PR slightly to reflect some findings after testing the most recent change, I'll put this update in #112371, but the summary of it is that the following operators currently…

Sean Kim commented on pull request blender/blender#117746 2024-02-07 01:51:13 +01:00
Sculpt: Disable sculpt brushes on invisible objects

Made the change, manually tested the various operators that call into the method and didn't find any crashes for them when operating on invisible geometry, though they do still perform the…

Sean Kim pushed to 112371-invisible-sculpt at Sean-Kim/blender 2024-02-07 01:49:27 +01:00
292f879f97 Move visibility check into SCULPT_cursor_geometry_info_update
Sean Kim opened issue blender/blender#117929 2024-02-07 01:26:02 +01:00
"Extract Face Set" crash
Sean Kim commented on pull request blender/blender#117746 2024-02-06 11:04:16 +01:00
Sculpt: Disable sculpt brushes on invisible objects

Admittedly, I cut the investigation of moving this into SCULPT_cursor_geometry_info_update rather short after seeing it referenced from the SCULPT_OT_sample_detail_size and `SCULPT_OT_cloth_fil…

Sean Kim opened issue blender/blender-manual#104695 2024-02-06 02:05:16 +01:00
Dyntopo missing "Manual Detail" explanation
Sean Kim commented on issue blender/blender#108111 2024-02-06 00:33:54 +01:00
Update 'dyntopo_detail_size_edit' to support Relative/Brush Detail settings

Starting to work on this, one clarifying question I have right now @JulienKaspar:

When replacing the existing brush mode detail type with the new display, should the percentage (24.8% in the…

Sean Kim pushed to 112371-invisible-sculpt at Sean-Kim/blender 2024-02-05 23:23:50 +01:00
28bdd9bd7f Access base via CTX_data_active_base
Sean Kim commented on pull request blender/blender#117746 2024-02-03 01:41:20 +01:00
Sculpt: Disable sculpt brushes on invisible objects

Ok, addressed changes so far and updated the description with a new GIF, I think the PR is now in a state where the functionality can be tested @JulienKaspar

Sean Kim pushed to 112371-invisible-sculpt at Sean-Kim/blender 2024-02-03 01:39:09 +01:00
242bc12d97 Remove lingering BKE_layer function from initial revisino
Sean Kim pushed to 112371-invisible-sculpt at Sean-Kim/blender 2024-02-03 01:20:00 +01:00
cada2b54fe Merge branch 'main' of projects.blender.org:blender/blender into 112371-invisible-sculpt
cb22d0f92b Replace custom visibility code, prevent sculpt cursor from reacting to invisible geometry
f355b20262 Fix #106326: Add scale-bias processing for UsdUVTexture
586fadd6d2 Geometry Nodes: deduplicate arrays in baked data
17f075222f Fix: Adjust Grease Pencil invert icon
Compare 41 commits »
Sean Kim commented on pull request blender/blender#117746 2024-02-02 23:09:48 +01:00
Sculpt: Disable sculpt brushes on invisible objects

Marking this as WIP for now since there's a fair amount of feedback to address.

@JulienKaspar - Makes sense, I'll keep that in mind for how the feature is intended to work. I'll investigate…

Sean Kim deleted branch gp-invert-icon-fix from Sean-Kim/blender 2024-02-02 21:38:56 +01:00
Sean Kim created pull request blender/blender#117769 2024-02-02 21:09:44 +01:00
Fix: Adjust Grease Pencil invert icon