Yonatan-Maor
1 Followers · 0 Following
  • Joined on 2023-04-26
Repositories
1
 Projects Public Activity Starred Repositories
1
Yonatan-Maor commented on issue blender/blender#107534 2024-02-01 12:47:52 +01:00
Viewport: anti-alising on normal lines

If you can further elaborate on the issue, I'd be happy to continue working on it, but I abandoned it for long enough that @Erina-Koomen should definitely have priority over me :)

Yonatan-Maor commented on issue blender/blender#107534 2023-05-02 18:07:48 +02:00
Viewport: anti-alising on normal lines

So according to my best understanding the way that the normals are drawn is quite different from the way the axes are drawn, and I've been advised to avoid changing them for now.

Questions is,…

Yonatan-Maor pushed to main at Yonatan-Maor/blender 2023-05-01 19:58:43 +02:00
c7f1ad1058 Fix #107474: Proportional Size not saved when canceling the operation
5525e5b942 Fix #107480: Crashes in mesh format conversion for old files
3c74575dac Fix #107062: support opacityThreshold when exporting USD
f59fdc40ec Fix: Missing normalization for sampled normals when adding curves
314866eb3a Fix #107431: tag node tree topology as changed when changing socket order
Compare 67 commits »
Yonatan-Maor commented on issue blender/blender#107038 2023-05-01 19:15:13 +02:00
Viewport: add anti-aliasing to transform axes lines

@pablovazquez I was looking for the next task, so I'll take a look. Should we open a new issue for this, or should I just work on it without an issue?

Yonatan-Maor deleted branch fix_107038_add_anti_aliasing_to_transform_constraints from Yonatan-Maor/blender 2023-04-30 06:01:52 +02:00
Yonatan-Maor reopened pull request blender/blender#107394 2023-04-28 15:43:05 +02:00
Add anti aliasing to transform constraints
Yonatan-Maor closed pull request blender/blender#107438 2023-04-28 15:42:58 +02:00
WIP: Add anti aliasing to transform constraints #107394
Yonatan-Maor commented on pull request blender/blender#107438 2023-04-28 15:37:21 +02:00
WIP: Add anti aliasing to transform constraints #107394

@mod_moder Couldn't find where to do it. I'll take a better look

Yonatan-Maor created pull request blender/blender#107438 2023-04-28 15:33:27 +02:00
WIP: Add anti aliasing to transform constraints #107394
d891f4311d Removed commented lines from transform_constraints.c
f11fb1a003 Corrected transform line anti-aliasing to be portable to MacOS and Metal backend
3d296f664f Removed unnecessary line from the issue fix
215638e9fc Fix #107038: Added anti-aliasing to transform constraints
Compare 4 commits »
Yonatan-Maor deleted branch fix_107038_add_anti_aliasing_to_transform_constraints from Yonatan-Maor/blender 2023-04-28 15:27:00 +02:00
Yonatan-Maor closed pull request blender/blender#107394 2023-04-28 15:26:59 +02:00
Add anti aliasing to transform constraints
Yonatan-Maor pushed to main at Yonatan-Maor/blender 2023-04-28 15:24:01 +02:00
d74f3895e7 Overlay: do not draw grids with undefined units
67203c0ec8 3D View: Refactor navigation operators
ff0cf45bc2 Fix potential buffer overflows from invalid string size arguments
ba978e1b68 Fix potential buffer overflow in internal pointcache logic
e462e20e21 Fix buffer overflow in BKE_image_ensure_tile_token use
Compare 38 commits »
Yonatan-Maor commented on pull request blender/blender#107394 2023-04-28 05:54:51 +02:00
Add anti aliasing to transform constraints

Made the requested changes. Adding New before/after images:

369ec65db9 Corrected transform line anti-aliasing to be portable to MacOS and Metal backend
Yonatan-Maor commented on pull request blender/blender#107394 2023-04-27 23:27:19 +02:00
Add anti aliasing to transform constraints

I think that I'm getting the expected result using this code snippet (thanks @Harley ) Thing is, the lines are extremely thin, which makes them look aliased again (I tried increasing the…

Yonatan-Maor commented on pull request blender/blender#107394 2023-04-27 20:59:01 +02:00
Add anti aliasing to transform constraints

Not sure that I'm well acquainted enough with the code to do this, but I'll take a look. If you have any time, could you explain why this wouldn't work on other platforms? I simply took the code…

Yonatan-Maor commented on pull request blender/blender#107394 2023-04-27 19:30:13 +02:00
Add anti aliasing to transform constraints

Thanks! I'm kind of new here, who should be authorizing the pull request?

Yonatan-Maor commented on pull request blender/blender#107394 2023-04-27 16:55:26 +02:00
Add anti aliasing to transform constraints

WIP would say that this is not ready for review and approving and is still being developed. Some about this: https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

Cool, I'll take a look