blender/blender-addons-contrib
Archived
3
11
Fork 17
Code Pull Requests 3 Activity

New Addon: Import Autodesk .max #22

Closed
Sebastian Sille wants to merge 38 commits from (deleted):nrgsille-import_max into main
pull from: (deleted):nrgsille-import_max
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 2 Commits 38 Files Changed 2 +1578
Sebastian Sille commented 2023-11-22 23:25:26 +01:00
Member
Copy Link

Created new addon for importing meshes and materials from Autodesk .max files
Upload to contribution for testing purposes, the regular pull request can be found here: #105013

Created new addon for importing meshes and materials from Autodesk .max files Upload to contribution for testing purposes, the regular pull request can be found here: [#105013](https://projects.blender.org/blender/blender-addons/pulls/105013)
👀 2 🎉 2
Sebastian Sille self-assigned this 2023-11-22 23:25:26 +01:00
Sebastian Sille added 1 commit 2023-11-22 23:25:28 +01:00 
Uploaded new addon for importing meshes and materials from Autodesk .max files
Sebastian Sille requested review from Campbell Barton 2023-11-22 23:28:47 +01:00
Sebastian Sille added 1 commit 2023-11-27 02:47:53 +01:00 
Added import options for scale and transform
Fixed axis conversion
Sebastian Sille added 1 commit 2023-11-27 11:43:10 +01:00 
Updated UI design to blender standard
Sebastian Sille added 1 commit 2023-11-27 13:31:35 +01:00 
Changed variable for matrix chunk to avoid confusion with real matrix
Removed debug keyword
Sebastian Sille added 1 commit 2023-11-27 13:50:57 +01:00 
Changed variable for matrix chunk to avoid confusion with real matrix
Sebastian Sille added 1 commit 2023-11-27 15:32:13 +01:00 
Removed write mode from data import
Sebastian Sille added 1 commit 2023-11-27 15:57:19 +01:00 
Changed definition order for better overview
Sebastian Sille added 1 commit 2023-11-27 20:23:53 +01:00 
Added options to import materials and UV as mesh object
Sebastian Sille added 1 commit 2023-11-28 01:26:18 +01:00 
Fixed vray material import
Sebastian Sille added 1 commit 2023-11-28 02:08:22 +01:00 
Fixed arch material import
Sebastian Sille added 1 commit 2023-11-28 02:28:57 +01:00 
Removed property decorate
Sebastian Sille added 1 commit 2023-11-29 01:08:51 +01:00 
Check if mesh is editable poly
Sebastian Sille added 1 commit 2023-11-29 01:15:34 +01:00 
Removed unused code
Sebastian Sille added 1 commit 2023-11-29 01:46:58 +01:00 
Cleanup tabs and spaces
Sebastian Sille added 1 commit 2023-11-29 14:19:18 +01:00 
Added node_shader_utils principled BSDF wrapper
Removed parameters wich are incompatible for blender
Sebastian Sille added 1 commit 2023-11-29 14:28:53 +01:00 
Changed specularity default
Sebastian Sille added 1 commit 2023-11-29 22:29:34 +01:00 
Ensure there are enough bytes to read
Sebastian Sille added 1 commit 2023-12-01 20:30:39 +01:00 
Fixed material import
Sebastian Sille added 1 commit 2023-12-01 22:33:56 +01:00 
Changed blender version to last compatible version
Cleanup unused code
Sebastian Sille added 1 commit 2023-12-02 12:18:18 +01:00 
Added chunk definitions
Sebastian Sille added 1 commit 2023-12-02 13:10:50 +01:00 
Cleanup tabs and spaces
Sebastian Sille added 1 commit 2023-12-03 23:05:59 +01:00 
Added additional arch material parameter
Removed unused code
Sebastian Sille added 1 commit 2023-12-04 20:01:34 +01:00 
Fixed crash with files from latest version
Removed unnessecary code
Removed unused imports
Sebastian Sille added 1 commit 2023-12-04 20:17:28 +01:00 
Removed unused variables
Sebastian Sille added 1 commit 2023-12-04 22:18:01 +01:00 
Removed unused code
Sebastian Sille added 1 commit 2023-12-04 23:23:16 +01:00 
Removed unused boolean
Sebastian Sille added 1 commit 2023-12-05 01:15:29 +01:00 
Added material properties for corona renderer
Sebastian Sille added 1 commit 2023-12-05 02:14:53 +01:00 
Cleanup code and style
Sebastian Sille added 1 commit 2023-12-06 22:56:35 +01:00 
Removed unused code
Campbell Barton requested changes 2023-12-07 14:06:24 +01:00
Campbell Barton left a comment
Owner

Tested this to import: https://www.cgtrader.com/items/612400/download-page
quite a lot of objects are out of place but at least there were no errors.

This review is only on the basics, requests:

  • Use a package io_scene_max where __init__.py just defines the operator & UI.
  • Move import logic into io_scene_max/import_max.py (lazy import this sub-module when the user activates import, improves blender startup time).
  • Run autopep8 on the script, the formatting is generally improved.
  • Also, try run a checker such as ruff or pylint, there are various warnings that aren't severe but nice to resolve.
Tested this to import: https://www.cgtrader.com/items/612400/download-page quite a lot of objects are out of place but at least there were no errors. This review is only on the basics, requests: - Use a package `io_scene_max` where `__init__.py` just defines the operator & UI. - Move import logic into `io_scene_max/import_max.py` (lazy import this sub-module when the user activates import, improves blender startup time). - Run autopep8 on the script, the formatting is generally improved. - Also, try run a checker such as `ruff` or `pylint`, there are various warnings that aren't severe but nice to resolve.
Sebastian Sille commented 2023-12-07 14:25:57 +01:00
Author
Member
Copy Link

Tested this to import: https://www.cgtrader.com/items/612400/download-page
quite a lot of objects are out of place but at least there were no errors.

This review is only on the basics, requests:

  • Use a package io_scene_max where __init__.py just defines the operator & UI.
  • Move import logic into io_scene_max/import_max.py (lazy import this sub-module when the user activates import, improves blender startup time).
  • Run autopep8 on the script, the formatting is generally improved.
  • Also, try run a checker such as ruff or pylint, there are various warnings that aren't severe but nice to resolve.

@ideasman42 Okay will do that, the object placement problem is the same like in the .3ds importer. If the max scene has applied transformation then it works perfect. I also added an option to apply the matrix from the file, sometimes there will be better results.

> Tested this to import: https://www.cgtrader.com/items/612400/download-page > quite a lot of objects are out of place but at least there were no errors. > > This review is only on the basics, requests: > > - Use a package `io_scene_max` where `__init__.py` just defines the operator & UI. > - Move import logic into `io_scene_max/import_max.py` (lazy import this sub-module when the user activates import, improves blender startup time). > - Run autopep8 on the script, the formatting is generally improved. > - Also, try run a checker such as `ruff` or `pylint`, there are various warnings that aren't severe but nice to resolve. @ideasman42 Okay will do that, the object placement problem is the same like in the .3ds importer. If the max scene has applied transformation then it works perfect. I also added an option to apply the matrix from the file, sometimes there will be better results.
Sebastian Sille added 1 commit 2023-12-07 16:37:31 +01:00
Sebastian Sille added 1 commit 2023-12-07 16:38:56 +01:00
Sebastian Sille added 1 commit 2023-12-07 16:39:11 +01:00
Sebastian Sille added 1 commit 2023-12-07 16:41:40 +01:00
Sebastian Sille added 1 commit 2023-12-07 16:46:47 +01:00
Sebastian Sille added 1 commit 2023-12-07 16:47:33 +01:00
Sebastian Sille added 1 commit 2023-12-07 16:47:44 +01:00
Sebastian Sille added 1 commit 2023-12-07 16:48:56 +01:00
Sebastian Sille added 1 commit 2023-12-07 16:49:09 +01:00
Sebastian Sille commented 2023-12-07 16:59:33 +01:00
Author
Member
Copy Link

@ideasman42 Everthing done now^^

@ideasman42 Everthing done now^^
Sebastian Sille requested review from Campbell Barton 2023-12-07 17:21:48 +01:00
Sebastian Sille closed this pull request 2023-12-08 14:27:43 +01:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Campbell Barton
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Sebastian Sille
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons-contrib#22
No description provided.
Delete Branch "(deleted):nrgsille-import_max"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?