FBX exporting animation with 1 fps #99876

New Issue

Konstantin Kharkovschenko · 2022-07-20T18:45:15+02:00

2022-07-20 18:45:15 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.77

Blender Version
Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-07-19 23:16, hash: blender/blender@40ffb94ab4
Worked: Blender 3.2.1

Short description of error
When exporting FBX it ignores scene fps value and make it 1 fps. So when I put it in Unity I get 4 frames animation for 4 seconds 30 fps in Blender. If I import it in 3ds Max I get all 120 frames but importer warnings that file has different fps.

Exact steps for others to reproduce the error
Open scene, export fbx with default settings, place in unity project and see clip duration and fps in animation tab

fbx_fps_bug.blend

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.77 **Blender Version** Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-07-19 23:16, hash: `blender/blender@40ffb94ab4` Worked: Blender 3.2.1 **Short description of error** When exporting FBX it ignores scene fps value and make it 1 fps. So when I put it in Unity I get 4 frames animation for 4 seconds 30 fps in Blender. If I import it in 3ds Max I get all 120 frames but importer warnings that file has different fps. **Exact steps for others to reproduce the error** Open scene, export fbx with default settings, place in unity project and see clip duration and fps in animation tab [fbx_fps_bug.blend](https://archive.blender.org/developer/F13303660/fbx_fps_bug.blend)

Konstantin Kharkovschenko commented

2022-07-20 18:45:15 +02:00

Added subscriber: @Morphin

blender-admin commented

2022-07-20 18:45:15 +02:00

#102398 was marked as duplicate of this issue

blender-admin commented

2022-07-20 18:45:15 +02:00

blender/blender#101655 was marked as duplicate of this issue

blender-admin commented

2022-07-20 18:45:15 +02:00

blender/blender#101216 was marked as duplicate of this issue

blender-admin commented

2022-07-20 18:45:15 +02:00

#101066 was marked as duplicate of this issue

blender-admin commented

2022-07-20 18:45:15 +02:00

#101056 was marked as duplicate of this issue

blender-admin commented

2022-07-20 18:45:15 +02:00

#100963 was marked as duplicate of this issue

blender-admin commented

2022-07-20 18:45:15 +02:00

blender/blender#100151 was marked as duplicate of this issue

Omar Emara commented

2022-07-21 13:04:40 +02:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-07-21 13:04:40 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Omar Emara commented

2022-07-21 13:04:40 +02:00

I don't have Unity to test myself, but I suspect the change in behavior is caused by b91319aead.
The exporter does a linear search and finds the last matching time mode and frame rate:

for ref_fps, fps_mode in FBX_FRAMERATES:
if similar_values(fps, ref_fps):
fbx_fps = ref_fps
fbx_fps_mode = fps_mode

And now that the 30 FPS drop frame mode was added (30.0, 7), # Drop frame., scenes with 30 frames are exported as such, so maybe the exporter should break upon the first match.

I don't have Unity to test myself, but I suspect the change in behavior is caused by b91319aead. The exporter does a linear search and finds the last matching time mode and frame rate: ```lang=python ``` for ref_fps, fps_mode in FBX_FRAMERATES: if similar_values(fps, ref_fps): fbx_fps = ref_fps fbx_fps_mode = fps_mode ``` ``` And now that the 30 FPS drop frame mode was added `(30.0, 7), # Drop frame.`, scenes with 30 frames are exported as such, so maybe the exporter should break upon the first match.

Konstantin Kharkovschenko commented

2022-07-21 14:49:38 +02:00

I tried to setup different fps in the scene before export. Result is the same

Omar Emara commented

2022-07-21 15:03:05 +02:00

But the exporter works correctly in 3.2, right?

Konstantin Kharkovschenko commented

2022-07-21 17:27:44 +02:00

In #99876#1393655, @OmarEmaraDev wrote:
But the exporter works correctly in 3.2, right?

Yes. And it respects scene fps settings. I tried with 24, 30 and 60

> In #99876#1393655, @OmarEmaraDev wrote: > But the exporter works correctly in 3.2, right? Yes. And it respects scene fps settings. I tried with 24, 30 and 60

Omar Emara commented

2022-07-22 07:07:29 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Needs Triage'

Omar Emara commented

2022-07-22 13:55:34 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Omar Emara commented

2022-07-22 13:55:34 +02:00

I went over this again, the only change to the FBX exporter in that period is b91319aead, can you try to revert it manually and check if it resolves the issue?
I also compared an ASCII dumps of both files from 3.2 and 3.3 and there was no difference, so I am not sure what could have caused this change in behavior.

I went over this again, the only change to the FBX exporter in that period is b91319aead, can you try to revert it manually and check if it resolves the issue? I also compared an ASCII dumps of both files from 3.2 and 3.3 and there was no difference, so I am not sure what could have caused this change in behavior.

Konstantin Kharkovschenko commented

2022-07-25 12:48:49 +02:00

Yes. Commenting just 126 line in fbx_utils.py solved issue ((30.0, 7), # Drop frame.). Maybe it's because there are two 30 fps presets in list?

FBX_FRAMERATES = (
    #(-1.0, 0),  # Default framerate.
    (-1.0, 14),  # Custom framerate.
    (120.0, 1),
    (100.0, 2),
    (60.0, 3),
    (50.0, 4),
    (48.0, 5),
    (30.0, 6),  # BW NTSC, full frame.
    #(30.0, 7),  # Drop frame.
    (30.0 / 1.001, 9),  # Color NTSC, full frame.
    (30.0 / 1.001, 8),  # Color NTSC, drop frame.
    (25.0, 10),
    (24.0, 11),
    (1.0, 12),  # 1000 milli/s (use for date time?).
    (24.0 / 1.001, 13),
    (96.0, 15),
    (72.0, 16),
    (60.0 / 1.001, 17),
    (120.0 / 1.001, 18),
)

Yes. Commenting just 126 line in fbx_utils.py solved issue ((30.0, 7), # Drop frame.). Maybe it's because there are two 30 fps presets in list? ``` FBX_FRAMERATES = ( #(-1.0, 0), # Default framerate. (-1.0, 14), # Custom framerate. (120.0, 1), (100.0, 2), (60.0, 3), (50.0, 4), (48.0, 5), (30.0, 6), # BW NTSC, full frame. #(30.0, 7), # Drop frame. (30.0 / 1.001, 9), # Color NTSC, full frame. (30.0 / 1.001, 8), # Color NTSC, drop frame. (25.0, 10), (24.0, 11), (1.0, 12), # 1000 milli/s (use for date time?). (24.0 / 1.001, 13), (96.0, 15), (72.0, 16), (60.0 / 1.001, 17), (120.0 / 1.001, 18), ) ```

Omar Emara commented

2022-07-25 13:25:43 +02:00

That was my initial guess, but you said it also doesn't work with 24 and 60, so I am not sure why that extra 30 entry would cause issue for 24 and 60.

Konstantin Kharkovschenko commented

2022-07-25 14:42:47 +02:00

Em... I've tried 24,30 and 60 in 3.2. In 3.3 I've tried only 30 and "Custom 30". Now I've tried 24 and 60 in 3.3 and it exports correctly. Sorry for misleading.

Omar Emara commented

2022-07-25 15:11:13 +02:00

Changed status from 'Needs User Info' to: 'Confirmed'

Omar Emara commented

2022-07-25 15:11:13 +02:00

Alright, confirming with my previous comment.

In #99876#1393613, @OmarEmaraDev wrote:
I don't have Unity to test myself, but I suspect the change in behavior is caused by b91319aead.
The exporter does a linear search and finds the last matching time mode and frame rate:
    for ref_fps, fps_mode in FBX_FRAMERATES:
        if similar_values(fps, ref_fps):
            fbx_fps = ref_fps
            fbx_fps_mode = fps_mode
And now that the 30 FPS drop frame mode was added (30.0, 7), # Drop frame., scenes with 30 frames are exported as such, so maybe the exporter should break upon the first match.

Alright, confirming with my previous comment. > In #99876#1393613, @OmarEmaraDev wrote: > I don't have Unity to test myself, but I suspect the change in behavior is caused by b91319aead. > The exporter does a linear search and finds the last matching time mode and frame rate: > ```lang=python > for ref_fps, fps_mode in FBX_FRAMERATES: > if similar_values(fps, ref_fps): > fbx_fps = ref_fps > fbx_fps_mode = fps_mode > ``` > And now that the 30 FPS drop frame mode was added `(30.0, 7), # Drop frame.`, scenes with 30 frames are exported as such, so maybe the exporter should break upon the first match.

Richard Antalik commented

2022-08-30 20:58:56 +02:00

Added subscribers: @hichamo6, @iss