blender/blender-addons
19
43
Fork 96
Code Issues 628 Pull Requests 27 Projects 1 Releases Wiki Activity

Storm Hydra render addon #104597

Merged
Brecht Van Lommel merged 22 commits from BogdanNagirniak/blender-addons:storm-hydra-addon into main 2023-08-04 17:02:11 +02:00
Conversation 0 Commits 22 Files Changed 4 +385
Bogdan Nagirniak commented 2023-05-10 10:54:30 +02:00
Contributor
Copy Link

Purpose

As part of Hydra Render engine we are providing Hydra Storm render addon.
This is also could be an example of how to create Hydra render addon.

Technical steps

  1. Created class StormHydraRenderEngine(bpy_hydra.HydraRenderEngine).
  2. Added engine's properties and corresponded settings panel.
  3. Added and hided some existing UI panels.

Notes

New addon is in TESTING status.
Currently not working for Final render (returns empty image) due to OpenGL bugs.

Render screenshots

Screenshot 2023-05-10 115125.png
Screenshot 2023-05-10 115348.png

### Purpose As part of [Hydra Render engine](https://projects.blender.org/blender/blender/pulls/104712) we are providing Hydra Storm render addon. This is also could be an example of how to create Hydra render addon. ### Technical steps 1. Created `class StormHydraRenderEngine(bpy_hydra.HydraRenderEngine)`. 2. Added engine's properties and corresponded settings panel. 3. Added and hided some existing UI panels. ### Notes New addon is in TESTING status. Currently not working for Final render (returns empty image) due to OpenGL bugs. ### Render screenshots ![Screenshot 2023-05-10 115125.png](/attachments/9f233c1c-2f48-4202-9a1e-f86bb5f9c9d6) ![Screenshot 2023-05-10 115348.png](/attachments/25b0bbd2-b413-4b7f-a53a-be98ef6d9f22)
Screenshot 2023-05-10 115125.png
451 KiB
Screenshot 2023-05-10 115348.png
589 KiB
Bogdan Nagirniak added 6 commits 2023-05-10 10:54:32 +02:00 
Added code
Added EEVEE world light panel

Co-authored-by: georgiy.m.markelov@gmail.com <georgiy.m.markelov@gmail.com>
Pull Request #1
Adjust code due rename module hydra.py -> bpy_hydra.py

Pull Request #2
Added plugin/usd/hdStorm

Pull Request #6
Bogdan Nagirniak requested review from Brecht Van Lommel 2023-05-10 10:54:58 +02:00
Bogdan Nagirniak requested review from Brian Savery (AMD) 2023-05-10 10:54:59 +02:00
Brecht Van Lommel requested changes 2023-05-10 20:51:46 +02:00
hydra_storm/__init__.py Outdated
@ -0,0 +5,4 @@
bl_info = {
"name": "Hydra render engine: Storm",
Brecht Van Lommel commented 2023-05-10 18:53:38 +02:00
Owner
Copy Link

Hydra render engine: Storm -> Hydra Storm render engine

Hydra render engine: Storm -> Hydra Storm render engine
brecht marked this conversation as resolved
hydra_storm/__init__.py Outdated
@ -0,0 +9,4 @@
"author": "AMD",
"version": (1, 0, 0),
"blender": (3, 5, 0),
"location": "Info header > Render engine menu",
Brecht Van Lommel commented 2023-05-10 18:54:05 +02:00
Owner
Copy Link

This is outdated, the render engine choice hasn't been there since 2.8.

This is outdated, the render engine choice hasn't been there since 2.8.
brecht marked this conversation as resolved
hydra_storm/__init__.py
@ -0,0 +10,4 @@
"version": (1, 0, 0),
"blender": (3, 5, 0),
"location": "Info header > Render engine menu",
"description": "Storm GL delegate for Hydra render engine",
Brecht Van Lommel commented 2023-05-10 18:54:59 +02:00
Owner
Copy Link

"GL" is not accurate for Metal and Vulkan.

I'm also not sure "Storm GL delegate for Hydra render engine" means.

"GL" is not accurate for Metal and Vulkan. I'm also not sure "Storm GL delegate for Hydra render engine" means.
brecht marked this conversation as resolved
hydra_storm/__init__.py
@ -0,0 +16,4 @@
"community": "",
"downloads": "",
"main_web": "",
"support": 'TESTING',
Brecht Van Lommel commented 2023-05-10 18:56:29 +02:00
Owner
Copy Link

TESTING -> OFFICIAL

TESTING -> OFFICIAL
brecht marked this conversation as resolved
hydra_storm/engine.py Outdated
@ -0,0 +11,4 @@
class StormHydraRenderEngine(bpy_hydra.HydraRenderEngine):
bl_idname = 'StormHydraRenderEngine'
bl_label = "Hydra: Storm"
Brecht Van Lommel commented 2023-05-10 18:57:45 +02:00
Owner
Copy Link

Hydra: Storm -> Hydra Storm

Hydra: Storm -> Hydra Storm
brecht marked this conversation as resolved
hydra_storm/engine.py Outdated
@ -0,0 +12,4 @@
class StormHydraRenderEngine(bpy_hydra.HydraRenderEngine):
bl_idname = 'StormHydraRenderEngine'
bl_label = "Hydra: Storm"
bl_info = "Hydra Storm (OpenGL) render delegate"
Brecht Van Lommel commented 2023-05-10 18:58:15 +02:00
Owner
Copy Link

(OpenGL) is not accurate for Metal and Vulkan

(OpenGL) is not accurate for Metal and Vulkan
brecht marked this conversation as resolved
hydra_storm/plugin/usd/hdStorm/resources/plugInfo.json Outdated
@ -0,0 +1,22 @@
{
Brecht Van Lommel commented 2023-05-10 19:01:03 +02:00
Owner
Copy Link

This should already be included with the USD libraries, why is it here again?

This should already be included with the USD libraries, why is it here again?
Georgiy Markelov commented 2023-05-11 17:06:16 +02:00
Member
Copy Link

We think it's better to bundle this folder with addon to be sure everything is needed here. But no problem if you think it's better to move it to blender.shared.

We think it's better to bundle this folder with addon to be sure everything is needed here. But no problem if you think it's better to move it to `blender.shared`.
Brecht Van Lommel commented 2023-05-11 18:14:20 +02:00
Owner
Copy Link

I would expected it's already in blender.shared?

It at least available to be copied there:
https://svn.blender.org/svnroot/bf-blender/trunk/lib/linux_x86_64_glibc_228/usd/plugin/usd/hdStorm/resources/

I would expected it's already in `blender.shared`? It at least available to be copied there: https://svn.blender.org/svnroot/bf-blender/trunk/lib/linux_x86_64_glibc_228/usd/plugin/usd/hdStorm/resources/
Georgiy Markelov commented 2023-05-12 11:56:18 +02:00
Member
Copy Link

Yes, it was. Should we remove this folder here and add copying to blender.shared?

Yes, it was. Should we remove this folder here and add copying to `blender.shared`?
Brecht Van Lommel commented 2023-05-12 12:04:14 +02:00
Owner
Copy Link

Yes.

Yes.
brecht marked this conversation as resolved
hydra_storm/properties.py Outdated
@ -0,0 +7,4 @@
class Properties(bpy.types.PropertyGroup):
bl_type = None
Brecht Van Lommel commented 2023-05-10 19:02:11 +02:00
Owner
Copy Link

Don't use bl_ prefix, that is meant for native Blender class members.

Don't use `bl_` prefix, that is meant for native Blender class members.
brecht marked this conversation as resolved
hydra_storm/properties.py
@ -0,0 +36,4 @@
default=1.0,
)
volume_raymarching_step_size_lighting: bpy.props.FloatProperty(
name="Volume Raymarching Step Size",
Brecht Van Lommel commented 2023-05-10 19:02:55 +02:00
Owner
Copy Link

This is name should not be identical to the one for volume_raymarching_step_size

This is name should not be identical to the one for volume_raymarching_step_size
brecht marked this conversation as resolved
hydra_storm/properties.py
@ -0,0 +47,4 @@
)
max_lights: bpy.props.IntProperty(
name="Max Lights",
description="Maximum number of lights",
Brecht Van Lommel commented 2023-05-10 19:04:08 +02:00
Owner
Copy Link

What happens when the maximum is reach? Why is the default only 16? This needs a better explanation in the description.

What happens when the maximum is reach? Why is the default only 16? This needs a better explanation in the description.
Georgiy Markelov commented 2023-05-11 17:01:57 +02:00
Member
Copy Link

It comes from source code https://github.com/PixarAnimationStudios/USD/blob/release/pxr/imaging/hdSt/renderDelegate.cpp#L70

It comes from source code https://github.com/PixarAnimationStudios/USD/blob/release/pxr/imaging/hdSt/renderDelegate.cpp#L70
Brecht Van Lommel commented 2023-05-11 18:15:33 +02:00
Owner
Copy Link

Can you figure out what it does so it can be explained in the description for users?

Can you figure out what it does so it can be explained in the description for users?
brecht marked this conversation as resolved
hydra_storm/ui.py Outdated
@ -0,0 +20,4 @@
class STORM_HYDRA_RENDER_PT_render_settings(Panel):
"""Final render delegate and settings"""
Brecht Van Lommel commented 2023-05-10 19:05:12 +02:00
Owner
Copy Link

Does this really apply to final renders only, not the viewport?

Does this really apply to final renders only, not the viewport?
Georgiy Markelov commented 2023-05-12 11:57:11 +02:00
Member
Copy Link

I will add addition panel for viewport.

I will add addition panel for viewport.
brecht marked this conversation as resolved
hydra_storm/ui.py
@ -0,0 +143,4 @@
'WORLD_PT_mist',
'WORLD_PT_preview',
'WORLD_PT_world',
'NODE_DATA_PT_light',
Brecht Van Lommel commented 2023-05-10 18:52:49 +02:00
Owner
Copy Link

The list in intern/cycles/blender/addon/ui.py is much shorter, and many of these panels no longer exist. So this seems outdated?

The list in `intern/cycles/blender/addon/ui.py` is much shorter, and many of these panels no longer exist. So this seems outdated?
Georgiy Markelov commented 2023-05-23 12:04:12 +02:00
Member
Copy Link

We also hide some extra panels.

We also hide some extra panels.
brecht marked this conversation as resolved
Bogdan Nagirniak added 1 commit 2023-05-19 20:29:34 +02:00 
### Purpose
Required changes for BogdanNagirniak/blender#41

### Technical steps
Adjusted code: renamed function.

Pull Request BogdanNagirniak/blender-addons#12
Brecht Van Lommel added 1 commit 2023-07-13 10:27:57 +02:00 
Other render engines in Blender also uses caps and underscores.

Pull Request #19
Brecht Van Lommel added 1 commit 2023-07-13 16:47:34 +02:00 
See BogdanNagirniak/blender#65

Pull Request #18
Bogdan Nagirniak added 1 commit 2023-07-21 11:28:55 +02:00 
### Purpose
Make available Strom delegate to utilize for material preview.

### Technical steps
- Set attribute bl_use_preview to True.

Pull Request BogdanNagirniak/blender-addons#20
Bogdan Nagirniak added 1 commit 2023-07-27 13:37:00 +02:00 
Fixed wrong panel visibility.

Pull Request BogdanNagirniak/blender-addons#22
Brecht Van Lommel added 1 commit 2023-07-27 15:06:15 +02:00
Brecht Van Lommel added 3 commits 2023-08-03 15:41:16 +02:00
Brecht Van Lommel changed title from WIP: Storm Hydra render addon to Storm Hydra render addon 2023-08-03 15:42:29 +02:00
Brecht Van Lommel approved these changes 2023-08-03 15:42:38 +02:00
Brecht Van Lommel merged commit 5ec7ca8f12 into main 2023-08-04 17:02:11 +02:00
Brecht Van Lommel deleted branch storm-hydra-addon 2023-08-04 17:02:12 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Brian Savery (AMD)
Brecht Van Lommel
Labels
Clear labels   
Interest
Animation & Rigging

  
Interest
Blender Cloud

  
Interest
Collada

  
Interest
Core

  
Interest
Documentation

  
Interest
Eevee & Viewport

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
Import and Export

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Nodes & Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds, Tests & Devices

  
Interest
Python API

  
Interest
Rendering & Cycles

  
Interest
Sculpt, Paint & Texture

  
Interest
Translations

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Meta
Good First Issue

  
Meta
Papercut

  
Module
Add-ons (BF-Blender)

  
Module
Add-ons (Community)

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Animation & Rigging
Interest
Blender Cloud
Interest
Collada
Interest
Core
Interest
Documentation
Interest
Eevee & Viewport
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
Import and Export
Interest
Modeling
Interest
Modifiers
Interest
Nodes & Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds, Tests & Devices
Interest
Python API
Interest
Rendering & Cycles
Interest
Sculpt, Paint & Texture
Interest
Translations
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Meta
Good First Issue
Meta
Papercut
Module
Add-ons (BF-Blender)
Module
Add-ons (Community)
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-addons#104597
No description provided.
Delete Branch "BogdanNagirniak/blender-addons:storm-hydra-addon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?