Cycles HIP binaries disabled due to compiler bugs #104786

Closed
opened 2023-02-15 17:14:27 +01:00 by Brecht Van Lommel · 8 comments

Tasks

  • Enable on Windows (#107098)
  • Enable on Linux (#107662)
  • Enable Radeon VII (gfx906) - Not expected to get fixed, so will remain disabled

Background

There are known bugs in HIP compiler that are causing random build failures when making changes to the Cycles kernel. This is preventing developers from efficiently making improvements to Cycles.

Cycles AMD GPU rendering were disabled in Blender 3.6 alpha, so that ongoing work like Principled v2 is not blocked. Additionally light tree sampling is not available for HIP in Blender 3.5. We hope this can be resolved later on in the 3.6 release cycle.

Relevant FIXME's in LLVM amdgpu backend (in fact I suspect we hit the same ones back when we were using OpenCL).
https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp#L221
https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp#L296

Most recent issues:
#104085 (#104720 )
#104669
#104097
https://archive.blender.org/developer/D16714

### Tasks - [x] Enable on Windows (#107098) - [x] Enable on Linux (#107662) - Enable Radeon VII (gfx906) - Not expected to get fixed, so will remain disabled ### Background There are known bugs in HIP compiler that are causing random build failures when making changes to the Cycles kernel. This is preventing developers from efficiently making improvements to Cycles. Cycles AMD GPU rendering were disabled in Blender 3.6 alpha, so that ongoing work like Principled v2 is not blocked. Additionally light tree sampling is not available for HIP in Blender 3.5. We hope this can be resolved later on in the 3.6 release cycle. Relevant FIXME's in LLVM amdgpu backend (in fact I suspect we hit the same ones back when we were using OpenCL). https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp#L221 https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp#L296 Most recent issues: #104085 (#104720 ) #104669 #104097 https://archive.blender.org/developer/D16714
Brecht Van Lommel added the
Type
To Do
Module
Render & Cycles
labels 2023-02-15 17:14:27 +01:00
Brecht Van Lommel added this to the Render & Cycles project 2023-02-15 17:18:17 +01:00
Brecht Van Lommel changed title from Cycles HIP disabled due to compiler bugs to Cycles HIP binaries disabled due to compiler bugs 2023-02-15 17:33:37 +01:00
Brecht Van Lommel added this to the 3.6 LTS milestone 2023-02-15 17:33:45 +01:00

Just an update from the AMD side, the fix for the above issue is in progress on the compiler side. Can't comment on ETA at this point.

Just an update from the AMD side, the fix for the above issue is in progress on the compiler side. Can't comment on ETA at this point.

Good morning,
any news from AMD?

Thanks in advance,
Gioxyer

Good morning, any news from AMD? Thanks in advance, Gioxyer
Author
Owner

When there is news it will be posted here, for now there is no news yet.

When there is news it will be posted here, for now there is no news yet.

Ok thank you so much

Ok thank you so much

Can we have the HIP button disabled in the Settings for the time being? Possibly with an informative message? It's definitely contributing to a little confusion and wasted time for the bug team (see my own bug report #106225 )

Can we have the HIP button disabled in the Settings for the time being? Possibly with an informative message? It's definitely contributing to a little confusion and wasted time for the bug team (see my own bug report #106225 )

Disabling HIP devices in ui should be fine, @brecht do you agree? I don't think it needs an involved message. This is temporary and 3.6 is in alpha, so I don't think it needs an involved user message.

Disabling HIP devices in ui should be fine, @brecht do you agree? I don't think it needs an involved message. This is temporary and 3.6 is in alpha, so I don't think it needs an involved user message.
Author
Owner

Binaries were re-enabled on Windows now. Linux is still waiting for a new ROCm release, and gfx906 is also disabled due to an issue to be solved still.

Binaries were re-enabled on Windows now. Linux is still waiting for a new ROCm release, and gfx906 is also disabled due to an issue to be solved still.
Author
Owner

Radeon VII is not expected to be fixed, so closing this issue as resolved since all the other ones work.

Radeon VII is not expected to be fixed, so closing this issue as resolved since all the other ones work.
Brecht Van Lommel added the
Status
Resolved
label 2023-11-28 19:49:16 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104786
No description provided.