Left and Right Click consistency improvements #110960

Closed

Julien Kaspar wants to merge 2 commits from JulienKaspar/blender:keymap-selection-consistency into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Julien Kaspar commented

2023-08-09 15:32:56 +02:00

Member

Based on design of #105298

This PR fixes some remaining consistency issues for selection shortcuts for both left and right click select.

Grease Pencil

Instead of using Alt Select shortcuts for selecting whole strokes, these are now following existing standards with L and Shift L from select linked pick operations.

Alt Select keys are instead used for selecting individual components in modes that use brushes just like fb54d3f865.

Regular selection like Select and Shift Select are now always mapped to ensure that all keymap configurations are able to select individual components in every mode.
This does not cause conflicting behavior with brushes.

Lasso Select shortcuts on Ctrl Alt and Shift Ctrl Alt have been removed. These were duplicates and are not needed.

Mesh Sculpt Mode

Mesh sculpt mode uses correct lasso masking shortcuts in both right and left click select.
These are now the same as lasso selection shortcuts in other modes.

Based on design of #105298 This PR fixes some remaining consistency issues for selection shortcuts for both left and right click select. # Grease Pencil Instead of using `Alt Select` shortcuts for selecting whole strokes, these are now following existing standards with `L` and `Shift L` from select linked pick operations. `Alt Select` keys are instead used for selecting individual components in modes that use brushes just like fb54d3f865. Regular selection like `Select` and `Shift Select` are now always mapped to ensure that all keymap configurations are able to select individual components in every mode. This does not cause conflicting behavior with brushes. Lasso Select shortcuts on `Ctrl Alt` and `Shift Ctrl Alt` have been removed. These were duplicates and are not needed. # Mesh Sculpt Mode Mesh sculpt mode uses correct lasso masking shortcuts in both right and left click select. These are now the same as lasso selection shortcuts in other modes.

Julien Kaspar added this to the 4.0 milestone 2023-08-09 15:32:56 +02:00

Julien Kaspar added the

Sculpt, Paint & Texture

labels 2023-08-09 15:32:56 +02:00

Julien Kaspar added 1 commit 2023-08-09 15:33:05 +02:00

3c63c5bf40 Remaining changes for consistency:

- Gpencil select shortcuts are consistent with 3D viewport
- Gpencil uses correct linked selection shortcuts
- Mesh sculpt mode uses correct lasso masking shortcuts

Julien Kaspar referenced this pull request

2023-08-09 15:33:20 +02:00

Sculpt/Painting Modes: Revamp Keymap #105298

Julien Kaspar requested review from Campbell Barton 2023-08-09 15:35:26 +02:00

Julien Kaspar requested review from Falk David 2023-08-09 15:35:37 +02:00

Campbell Barton reviewed 2023-08-10 05:03:44 +02:00

scripts/presets/keyconfig/keymap_data/blender_default.py Outdated

						
				@ -5380,6 +5377,20 @@ def km_sculpt(params):

				        *_template_items_context_panel("VIEW3D_PT_sculpt_context_menu", params.context_menu_event),

				    ])

				    # Lasso Masking

Campbell Barton commented

2023-08-10 05:03:44 +02:00

Owner

It seems a bit weak that RMB can set the mask but not clear it, how about use alt for clearing mask? (e.g.)

    # Lasso Masking.
    if params.select_mouse == 'RIGHTMOUSE':
        items.extend([
            ("paint.mask_lasso_gesture",
             {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True, "ctrl": True, "alt": -1},
             {"properties": [("value", 1.0)]}),
            ("paint.mask_lasso_gesture",
             {"type": 'LEFTMOUSE', "value": 'PRESS', "ctrl": True, "alt": True},
             {"properties": [("value", 0.0)]}),
        ])
    else:
        items.extend([
            ("paint.mask_lasso_gesture", {"type": 'RIGHTMOUSE', "value": 'PRESS', "shift": True, "ctrl": True},
             {"properties": [("value", 1.0)]}),
            ("paint.mask_lasso_gesture", {"type": 'RIGHTMOUSE', "value": 'PRESS', "ctrl": True},
             {"properties": [("value", 0.0)]}),
        ])

It seems a bit weak that RMB can set the mask but not clear it, how about use alt for clearing mask? (e.g.) ``` # Lasso Masking. if params.select_mouse == 'RIGHTMOUSE': items.extend([ ("paint.mask_lasso_gesture", {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True, "ctrl": True, "alt": -1}, {"properties": [("value", 1.0)]}), ("paint.mask_lasso_gesture", {"type": 'LEFTMOUSE', "value": 'PRESS', "ctrl": True, "alt": True}, {"properties": [("value", 0.0)]}), ]) else: items.extend([ ("paint.mask_lasso_gesture", {"type": 'RIGHTMOUSE', "value": 'PRESS', "shift": True, "ctrl": True}, {"properties": [("value", 1.0)]}), ("paint.mask_lasso_gesture", {"type": 'RIGHTMOUSE', "value": 'PRESS', "ctrl": True}, {"properties": [("value", 0.0)]}), ]) ```

Julien Kaspar commented

2023-08-12 14:49:42 +02:00

Author

Member

Done.
But paint.mask_lasso_gesture is using an inverted paradigm so I flipped the numbers. Ctrl Shift LMB is masking (equivilant to deselecting in edit mode).
I also changed the value to CLICK_DRAG.

I added the function _template_items_select_lasso to add the same shortcuts to other painting modes and Gpencil modes. Curve Sculpt mode can add this too once lasso select is supported.

Done. But `paint.mask_lasso_gesture` is using an inverted paradigm so I flipped the numbers. `Ctrl Shift LMB` is masking (equivilant to deselecting in edit mode). I also changed the value to `CLICK_DRAG`. I added the function `_template_items_select_lasso` to add the same shortcuts to other painting modes and Gpencil modes. Curve Sculpt mode can add this too once lasso select is supported.

Julien Kaspar referenced this pull request

2023-08-10 11:32:07 +02:00

Grease Pencil vertex paint select is using sculpt mode selection mode #110966

Julien Kaspar commented

2023-08-10 12:39:32 +02:00

Author

Member

I'm fine with using Ctrl Alt Shift LMB, which is a pretty hefty shortcut but usable.

I would like to keep Alt LMB, Alt Shift LMB and Alt Ctrl LMB reserved for component selection and maybe even direct mask brush access in sculpt modes.

I'm fine with using `Ctrl Alt Shift LMB`, which is a pretty hefty shortcut but usable. I would like to keep `Alt LMB`, `Alt Shift LMB` and `Alt Ctrl LMB` reserved for component selection and maybe even direct mask brush access in sculpt modes.

Julien Kaspar added 1 commit 2023-08-12 14:45:52 +02:00

978525805d Added lasso select for right click select

Julien Kaspar commented

2023-08-21 10:13:48 +02:00

Author

Member

@ideasman42 @filedescriptor I would like to get this in before Bcon2.
Do you have time to give some final review?

@ideasman42 @filedescriptor I would like to get this in before Bcon2. Do you have time to give some final review?

Campbell Barton referenced this issue from a commit

2023-08-22 07:47:41 +02:00

Keymap: Left and Right Click consistency improvements

Campbell Barton approved these changes 2023-08-22 07:48:40 +02:00

Julien Kaspar commented

2023-09-20 12:11:41 +02:00

Author

Member

Already merged

Already merged

Julien Kaspar closed this pull request

2023-09-20 12:11:43 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110960

No description provided.