blender
/
blender
77
265
Fork 362
Code Issues 6.0k Pull Requests 539 Projects 19 Wiki Activity

Left and Right Click consistency improvements #110960

Closed
Julien Kaspar wants to merge 2 commits from JulienKaspar/blender:keymap-selection-consistency into main
pull from: JulienKaspar/blender:keymap-selection-consistency
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 3 Commits 2 Files Changed 1
Julien Kaspar commented 2023-08-09 15:32:56 +02:00
Collaborator

Based on design of #105298

This PR fixes some remaining consistency issues for selection shortcuts for both left and right click select.

Grease Pencil

Instead of using Alt Select shortcuts for selecting whole strokes, these are now following existing standards with L and Shift L from select linked pick operations.

Alt Select keys are instead used for selecting individual components in modes that use brushes just like fb54d3f865.

Regular selection like Select and Shift Select are now always mapped to ensure that all keymap configurations are able to select individual components in every mode.
This does not cause conflicting behavior with brushes.

Lasso Select shortcuts on Ctrl Alt and Shift Ctrl Alt have been removed. These were duplicates and are not needed.

Mesh Sculpt Mode

Mesh sculpt mode uses correct lasso masking shortcuts in both right and left click select.
These are now the same as lasso selection shortcuts in other modes.

Based on design of #105298 This PR fixes some remaining consistency issues for selection shortcuts for both left and right click select. # Grease Pencil Instead of using `Alt Select` shortcuts for selecting whole strokes, these are now following existing standards with `L` and `Shift L` from select linked pick operations. `Alt Select` keys are instead used for selecting individual components in modes that use brushes just like fb54d3f865. Regular selection like `Select` and `Shift Select` are now always mapped to ensure that all keymap configurations are able to select individual components in every mode. This does not cause conflicting behavior with brushes. Lasso Select shortcuts on `Ctrl Alt` and `Shift Ctrl Alt` have been removed. These were duplicates and are not needed. # Mesh Sculpt Mode Mesh sculpt mode uses correct lasso masking shortcuts in both right and left click select. These are now the same as lasso selection shortcuts in other modes.
Julien Kaspar added this to the 4.0 milestone 2023-08-09 15:32:56 +02:00
Julien Kaspar added the
Interest
Grease Pencil
Interest
Sculpt, Paint & Texture
 labels 2023-08-09 15:32:56 +02:00
Julien Kaspar added 1 commit 2023-08-09 15:33:05 +02:00
3c63c5bf40 Remaining changes for consistency: 
- Gpencil select shortcuts are consistent with 3D viewport
- Gpencil uses correct linked selection shortcuts
- Mesh sculpt mode uses correct lasso masking shortcuts
Julien Kaspar requested review from Campbell Barton 2023-08-09 15:35:26 +02:00
Julien Kaspar requested review from Falk David 2023-08-09 15:35:37 +02:00
Campbell Barton reviewed 2023-08-10 05:03:44 +02:00
scripts/presets/keyconfig/keymap_data/blender_default.py Outdated
@ -5380,6 +5377,20 @@ def km_sculpt(params):
*_template_items_context_panel("VIEW3D_PT_sculpt_context_menu", params.context_menu_event),
])
# Lasso Masking
Campbell Barton commented 2023-08-10 05:03:44 +02:00
Owner

It seems a bit weak that RMB can set the mask but not clear it, how about use alt for clearing mask? (e.g.)

    # Lasso Masking.
    if params.select_mouse == 'RIGHTMOUSE':
        items.extend([
            ("paint.mask_lasso_gesture",
             {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True, "ctrl": True, "alt": -1},
             {"properties": [("value", 1.0)]}),
            ("paint.mask_lasso_gesture",
             {"type": 'LEFTMOUSE', "value": 'PRESS', "ctrl": True, "alt": True},
             {"properties": [("value", 0.0)]}),
        ])
    else:
        items.extend([
            ("paint.mask_lasso_gesture", {"type": 'RIGHTMOUSE', "value": 'PRESS', "shift": True, "ctrl": True},
             {"properties": [("value", 1.0)]}),
            ("paint.mask_lasso_gesture", {"type": 'RIGHTMOUSE', "value": 'PRESS', "ctrl": True},
             {"properties": [("value", 0.0)]}),
        ])
It seems a bit weak that RMB can set the mask but not clear it, how about use alt for clearing mask? (e.g.) ``` # Lasso Masking. if params.select_mouse == 'RIGHTMOUSE': items.extend([ ("paint.mask_lasso_gesture", {"type": 'LEFTMOUSE', "value": 'PRESS', "shift": True, "ctrl": True, "alt": -1}, {"properties": [("value", 1.0)]}), ("paint.mask_lasso_gesture", {"type": 'LEFTMOUSE', "value": 'PRESS', "ctrl": True, "alt": True}, {"properties": [("value", 0.0)]}), ]) else: items.extend([ ("paint.mask_lasso_gesture", {"type": 'RIGHTMOUSE', "value": 'PRESS', "shift": True, "ctrl": True}, {"properties": [("value", 1.0)]}), ("paint.mask_lasso_gesture", {"type": 'RIGHTMOUSE', "value": 'PRESS', "ctrl": True}, {"properties": [("value", 0.0)]}), ]) ```
Julien Kaspar commented 2023-08-12 14:49:42 +02:00
Poster
Collaborator

Done.
But paint.mask_lasso_gesture is using an inverted paradigm so I flipped the numbers. Ctrl Shift LMB is masking (equivilant to deselecting in edit mode).
I also changed the value to CLICK_DRAG.

I added the function _template_items_select_lasso to add the same shortcuts to other painting modes and Gpencil modes. Curve Sculpt mode can add this too once lasso select is supported.

Done. But `paint.mask_lasso_gesture` is using an inverted paradigm so I flipped the numbers. `Ctrl Shift LMB` is masking (equivilant to deselecting in edit mode). I also changed the value to `CLICK_DRAG`. I added the function `_template_items_select_lasso` to add the same shortcuts to other painting modes and Gpencil modes. Curve Sculpt mode can add this too once lasso select is supported.
Julien Kaspar commented 2023-08-10 12:39:32 +02:00
Poster
Collaborator

I'm fine with using Ctrl Alt Shift LMB, which is a pretty hefty shortcut but usable.

I would like to keep Alt LMB, Alt Shift LMB and Alt Ctrl LMB reserved for component selection and maybe even direct mask brush access in sculpt modes.

I'm fine with using `Ctrl Alt Shift LMB`, which is a pretty hefty shortcut but usable. I would like to keep `Alt LMB`, `Alt Shift LMB` and `Alt Ctrl LMB` reserved for component selection and maybe even direct mask brush access in sculpt modes.
Julien Kaspar added 1 commit 2023-08-12 14:45:52 +02:00
Julien Kaspar commented 2023-08-21 10:13:48 +02:00
Poster
Collaborator

@ideasman42 @filedescriptor I would like to get this in before Bcon2.
Do you have time to give some final review?

@ideasman42 @filedescriptor I would like to get this in before Bcon2. Do you have time to give some final review?
Campbell Barton approved these changes 2023-08-22 07:48:40 +02:00
Julien Kaspar commented 2023-09-20 12:11:41 +02:00
Poster
Collaborator

Already merged

Already merged
Julien Kaspar closed this pull request 2023-09-20 12:11:43 +02:00

Reviewers

Falk David was requested for review 2023-08-09 15:35:36 +02:00
Campbell Barton approved these changes 2023-08-22 07:48:40 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Falk David
Campbell Barton
Labels
Apply labels
Clear labels   
Interest
Alembic
   
Interest
Animation & Rigging
   
Interest
Asset Browser
   
Interest
Asset Browser Project Overview
   
Interest
Audio
   
Interest
Automated Testing
   
Interest
Blender Asset Bundle
   
Interest
BlendFile
   
Interest
Collada
   
Interest
Compatibility
This issue affects/is about backward or forward compatibility   
Interest
Compositing
   
Interest
Core
   
Interest
Cycles
   
Interest
Dependency Graph
   
Interest
Development Management
   
Interest
EEVEE & Viewport
   
Interest
Freestyle
   
Interest
Geometry Nodes
   
Interest
Grease Pencil
   
Interest
ID Management
   
Interest
Images & Movies
   
Interest
Import Export
   
Interest
Line Art
   
Interest
Masking
   
Interest
Metal
   
Interest
Modeling
   
Interest
Modifiers
   
Interest
Motion Tracking
   
Interest
Nodes & Physics
   
Interest
OpenGL
   
Interest
Overrides
   
Interest
Performance
   
Interest
Physics
   
Interest
Pipeline, Assets & IO
   
Interest
Platforms, Builds & Tests
   
Interest
Python API
   
Interest
Render & Cycles
   
Interest
Render Pipeline
   
Interest
Sculpt, Paint & Texture
   
Interest
Text Editor
   
Interest
Translations
   
Interest
Triaging
   
Interest
Undo
   
Interest
USD
   
Interest
User Interface
   
Interest
UV Editing
   
Interest
VFX & Video
   
Interest
Video Sequencer
   
Interest
Virtual Reality
   
Interest
Vulkan
  
Interest: Wayland
  
Legacy
Blender 2.8 Project
   
Legacy
Milestone 1: Basic, Local Asset Browser
   
Legacy
OpenGL Error
  
Meta
Good First Issue
   
Meta
Papercut
   
Meta
Retrospective
   
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
  
Module
Animation & Rigging
   
Module
Core
   
Module
Development Management
   
Module
EEVEE & Viewport
   
Module
Grease Pencil
   
Module
Modeling
   
Module
Nodes & Physics
   
Module
Pipeline, Assets & IO
   
Module
Platforms, Builds & Tests
   
Module
Python API
   
Module
Render & Cycles
   
Module
Sculpt, Paint & Texture
   
Module
Triaging
   
Module
User Interface
   
Module
VFX & Video
  
Platform
FreeBSD
   
Platform
Linux
   
Platform
macOS
   
Platform
Windows
  
Priority
High
   
Priority
Low
   
Priority
Normal
   
Priority
Unbreak Now!
  
Status
Archived
   
Status
Confirmed
   
Status
Duplicate
   
Status
Needs Info from Developers
   
Status
Needs Information from User
   
Status
Needs Triage
   
Status
Resolved
  
Type
Bug
   
Type
Design
   
Type
Known Issue
   
Type
Patch
   
Type
Report
   
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
4.0
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110960
There is no content yet.
Delete Branch "JulienKaspar/blender:keymap-selection-consistency"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?