Fix #93052: USD import: wrong varying interpolation conversion #116955

Merged
Michael Kowalski merged 1 commits from makowalski/blender:usd-varying-uv-import-error into main 2024-01-10 18:33:19 +01:00

Change to map the USD "varying" interpolation type to Blender's
"Corner" domain type when importing mesh attributes. This fixes
value count mismatch errors when importing USD attributes with
varying interpolation.

Note that, for meshes, "varying" and "faceVarying" interpolation
are essentially the same in practice.

Change to map the USD "varying" interpolation type to Blender's "Corner" domain type when importing mesh attributes. This fixes value count mismatch errors when importing USD attributes with varying interpolation. Note that, for meshes, "varying" and "faceVarying" interpolation are essentially the same in practice.
Michael Kowalski added the
Interest
USD
Interest
Pipeline, Assets & IO
labels 2024-01-09 19:21:37 +01:00
Michael Kowalski added 1 commit 2024-01-09 19:21:46 +01:00
c9259a110d Fix #93052: USD import: wrong varying interpolation conversion
Change to map the USD "varying" interpolation type to Blender's
"Corner" domain type when importing mesh attributes.  This fixes
value count mismatch errors when importing USD attributes with
varying interpolation.
Michael Kowalski requested review from Charles Wardlaw 2024-01-09 19:22:09 +01:00

Looks good to me 👍

Looks good to me 👍
Charles Wardlaw approved these changes 2024-01-09 19:48:51 +01:00
Jesse Yurkovich approved these changes 2024-01-10 02:28:51 +01:00
Michael Kowalski merged commit e57c17ea6e into main 2024-01-10 18:33:19 +01:00
Michael Kowalski deleted branch usd-varying-uv-import-error 2024-01-10 18:33:21 +01:00
First-time contributor

I was able to get blender to build today after some struggle (not my forte) but if this is indeed merged into main, the error persists, much the same as it did in my initial issue.

I was able to get blender to build today after some struggle (not my forte) but if this is indeed merged into main, the error persists, much the same as it did in my initial issue.
First-time contributor
No description provided.
Author
Member

@benbrennanmusic Thanks for reporting this.

One complicating factor is that specifying "varying" interpolation for meshes is relatively rare and there are inconsistencies in how DCCs interpret this. (It's by far more common to specify "vertex" or "faceVarying" interpolation for meshes.)

I'm going to reopen this issue to investigate further. Would you mind providing a sample USD output from Unity where you are getting this error?

@benbrennanmusic Thanks for reporting this. One complicating factor is that specifying "varying" interpolation for meshes is relatively rare and there are inconsistencies in how DCCs interpret this. (It's by far more common to specify "vertex" or "faceVarying" interpolation for meshes.) I'm going to reopen this issue to investigate further. Would you mind providing a sample USD output from Unity where you are getting this error?
First-time contributor

Done. added to the issue

Done. added to [the issue](https://projects.blender.org/blender/blender/issues/93052)
Author
Member

Done. added to the issue

Thank you, @benbrennanmusic.

> Done. added to [the issue](https://projects.blender.org/blender/blender/issues/93052) Thank you, @benbrennanmusic.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#116955
No description provided.