GPencil: Redesign Blend modes and cleanup Drawing Engine #66293

New Issue

Antonio Vazquez · 2019-07-01T10:39:49+02:00

Antonio Vazquez commented

2019-07-01 10:39:49 +02:00

The actual blend modes have problems with alpha and other performance issues.

This task is for do a full review and improve and fix these issues.

We move it to 2.81 because for 2.80 is too risky to change draw engine, and it's better to have something running with some problems that breaks the draw engine.

I initially assign to @fclem, because he will coordinate the task.

Examples of the problem:

Notes:

Review if possible avoid overlap in one layer (see #66818).
Review AA in VFX and Blend modes.
Review Halo problems with multiple objects.(see #68204)

{F7648136}

The actual blend modes have problems with alpha and other performance issues. This task is for do a full review and improve and fix these issues. We move it to 2.81 because for 2.80 is too risky to change draw engine, and it's better to have something running with some problems that breaks the draw engine. I initially assign to @fclem, because he will coordinate the task. Examples of the problem: ![image.png](https://archive.blender.org/developer/F7558177/image.png) ![image.png](https://archive.blender.org/developer/F7558179/image.png) Notes: - Review if possible avoid overlap in one layer (see #66818). - Review AA in VFX and Blend modes. - Review Halo problems with multiple objects.(see #68204) ``` {F7648136}

Clément Foucault was assigned by Antonio Vazquez

2019-07-01 10:39:49 +02:00

Antonio Vazquez commented

2019-07-01 10:39:49 +02:00

Added subscribers: @fclem, @antoniov, @mendio, @pepe-school-land

blender-admin commented

2019-07-01 10:39:49 +02:00

#74474 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#74029 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#73962 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#71084 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#71330 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#61633 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#67770 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#60907 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#72481 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#71867 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#61236 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#72280 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#73097 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#69646 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#72022 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#72989 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#72915 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#72872 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#59441 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#59425 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#62041 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#68667 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#57859 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#72569 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#62723 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#60939 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#70323 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#60325 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#60538 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#62375 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#64156 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#69946 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#69567 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#69667 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#68204 was marked as duplicate of this issue

blender-admin commented

2019-07-01 10:39:49 +02:00

#68121 was marked as duplicate of this issue

Antonio Vazquez commented

2019-07-01 10:40:52 +02:00

Here a pseudocode analysis of the new system.

IdeasDraw.c

Note: The VFX are by object, so not sure we must run the VFX loop in the blender layer as defined in the chart above.

Here a pseudocode analysis of the new system. [IdeasDraw.c](https://archive.blender.org/developer/F7558161/IdeasDraw.c) ![image.png](https://archive.blender.org/developer/F7558162/image.png) Note: The VFX are by object, so not sure we must run the VFX loop in the blender layer as defined in the chart above.

Clément Foucault commented

2019-07-01 12:42:08 +02:00

Note that this redesign also fix the ghost stroke in 2D stroke order.

Antonio Vazquez commented

2019-07-01 15:45:26 +02:00

Added subscriber: @JuanCamardella

Antonio Vazquez commented

2019-07-01 15:47:23 +02:00

Added subscriber: @Pullup

Brecht Van Lommel commented

2019-08-02 13:08:18 +02:00

Added subscribers: @sse, @brecht

JUAN FRANCISCO PAEZ commented

2019-08-02 13:58:09 +02:00

Added subscriber: @JuanFranciscoPaez

Antonio Vazquez commented

2019-08-04 10:26:55 +02:00

Added subscriber: @VLC

Brecht Van Lommel commented

2019-09-06 13:12:10 +02:00

Changing After Release to 2.81, since we are now using milestones instead.

I don't know if this is one is actually planned for 2.81, feel free to adjust tags as needed.

Changing After Release to 2.81, since we are now using milestones instead. I don't know if this is one is actually planned for 2.81, feel free to adjust tags as needed.

Philipp Oeser commented

2019-09-09 13:51:29 +02:00

Added subscribers: @icappiello, @lichtwerk

Germano Cavalcante commented

2019-09-20 17:09:08 +02:00

Added subscribers: @Baz-1, @mano-wii

Brecht Van Lommel commented

2019-09-29 14:23:26 +02:00

@antoniov, since you told me all the major grease pencil changes for 2.81 are done, moving this to the next release.

We can also remove the release tag if it's not planned for any specific release, up to you.

@antoniov, since you told me all the major grease pencil changes for 2.81 are done, moving this to the next release. We can also remove the release tag if it's not planned for any specific release, up to you.

Antonio Vazquez commented

2019-09-29 15:52:12 +02:00

Yes, move to the next releases.. I would like to do it in 2.82, but it's not depend only on me.

heini commented

2019-10-09 00:58:11 +02:00

Added subscriber: @heini

Paul Szajner commented

2019-12-05 16:10:56 +01:00

Added subscriber: @sozap

tonton commented

2019-12-20 15:47:57 +01:00

Added subscriber: @tonton

Antonio Vazquez commented

2019-12-28 09:52:03 +01:00

Added subscribers: @Ranakade, @Lattapotta, @SteveLund, @skarlok, @josh09878, @ZedDB, @StephenSwaney, @troy_s, @intracube, @JacquesLucke, @EnzioProbst

Antonio Vazquez commented

2019-12-28 09:54:46 +01:00

Added subscriber: @bent

Antonio Vazquez commented

2019-12-28 09:55:29 +01:00

Added subscriber: @FredLierman

Antonio Vazquez commented

2019-12-28 09:59:15 +01:00

Added subscribers: @AdamJanz, @daniel.vanwesten, @llamaJeff, @Antonio-29

Antonio Vazquez commented

2019-12-28 10:04:00 +01:00

Added subscriber: @icedryst

Antonio Vazquez commented

2019-12-28 10:04:58 +01:00

Added subscriber: @sz0

Antonio Vazquez commented

2019-12-28 10:05:53 +01:00

Added subscribers: @nire, @georgK, @rdnmnm, @robertoconde, @RyanJEC, @JakeBullock, @ChuckOcheret, @Awk, @fakeDeltatime, @particl3s

Antonio Vazquez commented

2019-12-28 10:09:55 +01:00

Added subscriber: @Quargzon

Tomasz Kaye commented

2019-12-28 10:52:50 +01:00

Added subscriber: @info-27

Antonio Vazquez commented

2020-01-03 16:56:40 +01:00

Added subscriber: @bunny

Antonio Vazquez commented

2020-01-07 13:44:12 +01:00

Added subscriber: @JayOhJay

Philipp Oeser commented

2020-01-09 11:22:08 +01:00

Added subscribers: @AdamEarle, @LucianoMunoz

Adam Earle commented

2020-01-10 03:16:51 +01:00

Here is some information on how I am creating brush textures. Could it be something to do with PNG coming from Krita? Perhaps this the reason why there is trouble with alpha?

https://www.youtube.com/watch?v=PyYI0lOHkqs&list=PL-zg5csjHY0goZ5b3puiJsPFXb15w8APo&index=16&t=20s

Here is some information on how I am creating brush textures. Could it be something to do with PNG coming from Krita? Perhaps this the reason why there is trouble with alpha? https://www.youtube.com/watch?v=PyYI0lOHkqs&list=PL-zg5csjHY0goZ5b3puiJsPFXb15w8APo&index=16&t=20s

Adam Earle commented

2020-01-10 05:36:40 +01:00

Just testing out the 2.82 branches on: https://blender.community/c/graphicall/Whbbbc/

Here is a rambling mess of thoughts on how close it is to working: https://www.youtube.com/watch?v=VjG0dnoihr4&list=PL-zg5csjHY0goZ5b3puiJsPFXb15w8APo&index=2&t=0s

I have honestly no idea how else to contribute accept to keep testing and just demonstrating and talking through how as an artist I may use these tools.

Ad

Just testing out the 2.82 branches on: https://blender.community/c/graphicall/Whbbbc/ Here is a rambling mess of thoughts on how close it is to working: https://www.youtube.com/watch?v=VjG0dnoihr4&list=PL-zg5csjHY0goZ5b3puiJsPFXb15w8APo&index=2&t=0s I have honestly no idea how else to contribute accept to keep testing and just demonstrating and talking through how as an artist I may use these tools. Ad

Antonio Vazquez commented

2020-01-10 17:24:02 +01:00

Added subscriber: @wevon-2

Antonio Vazquez commented

2020-01-10 19:27:51 +01:00

Added subscriber: @iss

Clément Foucault commented

2020-01-13 16:42:34 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2020-01-13 16:42:34 +01:00

Clément Foucault commented

2020-01-13 16:42:34 +01:00

@AdamEarle I'm sorry to announce that the 3D mode is now not working as you mentioned. This is sad but it was creating more problem than it was solving.

We plan to have a more close integration of the 3D mode inside other engines (workbench/eevee) in the future to allow correct 3D transparency and effects.

Also a 15min video is not a good format for us to get feedback. Just having a bullet list of things that works and other that don't is more helpful. Also, please use https://devtalk.blender.org/ to create discussion around this, leaving the tracker for bug tracking.

Regarding this task, pretty much everything listed here has been fixed inside the gpencil refactor branch. So let's close it.

@AdamEarle I'm sorry to announce that the 3D mode is now not working as you mentioned. This is sad but it was creating more problem than it was solving. We plan to have a more close integration of the 3D mode inside other engines (workbench/eevee) in the future to allow correct 3D transparency and effects. Also a 15min video is not a good format for us to get feedback. Just having a bullet list of things that works and other that don't is more helpful. Also, please use https://devtalk.blender.org/ to create discussion around this, leaving the tracker for bug tracking. Regarding this task, pretty much everything listed here has been fixed inside the gpencil refactor branch. So let's close it.

Adam Earle commented

2020-01-14 03:12:21 +01:00

Hey, mate sorry about the 15 minutes video I didn't realize it was that long. I will be more considerate in the future of how and where I post.
Apologies I didn't realize this was the bug tracker. I thought this was place for discussion.

Now all of that said 2.82 and 2.83 from test work really well. The only things that seems to be not working are "textured strokes" from what I have tested.
From what I test its all still very very useable.

Apologies again for being overzealous. It really is very exciting.

Hey, mate sorry about the 15 minutes video I didn't realize it was that long. I will be more considerate in the future of how and where I post. Apologies I didn't realize this was the bug tracker. I thought this was place for discussion. Now all of that said 2.82 and 2.83 from test work really well. The only things that seems to be not working are "textured strokes" from what I have tested. From what I test its all still very very useable. Apologies again for being overzealous. It really is very exciting.

Antonio Vazquez commented

2020-01-14 09:08:01 +01:00

Added subscribers: @Dantti, @ronsn

Sybren A. Stüvel commented

2020-01-14 16:54:58 +01:00

Added subscribers: @santbg, @dr.sybren, @LucasVeber

Adam Earle commented

2020-01-15 03:29:28 +01:00

Reading through bugs reports lead me to testing blender out this way.

Textured alpha strokes are respected here.

This could be a quick solution for maybe next release before University start-up and we can start teaching it to the students.

The code in the masking could be used potentially on normal strokes.
When they are moved in 3D space the code switches on or off depending on where the stroke is in 3D space.

I didn't want to post in here, but I really thought this may help out since I can't see what actually is happening in the development.

In the attached Blend file if you scrub the timeline you the stroke color will change. Colour holds up well enough.

Mask.blend. system-info.txt

Reading through bugs reports lead me to testing blender out this way. Textured alpha strokes are respected here. This could be a quick solution for maybe next release before University start-up and we can start teaching it to the students. The code in the masking could be used potentially on normal strokes. When they are moved in 3D space the code switches on or off depending on where the stroke is in 3D space. I didn't want to post in here, but I really thought this may help out since I can't see what actually is happening in the development. In the attached Blend file if you scrub the timeline you the stroke color will change. Colour holds up well enough. [Mask.blend](https://archive.blender.org/developer/F8278931/Mask.blend). [system-info.txt](https://archive.blender.org/developer/F8278932/system-info.txt)

Clément Foucault commented

2020-01-17 13:52:10 +01:00

Added subscribers: @jmarkt1, @WilliamReynish