Fix #95477: Cycles Metal support for large textures #104579

Michael Jones (Apple) · 2023-02-10T17:01:06+01:00

2023-02-10 17:01:06 +01:00

MTLTexture dimensions must be <= 16384.

T95477 reported a crash resulting from large texture usage. This was upgraded to a non-fatal error in D14074, and now this new patch fixes the underlying issue by enabling support for texture dimensions > 16384. This is achieved using software texel fetch & filtering. The additional code required for this causes a small but measurable drop in performance, so we only compile the extra code if it is needed.

MTLTexture dimensions must be <= 16384. T95477 reported a crash resulting from large texture usage. This was upgraded to a non-fatal error in D14074, and now this new patch fixes the underlying issue by enabling support for texture dimensions > 16384. This is achieved using software texel fetch & filtering. The additional code required for this causes a small but measurable drop in performance, so we only compile the extra code if it is needed.

Michael Jones (Apple) added 2 commits 2023-02-10 17:01:08 +01:00

3089b27300 Cycles: Support for texture dimensions > 16K on Metal

This patch enables large textures on Metal by falling back to software emulated texture filtering on textures which are too large to be a MTLTexture.

buildbot/vexp-code-patch-coordinator Build done. Details

b75f467c8f Avoid compiling s/w texture filtering if not needed

Michael Jones (Apple) requested review from Brecht Van Lommel 2023-02-10 17:01:18 +01:00

Brecht Van Lommel commented

2023-02-10 17:25:45 +01:00

@blender-bot build

Blender Bot added this to the Render & Cycles project 2023-02-10 17:35:32 +01:00

Michael Jones (Apple) added 3 commits 2023-02-10 17:57:33 +01:00

b192515457 Clarify why s/w tricubic filtering is disabled & revive WITH_NANOVDB block

95575e9d17 Use software texel fetch & filtering on Intel to workaround sampler indexing driver issue

buildbot/vexp-code-patch-coordinator Build done. Details

51b4947b21 make format

Brecht Van Lommel commented

2023-02-10 18:01:34 +01:00

Seems the Metal tests are failing, as far as I can tell the latest changes would not fix it but will kick the bot again anyway (which you can do also by the way).
@blender-bot build

Seems the Metal tests are failing, as far as I can tell the latest changes would not fix it but will kick the bot again anyway (which you can do also by the way). @blender-bot build

Brecht Van Lommel requested changes 2023-02-15 12:58:25 +01:00

Brecht Van Lommel left a comment

Mark as requesting changes.

Brecht Van Lommel changed title from ~~Cycles: Fix T95477 - support large textures on Metal instead of giving error~~ to Fix #95477: Cycles Metal support for large textures

2023-03-10 13:46:47 +01:00

buildbot/vexp-code-patch-coordinator Build done.

Details

This pull request has changes conflicting with the target branch.

intern/cycles/device/metal/device_impl.mm
intern/cycles/device/metal/queue.mm
intern/cycles/kernel/device/metal/compat.h
intern/cycles/kernel/device/metal/context_begin.h

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u LargeTextureSupport:Michael-Jones-LargeTextureSupport

git checkout Michael-Jones-LargeTextureSupport

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #95477: Cycles Metal support for large textures #104579

Checkout