UI: File Loading Dialog #104666

Harley Acheson · 2023-02-12T21:04:13+01:00

Harley Acheson commented

2023-02-12 21:04:13 +01:00

Close open menus, show "waiting" mouse cursor, and show a loading
dialog when loading a new blend file, to better indicate that something
is happening.

When you select File / Open to load a blend file, it can seem like the program has hung. Quite often the menu will remain open and onscreen the entire time, like this:

This patch closes that menu and shows a small dialog in the middle of the window, with the thumbnail of the blend file, to indicate that something is happening.

Close open menus, show "waiting" mouse cursor, and show a loading dialog when loading a new blend file, to better indicate that something is happening. --- When you select File / Open to load a blend file, it can seem like the program has **hung**. Quite often the menu will remain open and onscreen the entire time, like this: ![Loading1.png](/attachments/a0285380-0e78-4a88-8f34-426cf49f175a) This patch closes that menu and shows a small dialog in the middle of the window, with the thumbnail of the blend file, to indicate that something is happening. ![image](/attachments/3a811f4c-f34d-441e-9fce-7ad652c54562)

image.png

412 KiB

LoadFile2.png

618 KiB

Loading1.png

380 KiB

👍 12 ❤️ 3 🎉 2

Brecht Van Lommel added this to the User Interface project 2023-02-13 09:08:50 +01:00

Harley Acheson force-pushed LoadingDialog from ae6e5418e3 to df7ec04932

2023-04-25 22:17:05 +02:00

Compare

Harley Acheson force-pushed LoadingDialog from df7ec04932 to e2221acb16

2023-05-17 21:38:14 +02:00

Compare

Adi.Sage commented

2023-06-16 06:20:40 +02:00

@Harley
Looks neat !
Will the new design include a loading bar/percentage, and possibly a description of what is being loaded as well?
(...having a description might be helpful to find out at what stage a certain file crashes...)

@Harley Looks neat ! Will the new design include a loading bar/percentage, and possibly a description of what is being loaded as well? (...having a description might be helpful to find out at what stage a certain file crashes...)

Harley Acheson commented

2023-06-17 20:38:34 +02:00

@Adi.Sage - Will the new design include a loading bar/percentage, and possibly a description of what is being loaded as well?

Sadly, no.

Hard to describe well, but our current design does not allow a dialog to be active and working during that time. Basically we destroy everything to do with the old file and then create everything again based on the new one. This PR only "works" because this dialog is drawn just before everything is destroyed and just keeps being shown for a while because the interface is not drawn again until the new file is loaded.

> @Adi.Sage - Will the new design include a loading bar/percentage, and possibly a description of what is being loaded as well? Sadly, no. Hard to describe well, but our current design does not allow a dialog to be active and working during that time. Basically we destroy everything to do with the old file and then create everything again based on the new one. This PR only "works" because this dialog is drawn just before everything is destroyed and just keeps being shown for a while because the interface is not drawn again until the new file is loaded.

Adi.Sage commented

2023-06-18 16:30:44 +02:00

@Harley
Got it. Thanks for clarifying.
Pretty impressive you could get this working given the constraints 😅 hope this gets through by 4.0!

@Harley Got it. Thanks for clarifying. Pretty impressive you could get this working given the constraints 😅 hope this gets through by 4.0!

Harley Acheson added 2 commits 2023-07-14 20:21:15 +02:00

Merge branch 'main' of projects.blender.org:blender/blender into LoadingDialog 0d5e3e7f77

Updating to the current state of main 003a8057d2

Harley Acheson added 2 commits 2023-08-24 01:29:49 +02:00

Merge branch 'main' of projects.blender.org:blender/blender into LoadingDialog 77cc65eb77

Updating to main. a few small corrections. 80b548a2cc

Harley Acheson requested review from Pablo Vazquez 2023-08-24 01:30:12 +02:00

Harley Acheson commented

2023-08-24 01:31:39 +02:00

Approved in principle by the UI Module. @pablovazquez will check for visual tweaks. This was code-reviewed by Campbell while it was on Phab.

Pablo Vazquez commented

2023-08-29 16:47:25 +02:00

First, love this! At the moment it really feels like Blender hungs when opening big files.

Approved in principle by the UI Module. @pablovazquez will check for visual tweaks.

Regarding design tweaks my first impression is that having the thumbnail on top, makes it look similar to the splash screen.

I think an horizontal layout may work better:

It'd still work without thumbnail:

These screenshots have a darkened background underneath the popup, to communicate the lack of access we have over it.

I also added the file size, as it might help understand the reason behind a lengthy load time.

A progress bar or detailed text on what's going on (loading objects, compiling shaders, depsgraph, etc) would be ideal, but I don't think it's easy at the moment so I skipped it.

First, love this! At the moment it really feels like Blender hungs when opening big files. > Approved in principle by the UI Module. @pablovazquez will check for visual tweaks. Regarding design tweaks my first impression is that having the thumbnail on top, makes it look similar to the splash screen. I think an horizontal layout may work better: ![image](/attachments/8fa2a5ff-9b4e-46f1-b8b7-0829ee6717d1) It'd still work without thumbnail: ![image](/attachments/93d80758-7410-4c54-bcca-aaed7befd784) These screenshots have a darkened background underneath the popup, to communicate the lack of access we have over it. I also added the file size, as it might help understand the reason behind a lengthy load time. A progress bar or detailed text on what's going on (loading objects, compiling shaders, depsgraph, etc) would be ideal, but I don't think it's easy at the moment so I skipped it.

image.png

331 KiB

image.png

321 KiB

Harley Acheson changed title from ~~UI: File Loading Dialog~~ to WIP: UI: File Loading Dialog

2023-08-30 04:07:46 +02:00

Harley Acheson changed title from ~~WIP: UI: File Loading Dialog~~ to WIP: UI: File Loading Dialog

2023-08-30 04:07:58 +02:00

Harley Acheson added 2 commits 2023-08-30 04:10:50 +02:00

Merge branch 'main' of projects.blender.org:blender/blender into LoadingDialog 1baadd48ee

In progress. Now the arrangement and size of Pablo's sample. roughly da8855bdeb

Pablo Vazquez commented

2023-08-30 16:08:39 +02:00

Ooh it's getting there!

I know it's WIP just sharing a quick video of it's current status for others to see:

Ooh it's getting there! I know it's WIP just sharing a quick video of it's current status for others to see: <video src="/attachments/627fd21b-c666-4cae-9732-e1092b5aff10" title="opening_file_indicator.mp4" controls loop></video>

opening_file_indicator.mp4

1.8 MiB

👀 2

Harley Acheson added 2 commits 2023-09-06 03:08:50 +02:00

Merge branch 'main' of projects.blender.org:blender/blender into LoadingDialog d0e9cf717f

Show darkened background. Show actual file size. 1b21ef3a05

Harley Acheson added 2 commits 2023-09-07 01:58:02 +02:00

Merge branch 'main' of projects.blender.org:blender/blender into LoadingDialog 04b021beb7

Properly constraining the preview size. Sizing dialog based on preview width. 502c601946

Harley Acheson changed title from ~~WIP: UI: File Loading Dialog~~ to UI: File Loading Dialog

2023-09-07 02:01:11 +02:00

Harley Acheson commented

2023-09-07 02:03:53 +02:00

@pablovazquez

This might be closer to what you want. The preview's width is the same as your mockup, but most previews are square so most will be taller than the mockup.

It shows the text as you requested, including the formatted file size.

It does darken the screen, but only the portion between the TopBar and the StatusBar, just because of how these things are treated and where the custom drawing callbacks are called. If this isn't good enough I can keep looking into that.

@pablovazquez This might be closer to what you want. The preview's width is the same as your mockup, but most previews are square so most will be taller than the mockup. It shows the text as you requested, including the formatted file size. It does darken the screen, but only the portion between the TopBar and the StatusBar, just because of how these things are treated and where the custom drawing callbacks are called. If this isn't good enough I can keep looking into that.

Harley Acheson referenced this pull request

2023-09-20 19:37:53 +02:00

UI: File Loading Waiting Feedback #112636

Harley Acheson added 1 commit 2023-09-20 20:52:08 +02:00

Merge branch 'main' of projects.blender.org:blender/blender into LoadingDialog dc2e2b8a3f

Harley Acheson commented

2024-01-26 18:18:16 +01:00

Closing as this isn't a viable path. It worked in most cases just by exploiting limitations of our UI drawing while loading. Problems with this approach can be found here: #112636

Closing as this isn't a viable path. It worked in most cases just by exploiting limitations of our UI drawing while loading. Problems with this approach can be found here: https://projects.blender.org/blender/blender/pulls/112636

Harley Acheson closed this pull request

2024-01-26 18:18:18 +01:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: File Loading Dialog #104666

Pull request closed