UI: File Loading Waiting Feedback #112636

Harley Acheson · 2023-09-20T19:37:53+02:00

Harley Acheson commented

2023-09-20 19:37:53 +02:00

When loading a blend file remove any open menus and show a "waiting"
mouse cursor during the process.

This is just the parts of #104666 not involving a loading dialog. These parts were previously reviewed by Campbell here: https://archive.blender.org/developer/D10484.

Making this a separate PR allows use to delay the loading dialog if needed but still have the other niceties.

When loading a blend file remove any open menus and show a "waiting" mouse cursor during the process. --- This is just the parts of #104666 **not** involving a loading dialog. These parts were previously reviewed by Campbell here: https://archive.blender.org/developer/D10484. Making this a separate PR allows use to delay the loading dialog if needed but still have the other niceties.

Harley Acheson added 1 commit 2023-09-20 19:38:03 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

64105ccfc6 UI: File Loading Waiting Feedback

When loading a blend file remove any open menus and show a "waiting"
mouse cursor during the process.

Harley Acheson added this to the User Interface project 2023-09-20 19:39:32 +02:00

Harley Acheson commented

2023-09-20 19:39:38 +02:00

@blender-bot build

Harley Acheson merged commit 9173c142d6 into main

2023-09-20 20:15:46 +02:00

Harley Acheson referenced this issue from a commit

2023-09-20 20:15:47 +02:00

UI: File Loading Waiting Feedback

Harley Acheson deleted branch LoadingWait

2023-09-20 20:15:48 +02:00

Campbell Barton commented

2023-09-21 05:00:10 +02:00

Redrawing on save caused problems in the past, did you check: #92704, #97627?

Some possible issues:

WM_redraw_windows runs after BKE_CB_EVT_LOAD_PRE, any manipulation will be shown in the redraw or may cause data that hasn't been evaluated by the depsgraph to be drawn.
WM_redraw_windows runs before BKE_CB_EVT_LOAD_POST_FAIL runs, meaning some manipulation might not be taken into account.
WM_redraw_windows runs before tool-system initialization WM_toolsystem_init.

Redrawing is typically run from the event loop, calling from outside the event loop has caused problems in the past.

Other issues related to redrawing:

Python scripts may be loading blend files as a batch operation without the expectation of redrawing.
The depsgraph may not have updated data, so the data needed for drawing may not be available.

Also, why is redraw drawing done at the end of file loading? This is going to redraw anyway and shouldn't be needed.

Redrawing on save caused problems in the past, did you check: #92704, #97627? Some possible issues: - WM_redraw_windows runs after BKE_CB_EVT_LOAD_PRE, any manipulation will be shown in the redraw or may cause data that hasn't been evaluated by the depsgraph to be drawn. - WM_redraw_windows runs before BKE_CB_EVT_LOAD_POST_FAIL runs, meaning some manipulation might not be taken into account. - WM_redraw_windows runs before tool-system initialization `WM_toolsystem_init`. Redrawing is typically run from the event loop, calling from outside the event loop has caused problems in the past. Other issues related to redrawing: - Python scripts may be loading blend files as a batch operation without the expectation of redrawing. - The depsgraph may not have updated data, so the data needed for drawing may not be available. Also, why is redraw drawing done at the end of file loading? This is going to redraw anyway and shouldn't be needed.

Harley Acheson commented

2023-09-21 07:05:57 +02:00

Hmmm... was fairly certain we had dealt with this earlier with code provided by you:
https://archive.blender.org/developer/differential/0010/0010484/#295567

Will take a look tomorrow, and can always revert.

Hmmm... was fairly certain we had dealt with this earlier with code provided by you: https://archive.blender.org/developer/differential/0010/0010484/#295567 Will take a look tomorrow, and can always revert.

Brecht Van Lommel commented

2023-09-21 13:30:14 +02:00

I don't think this implementation is safe enough. Even if we don't find immediate issues, redrawing at these points in the code seems too risky to me. I would expect this to redraw before file loading, in the operator invoke function before it has really done anything.

It could only re-blit existing framebuffers and not go into drawing code, so that no scene data is accessed. That's also how I think a progress bar should work during file loading or other slow operators. That would require an argument to wm_draw_update to skip actual region, cursor, overlay drawing .

Even that would require looking into the code to verify that it's not possible for the window/screen to be in some invalid state due to previously run operators and notifiers that have not been handled yet. And the case of Python code doing batch operations without redraws would also need to be detected.

I don't think this implementation is safe enough. Even if we don't find immediate issues, redrawing at these points in the code seems too risky to me. I would expect this to redraw before file loading, in the operator invoke function before it has really done anything. It could only re-blit existing framebuffers and not go into drawing code, so that no scene data is accessed. That's also how I think a progress bar should work during file loading or other slow operators. That would require an argument to `wm_draw_update` to skip actual region, cursor, overlay drawing . Even that would require looking into the code to verify that it's not possible for the window/screen to be in some invalid state due to previously run operators and notifiers that have not been handled yet. And the case of Python code doing batch operations without redraws would also need to be detected.

Harley Acheson commented

2023-09-21 17:05:56 +02:00

Will revert and give this more thought.