Assets: show all assets by default instead of current file #104749

Jacques Lucke · 2023-02-14T16:34:29+01:00

Jacques Lucke commented

2023-02-14 16:34:29 +01:00

The "current file" mode is only useful when creating new assets.
However, the far more common use case and the one that should require
fewer steps is to use existing assets.

The "current file" mode is only useful when creating new assets. However, the far more common use case and the one that should require fewer steps is to use existing assets.

Jacques Lucke added 1 commit 2023-02-14 16:34:30 +01:00

0b31512cce show all assets by default

Jacques Lucke requested review from Julian Eisel 2023-02-14 16:34:51 +01:00

Julian Eisel commented

2023-02-14 17:39:25 +01:00

I've been thinking about this, my main concern so far has been loading time when there are many assets. There is a point (a few thousand assets) where Blender essentially becomes unusable, continuously freezing because of the file browser preview caching falling apart. That's one of the main motivations behind #95653. Adding hundreds of assets to memory also isn't entirely cheap, but when changing libraries that memory will be freed anyway.

All things considered, I think it's worth doing anyway. Even in the (more or less corner-) case where the preview loading causes freezes I think it takes some seconds for the freezing to appear, so that you can change the library.

I've been thinking about this, my main concern so far has been loading time when there are many assets. There is a point (a few thousand assets) where Blender essentially becomes unusable, continuously freezing because of the file browser preview caching falling apart. That's one of the main motivations behind #95653. Adding hundreds of assets to memory also isn't entirely cheap, but when changing libraries that memory will be freed anyway. All things considered, I think it's worth doing anyway. Even in the (more or less corner-) case where the preview loading causes freezes I think it takes some seconds for the freezing to appear, so that you can change the library.

Julian Eisel approved these changes 2023-02-14 17:41:57 +01:00

Julian Eisel left a comment

Accepting this, but it's a bit of an experiment. We have to keep an eye open the coming weeks for reports on the performance issue noted above. Worst case we can add a preference option for the default, as a workaround - or we revert the change.

Jacques Lucke commented

2023-02-14 17:42:27 +01:00

That sounds reasonable.

Jacques Lucke merged commit 7ba59c8a62 into main

2023-02-14 17:44:55 +01:00

Jacques Lucke deleted branch show-all-assets-by-default

2023-02-14 17:44:55 +01:00

Jacques Lucke referenced this issue from a commit

2023-02-14 17:44:56 +01:00

Assets: show all assets by default instead of current file

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Assets: show all assets by default instead of current file #104749