LineArt: UI hint for using intersection filtering #104767

Open

YimingWu wants to merge 3 commits from ChengduLittleA/blender:lineart_ui_optimization into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

YimingWu commented

2023-02-15 06:24:02 +01:00

Member

This makes it easier for the user to understand that intersection is not filtered by source selection, and should be filtered with mask options down below.

(Is the attachment showing now?)

This makes it easier for the user to understand that intersection is not filtered by source selection, and should be filtered with mask options down below. (Is the attachment showing now?)

lineart_new_tooltip.png

80 KiB

YimingWu added the

labels 2023-02-15 06:24:02 +01:00

YimingWu added 1 commit 2023-02-15 06:24:17 +01:00

b9f009acc8 LineArt: UI hint for using intersection filtering.

YimingWu referenced this pull request

2023-02-15 06:26:28 +01:00

LineArt wrong intersection detection on scene collections containing intersecting object #104562

Ivan Cappiello commented

2023-02-15 09:29:21 +01:00

Member

@ChengduLittleA
i believe this warning, even if makes the user aware of the issue, is not ideal from an ui/ux pov imo. warnings are perceived by the users as alerts from a misusage and makes the software look unstable.

what i'd suggest as other option to consider:

relabel "intersection" to "global intersection" or "scene intersection detection". this would be more self explainatory and intentional than a warning.
move the description in the tooltip that appears on mouse over. rephrasing the warning in something that looks more like a statement raherer than an alert would help.

@filedescriptor should probably involved in this decision.

@ChengduLittleA i believe this warning, even if makes the user aware of the issue, is not ideal from an ui/ux pov imo. warnings are perceived by the users as alerts from a misusage and makes the software look unstable. what i'd suggest as other option to consider: 1. relabel "intersection" to "global intersection" or "scene intersection detection". this would be more self explainatory and intentional than a warning. 2. move the description in the tooltip that appears on mouse over. rephrasing the warning in something that looks more like a statement raherer than an alert would help. @filedescriptor should probably involved in this decision.

YimingWu commented

2023-02-15 09:39:02 +01:00

Author

Member

"Global Intersection" with a tooltip explanation seems to be a better choice indeed.

"Global Intersection" with a tooltip explanation seems to be a better choice indeed.

Ivan Cappiello commented

2023-02-15 09:44:36 +01:00

Member

"Global Intersection" with a tooltip explanation seems to be a better choice indeed.

in this case i'd suggest also to rephrase the description to something like:

"allows intersections detected between all visible objects in the scene to be drawn in this lineart"

> "Global Intersection" with a tooltip explanation seems to be a better choice indeed. in this case i'd suggest also to rephrase the description to something like: "allows intersections detected between all visible objects in the scene to be drawn in this lineart"

YimingWu commented

2023-02-15 09:47:37 +01:00

Author

Member

How about we include the filtering hint:

"Enables the intersections detected between all objects contained in the scene to be drawn in this lineart, use collection intersection mask combinations to filter."

How about we include the filtering hint: "Enables the intersections detected between all objects contained in the scene to be drawn in this lineart, use collection intersection mask combinations to filter."

Ivan Cappiello commented

2023-02-15 09:49:20 +01:00

Member

How about we include the filtering hint:

"Enables the intersections detected between all objects contained in the scene to be drawn in this lineart, use collection intersection mask combinations to filter."

that's good to me. but probably better to shorten it a bit for the tooltip and overhaul this explaination in the (extremely painful to edit) manual.

> How about we include the filtering hint: > > "Enables the intersections detected between all objects contained in the scene to be drawn in this lineart, use collection intersection mask combinations to filter." that's good to me. but probably better to shorten it a bit for the tooltip and overhaul this explaination in the (extremely painful to edit) manual.

YimingWu commented

2023-02-15 09:50:39 +01:00

Author

Member

(extremely painful to edit)

Exactly the reason I haven't been able to touch the manual very much after all these modifications....

> (extremely painful to edit) Exactly the reason I haven't been able to touch the manual very much after all these modifications....

Brecht Van Lommel added this to the Grease Pencil project 2023-02-15 09:51:28 +01:00

Antonio Vazquez commented

2023-02-15 10:11:13 +01:00

Member

@mendio what do you think?

@mendio what do you think?

Matias Mendiola commented

2023-02-15 13:15:10 +01:00

Member

@mendio what do you think?

Agree with @icappiello, a relabel and a better tooltip is the best way.
Warnings on the panels are not UI friendly.

> @mendio what do you think? Agree with @icappiello, a relabel and a better tooltip is the best way. Warnings on the panels are not UI friendly.

Ivan Cappiello commented

2023-02-15 15:52:01 +01:00

Member

if we agree on the change i'd suggest to add it also to the backport list for 3.3lts

@ChengduLittleA would you mind to update the thread with a picture reflecting the changes?

if we agree on the change i'd suggest to add it also to the backport list for 3.3lts @ChengduLittleA would you mind to update the thread with a picture reflecting the changes?

Hans Goudey changed title from ~~LineArt: UI hint for using intersection filtering.~~ to LineArt: UI hint for using intersection filtering

2023-02-15 23:21:48 +01:00

YimingWu added 1 commit 2023-02-16 06:08:12 +01:00

86b1259d56 LineArt: Put intersection filtering hint in the tooltip.

YimingWu commented

2023-02-16 06:08:26 +01:00

Author

Member

Now I made it this way, should be much cleaner on the UI.

![image](/attachments/b402497d-3ed7-4a36-91f9-74e462c2509b) Now I made it this way, should be much cleaner on the UI.

Matias Mendiola commented

2023-02-16 11:56:35 +01:00

Member

Now I made it this way, should be much cleaner on the UI.

the image link seems to be broken and please update also the PR description with the new design.

> ![图片](/attachments/b402497d-3ed7-4a36-91f9-74e462c2509b) > > Now I made it this way, should be much cleaner on the UI. the image link seems to be broken and please update also the PR description with the new design.

Matias Mendiola commented

2023-02-16 15:21:15 +01:00

Member

Thanks @ChengduLittleA, just notice in your image that there is a double period ending in the tooltip.

Thanks @ChengduLittleA, just notice in your image that there is a double period ending in the tooltip.

Falk David reviewed 2023-02-16 15:22:03 +01:00

source/blender/makesrna/intern/rna_gpencil_modifier.c

						
				@ -3809,0 +3809,4 @@

				      prop,

				      "Use Intersection",

				      "Enables the intersections detected between all objects contained in the scene to be drawn "

				      "in this lineart (Use collection intersection mask combinations to filter).");

Falk David commented

2023-02-16 15:22:03 +01:00

Member

No need for the . at the end.

No need for the `.` at the end.

YimingWu commented

2023-02-16 15:22:15 +01:00

Author

Member

I'll fix it! Thanks for noticing!

I'll fix it! Thanks for noticing!

YimingWu added 1 commit 2023-02-16 15:23:35 +01:00

d5e47859d2 Cleanup: LineArt: Remove period in RNA description.

Brecht Van Lommel requested review from Matias Mendiola 2023-03-10 13:11:52 +01:00

Brecht Van Lommel requested review from Falk David 2023-03-10 13:11:52 +01:00

This pull request has changes conflicting with the target branch.

source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c
source/blender/makesrna/intern/rna_gpencil_modifier.c

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u lineart_ui_optimization:ChengduLittleA-lineart_ui_optimization

git checkout ChengduLittleA-lineart_ui_optimization

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

5 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104767

No description provided.