LineArt: UI hint for using intersection filtering #104767

Open
YimingWu wants to merge 3 commits from ChengduLittleA/blender:lineart_ui_optimization into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

This makes it easier for the user to understand that intersection is not filtered by source selection, and should be filtered with mask options down below.

(Is the attachment showing now?)

This makes it easier for the user to understand that intersection is not filtered by source selection, and should be filtered with mask options down below. (Is the attachment showing now?)
YimingWu added the
Interest
User Interface
Interest
Line Art
labels 2023-02-15 06:24:02 +01:00
YimingWu added 1 commit 2023-02-15 06:24:17 +01:00
Member

@ChengduLittleA
i believe this warning, even if makes the user aware of the issue, is not ideal from an ui/ux pov imo. warnings are perceived by the users as alerts from a misusage and makes the software look unstable.

what i'd suggest as other option to consider:

  1. relabel "intersection" to "global intersection" or "scene intersection detection". this would be more self explainatory and intentional than a warning.

  2. move the description in the tooltip that appears on mouse over. rephrasing the warning in something that looks more like a statement raherer than an alert would help.

@filedescriptor should probably involved in this decision.

@ChengduLittleA i believe this warning, even if makes the user aware of the issue, is not ideal from an ui/ux pov imo. warnings are perceived by the users as alerts from a misusage and makes the software look unstable. what i'd suggest as other option to consider: 1. relabel "intersection" to "global intersection" or "scene intersection detection". this would be more self explainatory and intentional than a warning. 2. move the description in the tooltip that appears on mouse over. rephrasing the warning in something that looks more like a statement raherer than an alert would help. @filedescriptor should probably involved in this decision.
Author
Member

"Global Intersection" with a tooltip explanation seems to be a better choice indeed.

"Global Intersection" with a tooltip explanation seems to be a better choice indeed.
Member

"Global Intersection" with a tooltip explanation seems to be a better choice indeed.

in this case i'd suggest also to rephrase the description to something like:

"allows intersections detected between all visible objects in the scene to be drawn in this lineart"

> "Global Intersection" with a tooltip explanation seems to be a better choice indeed. in this case i'd suggest also to rephrase the description to something like: "allows intersections detected between all visible objects in the scene to be drawn in this lineart"
Author
Member

How about we include the filtering hint:

"Enables the intersections detected between all objects contained in the scene to be drawn in this lineart, use collection intersection mask combinations to filter."

How about we include the filtering hint: "Enables the intersections detected between all objects contained in the scene to be drawn in this lineart, use collection intersection mask combinations to filter."
Member

How about we include the filtering hint:

"Enables the intersections detected between all objects contained in the scene to be drawn in this lineart, use collection intersection mask combinations to filter."

that's good to me. but probably better to shorten it a bit for the tooltip and overhaul this explaination in the (extremely painful to edit) manual.

> How about we include the filtering hint: > > "Enables the intersections detected between all objects contained in the scene to be drawn in this lineart, use collection intersection mask combinations to filter." that's good to me. but probably better to shorten it a bit for the tooltip and overhaul this explaination in the (extremely painful to edit) manual.
Author
Member

(extremely painful to edit)

Exactly the reason I haven't been able to touch the manual very much after all these modifications....

> (extremely painful to edit) Exactly the reason I haven't been able to touch the manual very much after all these modifications....
Brecht Van Lommel added this to the Grease Pencil project 2023-02-15 09:51:28 +01:00

@mendio what do you think?

@mendio what do you think?

@mendio what do you think?

Agree with @icappiello, a relabel and a better tooltip is the best way.
Warnings on the panels are not UI friendly.

> @mendio what do you think? Agree with @icappiello, a relabel and a better tooltip is the best way. Warnings on the panels are not UI friendly.
Member

if we agree on the change i'd suggest to add it also to the backport list for 3.3lts

@ChengduLittleA would you mind to update the thread with a picture reflecting the changes?

if we agree on the change i'd suggest to add it also to the backport list for 3.3lts @ChengduLittleA would you mind to update the thread with a picture reflecting the changes?
Hans Goudey changed title from LineArt: UI hint for using intersection filtering. to LineArt: UI hint for using intersection filtering 2023-02-15 23:21:48 +01:00
YimingWu added 1 commit 2023-02-16 06:08:12 +01:00
Author
Member

image

Now I made it this way, should be much cleaner on the UI.

![image](/attachments/b402497d-3ed7-4a36-91f9-74e462c2509b) Now I made it this way, should be much cleaner on the UI.

图片

Now I made it this way, should be much cleaner on the UI.

the image link seems to be broken and please update also the PR description with the new design.

> ![图片](/attachments/b402497d-3ed7-4a36-91f9-74e462c2509b) > > Now I made it this way, should be much cleaner on the UI. the image link seems to be broken and please update also the PR description with the new design.

Thanks @ChengduLittleA, just notice in your image that there is a double period ending in the tooltip.

Thanks @ChengduLittleA, just notice in your image that there is a double period ending in the tooltip.
Falk David reviewed 2023-02-16 15:22:03 +01:00
@ -3809,0 +3809,4 @@
prop,
"Use Intersection",
"Enables the intersections detected between all objects contained in the scene to be drawn "
"in this lineart (Use collection intersection mask combinations to filter).");
Member

No need for the . at the end.

No need for the `.` at the end.
Author
Member

I'll fix it! Thanks for noticing!

I'll fix it! Thanks for noticing!
YimingWu added 1 commit 2023-02-16 15:23:35 +01:00
Brecht Van Lommel requested review from Matias Mendiola 2023-03-10 13:11:52 +01:00
Brecht Van Lommel requested review from Falk David 2023-03-10 13:11:52 +01:00
This pull request has changes conflicting with the target branch.
  • source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c
  • source/blender/makesrna/intern/rna_gpencil_modifier.c

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u lineart_ui_optimization:ChengduLittleA-lineart_ui_optimization
git checkout ChengduLittleA-lineart_ui_optimization
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104767
No description provided.