UI: Properly cancel dragging on Esc & right-click #104838

Julian Eisel · 2023-02-16T19:19:55+01:00

Julian Eisel commented

2023-02-16 19:19:55 +01:00

Previously Escape would cancel the dragging, but still pass on the event
to other handlers, which could trigger other behavior. For example
cancelling dragging a file in a file browser dialog would cancel the
file browser operation and close the window. Right-click didn't cancel
anything even though we usually use both Escape and right-click as a way
to cancel operations.

Now both Escape and right-click cancel the dragging and the event is not passed
on further.

Previously Escape would cancel the dragging, but still pass on the event to other handlers, which could trigger other behavior. For example cancelling dragging a file in a file browser dialog would cancel the file browser operation and close the window. Right-click didn't cancel anything even though we usually use both Escape and right-click as a way to cancel operations. Now both Escape and right-click cancel the dragging and the event is not passed on further.

👍 1

Julian Eisel added 1 commit 2023-02-16 19:20:03 +01:00

1d1f882b9e UI: Properly cancel dragging on Esc & right-click

Previously Escape would cancel the dragging, but still pass on the event
to other handlers, which could trigger other behavior. For example
cancelling dragging a file in a file browser dialog would cancel the
file browser operation and close the window. Right-click didn't cancel
anything even though we usually use both Escape and right-click as a way
to cancel the operation.

Now both Escape and right-click both cancel the dragging and the event
is not passed on further.

Julian Eisel requested review from Campbell Barton 2023-02-16 19:22:35 +01:00

Julian Eisel referenced this pull request

2023-02-16 19:28:17 +01:00

File Browser: Make full file name label draggable #104830

Brecht Van Lommel added this to the User Interface project 2023-02-20 10:38:00 +01:00

Julian Eisel added 1 commit 2023-02-22 16:51:29 +01:00

a4b2f595f5 Merge branch 'main' into temp-drag-drop-cancel

Julian Eisel commented

2023-02-22 16:53:32 +01:00

As noted in the chat, this should be fine to commit without much review. I don't expect issues but if there are any, I'm there to fix them or revert the change.

Julian Eisel referenced this issue from a commit

2023-02-22 16:57:10 +01:00

UI: Properly cancel dragging on escape or right-click

Julian Eisel commented

2023-02-22 16:59:05 +01:00

Committed d58e422ac3.

Committed d58e422ac3.

Julian Eisel closed this pull request

2023-02-22 16:59:05 +01:00

Julian Eisel deleted branch temp-drag-drop-cancel

2023-02-22 17:00:33 +01:00

Julian Eisel referenced this issue from a commit