Fix #72093: Collapse Wide Enum Lists to One Column #105386

Merged
Harley Acheson merged 9 commits from Harley/blender:WideEnumList into main 2023-11-16 21:14:44 +01:00
Member

If a multi-column enum menu gets too wide for the available space,
collapse it to a single column.


For long lists of EnumPropery Items (ColorSpace, Language, RemapUser ID, Editor Type, etc), these display as multiple columns even when wider than available space. When this occurs it is extremely difficult to select without resizing the window. Sometimes the window cannot be resized enough to view and select from. This patch estimates the needed width and will force the list to show in a single column if not enough.

This patch has been resurrected because @lichtwerk mentioned this is as a long-standing UI complaint. During the previous review @ideasman42 had concerns that this was complicated an already-complex section of code. I agree but possibly still worth considering (again).

Some examples of unusable wide lists:

BLNDR_DropdownIssue.jpg

preferences_UI_bug.png

This discussion shows all the multiple bug reports merged into this one: #72093

If a multi-column enum menu gets too wide for the available space, collapse it to a single column. --- For long lists of EnumPropery Items (ColorSpace, Language, RemapUser ID, Editor Type, etc), these display as multiple columns even when wider than available space. When this occurs it is extremely difficult to select without resizing the window. Sometimes the window cannot be resized enough to view and select from. This patch *estimates* the needed width and will force the list to show in a single column if not enough. This patch has been [resurrected](https://archive.blender.org/developer/D6362) because @lichtwerk mentioned this is as a long-standing UI complaint. During the previous review @ideasman42 had concerns that this was complicated an already-complex section of code. I agree but possibly still worth considering (again). Some examples of unusable wide lists: ![BLNDR_DropdownIssue.jpg](/attachments/4e44fda2-6149-4141-8a5d-0e25004ed8f7) ![preferences_UI_bug.png](/attachments/120bea8a-f031-4443-99be-d723fb8da1e2) This discussion shows all the multiple bug reports merged into this one: https://projects.blender.org/blender/blender/issues/72093
Harley Acheson added this to the User Interface project 2023-04-07 19:23:51 +02:00
Harley Acheson force-pushed WideEnumList from 7f8cccdb82 to fbad31a4fd 2023-06-28 20:49:35 +02:00 Compare
Harley Acheson force-pushed WideEnumList from fbad31a4fd to 6f6ca4ad9b 2023-07-14 19:25:58 +02:00 Compare
Harley Acheson added 2 commits 2023-08-24 00:37:21 +02:00
Harley Acheson requested review from Campbell Barton 2023-08-24 00:40:35 +02:00
Author
Member

Approved by the UI Module.

Approved by the UI Module.
Harley Acheson added 1 commit 2023-08-31 22:43:19 +02:00
Harley Acheson added 1 commit 2023-09-09 01:52:56 +02:00
Harley Acheson added 2 commits 2023-11-12 17:02:00 +01:00
Harley Acheson added 2 commits 2023-11-16 20:41:31 +01:00
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson merged commit 83ce3ef0db into main 2023-11-16 21:14:44 +01:00
Harley Acheson deleted branch WideEnumList 2023-11-16 21:14:45 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105386
No description provided.