WIP: Evaluate Red Auto Keying Button
#105574
Draft
Harley Acheson
wants to merge 2 commits from Harley/blender:RecordRed
into main
pull from: Harley/blender:RecordRed
merge into: blender:main
blender:main
blender:blender-v3.6-release
blender:temp-sculpt-dyntopo
blender:temp-sculpt-dyntopo-hive-alloc
blender:asset-shelf
blender:cycles-light-linking
blender:tmp-usd-python-mtl
blender:brush-assets-project
blender:blender-v2.93-release
blender:blender-v3.3-release
blender:universal-scene-description
blender:node-group-operators
blender:asset-browser-frontend-split
blender:temp-sculpt-attr-api
blender:blender-v3.5-release
blender:realtime-clock
blender:sculpt-dev
blender:gpencil-next
blender:bevelv2
blender:microfacet_hair
blender:blender-projects-basics
blender:principled-v2
When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Reviewers
Request review
No reviewers
Labels
Clear labels
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Apply labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
Eevee & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest/Import
Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
Eevee & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest/Import
Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#105574
Reference in New Issue
There is no content yet.
Delete Branch "Harley/blender:RecordRed"
Deleting a branch is permanent. It CANNOT be undone. Continue?
Changing the icons used for auto keying to be more noticeable.
Currently when we have auto-keying enabled, and manipulating an object, we show a warning message at the top-right. But I doubt many people have noticed it at all. We don't get bug reports about it yet it has displayed awkwardly overlapping the navigation widget for years:
My guess is that this warning was added because we don't indicate very strongly that auto-keying is on. Because we are using monochrome icons in the interface there isn't a big difference between a filled circle at full blackness versus that same circle when grey.
This patch replaces the icon used with a pair for off and on. The "on" version using the color red to better simulate a "record" button in use. The "off" state uses an unfilled circle because that seems to better indicate off.
The color itself can be changed in the theme, so it can be set back to white (or anything else) if desired:
I like "red" is record, that is kind of a universal "recording is going on" indicator.
The only change would be to keep the white outline so you don't change size just red fill.
I do too. But there is a chance that the perception of it could differ by age with older people seeing it as normal because of audio and video recorders, while younger people could just see it as an "error" color.
Some red-green colorblindness could also alter this perception. Usually for them we push the color toward yellow into orange. Which could make sense for all since that is more of a warning color. Or maybe a bright orange-yellow?
The icons are created and stored as monochrome, just shades of white. But we are able to recolor these at will, so showing them as white on the dark theme while black on the light theme. So we can make it any color as long as it is one hue, not multiple at a time.
The change of size though is because I am just using our "radio button off" icon here, which isn't quite the right size. If this is something we like then we'd have to create a new icon in the set specifically for "record off"
Audacity also has a 'red dot' recording button, and so does Reaper. These are always red, though, and not just when they are enabled.
I think either of these would work:
In both cases the red colour is not the only thing that conveys the information, so it should be fine for colourblind people.
That's a shame.
👍
24514f2d5e
to73aab156d3
My comment about that was a bit wrong-ish. All our current icons are white so that we can re-color them for display. So we can turn that white source icon into one that is black or blue or green.
But... it works just fine if the source icon image has colors, even multiple colors or gradients, etc. Just doing so would not allow us to recolor it later. Of course that does not matter in this case. So the icons in this PR have both a white ring and a red interior. And it looks just fine in both dark and light themes.
@blender-bot package
Package build started. Download here when ready.
Currently (not in PR yet) have a "disabled" state here that I quite like:
My worry with it being that grey/faded it looks like it can't be clicked vs. off, if you have the white circle the same brightness as the play buttons, full white then it doesn't look disabled/unclickable maybe.
Because if you compare the drop down arrow next to it, it is the same light grey and it is disabled... unclickable.
well.. clicked the wrong comment
Good point. I'll keep playing.
77480c4ee3
to0772dda353
Some users will have a tough time with the red indication and blue background. So I updated the the icons to use only a single color, but you can set the color in the theme. That way anyone who hates the red can set it to white or yellow or anything else. I updated the original comment and the images there.
we coukd maybe consider it as the other play forward, play backward, pause buttons.
they don't have a pressed blue state.in that case we can use the white circle for disabled autokey, and white circle and red fill for auto key on.
edit:
i was wrong, they have pressed blue state. What i was looking at is the play button which changes from play to pause but doesn't stay in pressed blue state.
I updated the animated gif capture in the first comment. Now using icons that exactly match the design language of other icons that have an on and off state:
I like the button in your last comment 👍
I guess this wasn't finalized in any of the meetings, what is left to do?
I think the last version is pretty nice (in the first comment), and allows users or theme designers to change the color if needed.
The next step should really be your module deciding if this is wanted or not. If yes I can then see what UI module thinks.