WIP: Enable support for EDR on Mac #105662

Draft
Jason Fielder wants to merge 7 commits from Jason-Fielder/blender:macos_EDR_support into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Basic enablement of EDR support for EDR capable displays on Mac.

Added a new, “Extended sRGB” display option which enables the additional color/intensity range.

Basic enablement of EDR support for EDR capable displays on Mac. Added a new, “Extended sRGB” display option which enables the additional color/intensity range. ![](https://projects.blender.org/attachments/4b7cc7e2-ab24-4e3d-a1df-dd1421dc4de8)
Jason Fielder added 2 commits 2023-03-11 15:43:40 +01:00
2e8755b261 WIP: Enable support for EDR on Mac
Basic enablement of EDR support for EDR capable displays on Mac.

Added a new, “Extended sRGB” display option which enables the additional color/intensity range for viewport and Cycles renders.
Jason Fielder requested review from Jeroen Bakker 2023-03-11 15:47:23 +01:00
Jason Fielder requested review from Clément Foucault 2023-03-11 15:47:50 +01:00
Jason Fielder requested review from Alaska 2023-03-11 15:47:59 +01:00
Clément Foucault added this to the 3.6 LTS milestone 2023-03-11 21:12:07 +01:00
Clément Foucault added this to the EEVEE & Viewport project 2023-03-11 21:12:11 +01:00
Clément Foucault added the
Platform
macOS
Interest
Metal
labels 2023-03-11 21:12:26 +01:00
Alaska refused to review 2023-03-11 22:04:14 +01:00
Collaborator

I am removing myself as a reviewer as I am not part of the Blender foundation, nor do I have much programming knowledge, so I can not review the code. All I can do is test the feature and report issues with it.

I am removing myself as a reviewer as I am not part of the Blender foundation, nor do I have much programming knowledge, so I can not review the code. All I can do is test the feature and report issues with it.
Collaborator

Here is my comment from the other pull request. I have not retested the patch so some of this information may be invalid.

Here's a few things I found from a quick test:

  1. The material and light preview don't appear to use EDR. I would personally expect them too. (This change might be outside the scope of this pull request)
  2. Extended sRGB is available as an option to pick on non Mac platforms (E.G. Windows) but it doesn't appear to do anything.

System Information
Operating system: macOS-13.1-arm64-arm-64bit 64 Bits
Device: 14inch M1 Pro Macbook Pro - I was using the built in display for testing

Here's a screenshot showing where the material preview panel can be found:
Screenshot of Material Preview.png

Here is my comment from the other pull request. I have not retested the patch so some of this information may be invalid. Here's a few things I found from a quick test: 1. The material and light preview don't appear to use EDR. I would personally expect them too. (This change might be outside the scope of this pull request) 3. Extended sRGB is available as an option to pick on non Mac platforms (E.G. Windows) but it doesn't appear to do anything. **System Information** Operating system: macOS-13.1-arm64-arm-64bit 64 Bits Device: 14inch M1 Pro Macbook Pro - I was using the built in display for testing Here's a screenshot showing where the material preview panel can be found: ![Screenshot of Material Preview.png](/attachments/69c9954e-ebee-4f8f-8ead-ce98f9f7a407)

Yes, both limitations are expected.

  • All panels in Blender are sRGB 8 bit per channel.
  • Windows/Linux cannot use HDR in OpenGL.

Expectation is that this patch requires many tweaks and other topics to be solved, before it will be enabled by default in Blender.

In the short term it is expected become an experimental developer option in order for developers to start planning the modifications.

Yes, both limitations are expected. * All panels in Blender are sRGB 8 bit per channel. * Windows/Linux cannot use HDR in OpenGL. Expectation is that this patch requires many tweaks and other topics to be solved, before it will be enabled by default in Blender. In the short term it is expected become an experimental developer option in order for developers to start planning the modifications.

I test run this, and found some limitations in the viewport

  • Artifacts when drawing transparent panels on top of a a cycles render.
  • Overlay isn't visible to user in all situations.
  • Artifacts around pixels of a cycles viewport render. Borders around individual cycles pixels.

I do think it is interesting to see this happening. We might first want to align with #105714. Questions like EDR vs HDR?

Biggest challenge IMO is finding a developer who can pull this off on our side.

I test run this, and found some limitations in the viewport - Artifacts when drawing transparent panels on top of a a cycles render. - Overlay isn't visible to user in all situations. - Artifacts around pixels of a cycles viewport render. Borders around individual cycles pixels. I do think it is interesting to see this happening. We might first want to align with #105714. Questions like EDR vs HDR? Biggest challenge IMO is finding a developer who can pull this off on our side.

More detail in #105714, but I think it makes sense for this to be a boolean HDR on/off option that only affects display. It could only show on systems where it is supported, and does not have to be experimental assuming the bugs can be fixed.

It's wide gamut that requires deeper changes, but we don't necessarily have to add support for them at the same time.

More detail in #105714, but I think it makes sense for this to be a boolean HDR on/off option that only affects display. It could only show on systems where it is supported, and does not have to be experimental assuming the bugs can be fixed. It's wide gamut that requires deeper changes, but we don't necessarily have to add support for them at the same time.
Brecht Van Lommel modified the milestone from 3.6 LTS to 4.0 2023-05-12 16:55:48 +02:00
Jason Fielder added 1 commit 2023-06-08 18:03:19 +02:00
Jason Fielder added 3 commits 2023-06-09 19:41:20 +02:00
Jason Fielder added 1 commit 2023-06-09 22:02:39 +02:00

Reviewers

Jeroen Bakker was requested for review 2023-03-11 15:47:23 +01:00
Clément Foucault was requested for review 2023-03-11 15:47:50 +01:00
This pull request is marked as a work in progress.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
Eevee & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest/Import
Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Eevee & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105662
There is no content yet.