WIP: Enable support for EDR on Mac #105662

Basic enablement of EDR support for EDR capable displays on Mac.

Added a new, “Extended sRGB” display option which enables the additional color/intensity range.

Basic enablement of EDR support for EDR capable displays on Mac. Added a new, “Extended sRGB” display option which enables the additional color/intensity range. ![](https://projects.blender.org/attachments/4b7cc7e2-ab24-4e3d-a1df-dd1421dc4de8)

Screenshot 2023-03-10 at 11.21.19.png

51 KiB

I am removing myself as a reviewer as I am not part of the Blender foundation, nor do I have much programming knowledge, so I can not review the code. All I can do is test the feature and report issues with it.

Here is my comment from the other pull request. I have not retested the patch so some of this information may be invalid.

Here's a few things I found from a quick test:

The material and light preview don't appear to use EDR. I would personally expect them too. (This change might be outside the scope of this pull request)
Extended sRGB is available as an option to pick on non Mac platforms (E.G. Windows) but it doesn't appear to do anything.

System Information
Operating system: macOS-13.1-arm64-arm-64bit 64 Bits
Device: 14inch M1 Pro Macbook Pro - I was using the built in display for testing

Here's a screenshot showing where the material preview panel can be found:

Here is my comment from the other pull request. I have not retested the patch so some of this information may be invalid. Here's a few things I found from a quick test: 1. The material and light preview don't appear to use EDR. I would personally expect them too. (This change might be outside the scope of this pull request) 3. Extended sRGB is available as an option to pick on non Mac platforms (E.G. Windows) but it doesn't appear to do anything. **System Information** Operating system: macOS-13.1-arm64-arm-64bit 64 Bits Device: 14inch M1 Pro Macbook Pro - I was using the built in display for testing Here's a screenshot showing where the material preview panel can be found: ![Screenshot of Material Preview.png](/attachments/69c9954e-ebee-4f8f-8ead-ce98f9f7a407)

Yes, both limitations are expected.

All panels in Blender are sRGB 8 bit per channel.
Windows/Linux cannot use HDR in OpenGL.

Expectation is that this patch requires many tweaks and other topics to be solved, before it will be enabled by default in Blender.

In the short term it is expected become an experimental developer option in order for developers to start planning the modifications.

Yes, both limitations are expected. * All panels in Blender are sRGB 8 bit per channel. * Windows/Linux cannot use HDR in OpenGL. Expectation is that this patch requires many tweaks and other topics to be solved, before it will be enabled by default in Blender. In the short term it is expected become an experimental developer option in order for developers to start planning the modifications.

I test run this, and found some limitations in the viewport

Artifacts when drawing transparent panels on top of a a cycles render.
Overlay isn't visible to user in all situations.
Artifacts around pixels of a cycles viewport render. Borders around individual cycles pixels.

I do think it is interesting to see this happening. We might first want to align with #105714. Questions like EDR vs HDR?

Biggest challenge IMO is finding a developer who can pull this off on our side.

I test run this, and found some limitations in the viewport - Artifacts when drawing transparent panels on top of a a cycles render. - Overlay isn't visible to user in all situations. - Artifacts around pixels of a cycles viewport render. Borders around individual cycles pixels. I do think it is interesting to see this happening. We might first want to align with #105714. Questions like EDR vs HDR? Biggest challenge IMO is finding a developer who can pull this off on our side.

More detail in #105714, but I think it makes sense for this to be a boolean HDR on/off option that only affects display. It could only show on systems where it is supported, and does not have to be experimental assuming the bugs can be fixed.

It's wide gamut that requires deeper changes, but we don't necessarily have to add support for them at the same time.

More detail in #105714, but I think it makes sense for this to be a boolean HDR on/off option that only affects display. It could only show on systems where it is supported, and does not have to be experimental assuming the bugs can be fixed. It's wide gamut that requires deeper changes, but we don't necessarily have to add support for them at the same time.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

WIP: Enable support for EDR on Mac #105662

Reviewers