Fix #105791: Alembic procedural ignores materials #105798

Merged
Hans Goudey merged 1 commits from HooglyBoogly/blender:fix-alembic-cycles-material into blender-v3.5-release 2023-03-15 19:02:04 +01:00
Member

When creating the bounding box mesh for the viewport replacement,
copy the material from the original mesh. I'm not sure if Cycles is
meant to load materials from the original mesh or the Alembic file
itself, but either way, this should be a harmless change and fixes the
issue in the report.

When creating the bounding box mesh for the viewport replacement, copy the material from the original mesh. I'm not sure if Cycles is meant to load materials from the original mesh or the Alembic file itself, but either way, this should be a harmless change and fixes the issue in the report.
Hans Goudey added this to the 3.5 milestone 2023-03-15 16:17:07 +01:00
Hans Goudey added the
Module
Render & Cycles
label 2023-03-15 16:17:07 +01:00
Hans Goudey added 1 commit 2023-03-15 16:17:17 +01:00
ad4eaff3d1 Fix #105791: Alembic procedural ignores materials
When creating the bounding box mesh for the viewport replacement,
copy the material from the original mesh. I'm not sure if Cycles is
meant to load materials from the original mesh or the Alembic file
itself, but either way, this should be a harmless change and fixes the
issue in the report.
Hans Goudey requested review from Brecht Van Lommel 2023-03-15 16:17:29 +01:00
Hans Goudey requested review from William Leeson 2023-03-15 16:17:29 +01:00
Hans Goudey added this to the Render & Cycles project 2023-03-15 16:17:35 +01:00
Brecht Van Lommel approved these changes 2023-03-15 18:27:11 +01:00
Brecht Van Lommel left a comment
Owner

This seems fine by itself.

I'm not sure if there was another reason @leesonw disabled the bounding box, but if there is something else to be fixed it can be done separately.

This seems fine by itself. I'm not sure if there was another reason @leesonw disabled the bounding box, but if there is something else to be fixed it can be done separately.
Member

@brecht @HooglyBoogly No this is a better fix. The bounding box was disabled to make it easier to check the Alembic objects wireframe vs the Cycles image to make sure they correlated.

This seems fine by itself.

I'm not sure if there was another reason @leesonw disabled the bounding box, but if there is something else to be fixed it can be done separately.

@brecht @HooglyBoogly No this is a better fix. The bounding box was disabled to make it easier to check the Alembic objects wireframe vs the Cycles image to make sure they correlated. > This seems fine by itself. > > I'm not sure if there was another reason @leesonw disabled the bounding box, but if there is something else to be fixed it can be done separately.
Hans Goudey merged commit e7295efb4b into blender-v3.5-release 2023-03-15 19:02:04 +01:00
Hans Goudey deleted branch fix-alembic-cycles-material 2023-03-15 19:02:06 +01:00
Brecht Van Lommel removed this from the Render & Cycles project 2023-05-24 19:05:20 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project (Legacy)
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#105798
No description provided.