Fix blender_test not re-linked on macOS after changes #106051

Merged
Sergey Sharybin merged 1 commits from Sergey/blender:fix_blender_test into main 2023-03-24 14:11:58 +01:00

The Linux worked due to the libraries provided as a dependency
via EXTRA_LIBS "${TEST_LIBS}" with extra whole archive.

While on Windows and macOS the whole-archive is not needed the
dependency from the library to the blender_test is still needed.

Solves the issue when modifying asset_catalog_test.cc on macOS
does not make blender_test to be relinked.

The Linux worked due to the libraries provided as a dependency via `EXTRA_LIBS "${TEST_LIBS}"` with extra whole archive. While on Windows and macOS the whole-archive is not needed the dependency from the library to the blender_test is still needed. Solves the issue when modifying asset_catalog_test.cc on macOS does not make blender_test to be relinked.
Sergey Sharybin added 1 commit 2023-03-23 16:26:08 +01:00
buildbot/vexp-code-patch-coordinator Build done. Details
db84e7f30a
Fix blender_test not re-linked on macOS after changes
The Linux worked due to the libraries provided as a dependency
via `EXTRA_LIBS "${TEST_LIBS}"` with extra whole archive.

While on Windows and macOS the whole-archive is not needed the
dependency from the library to the blender_test is still needed.

Solves the issue when modifying asset_catalog_test.cc on macOS
does not make blender_test to be relinked.
Sergey Sharybin added the
Module
Platforms, Builds & Tests
label 2023-03-23 16:26:24 +01:00
Sergey Sharybin added this to the Platforms, Builds Tests & Devices project 2023-03-23 16:26:28 +01:00
Sergey Sharybin requested review from Brecht Van Lommel 2023-03-23 16:26:44 +01:00
Sergey Sharybin requested review from Julian Eisel 2023-03-23 16:26:44 +01:00
Sergey Sharybin requested review from Ray molenkamp 2023-03-23 16:26:44 +01:00
Julian Eisel approved these changes 2023-03-23 16:43:36 +01:00
Brecht Van Lommel approved these changes 2023-03-24 11:05:39 +01:00
Author
Owner

@blender-bot build

@blender-bot build
Sergey Sharybin merged commit 18a15bafe8 into main 2023-03-24 14:11:58 +01:00
Sergey Sharybin deleted branch fix_blender_test 2023-03-24 14:11:59 +01:00
Member

This reintroduced a duplicate symbol linker error that we fixed in

dcb2821292

The dependency rebuild was supposedly fixed with

67856d8c4a

If it still shows up, suggest to use add_dependency instead of specifying linker dependencies.

duplicate symbol 'blender::fn::tests::field_SameFieldTwice_Test::test_info_' in:
    /Users/ankitkumar/apps/build_darwin_debug_lite/lib/libbf_functions_tests.a(FN_field_test.cc.o)
    lib/libbf_functions_tests.a(FN_field_test.cc.o)
This reintroduced a duplicate symbol linker error that we fixed in https://projects.blender.org/blender/blender/commit/dcb2821292f962951e88f146cb304160f21f73da The dependency rebuild was supposedly fixed with https://projects.blender.org/blender/blender/commit/67856d8c4afa6a35b15f00ce24ebe54f403c9fc7 If it still shows up, suggest to use add_dependency instead of specifying linker dependencies. ``` duplicate symbol 'blender::fn::tests::field_SameFieldTwice_Test::test_info_' in: /Users/ankitkumar/apps/build_darwin_debug_lite/lib/libbf_functions_tests.a(FN_field_test.cc.o) lib/libbf_functions_tests.a(FN_field_test.cc.o) ```
Author
Owner

@ankitm The issue you're describing does not happen on any of the platforms I have access to. Can you submit a PR with a fix which works for you?

@ankitm The issue you're describing does not happen on any of the platforms I have access to. Can you submit a PR with a fix which works for you?
Member

@Sergey simply reverting this commit fixes the linker issue.

@Sergey simply reverting this commit fixes the linker issue.
Author
Owner

@ankitm Simply reverting the change will re-introduce the issue of tests not properly re-linked after changes which me and Julian were running into. So that's not really an option on its own. There must be a fix which addresses both proper linking and the duplicate symbols issues. Is just easier for someone who has the duplicate symbols issue to work that proper solution.

@ankitm Simply reverting the change will re-introduce the issue of tests not properly re-linked after changes which me and Julian were running into. So that's not really an option on its own. There must be a fix which addresses both proper linking and the duplicate symbols issues. Is just easier for someone who has the duplicate symbols issue to work that proper solution.
Member

ok trying

ok trying
Member
https://projects.blender.org/blender/blender/pulls/107033
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106051
No description provided.