GPU: Resolve runtime issues with texture views for Metal #106220

Jason Fielder · 2023-03-28T15:34:14+02:00

Jason Fielder commented

2023-03-28 15:34:14 +02:00

When creating a texture view, Metal may require that the original
GPUTexture state is modified in some way. This may be a result
of deferred creation, or, to cache the texture view against the
source.

As a result, GPUTexture passed into GPU_texture_create_view
cannot be const.

This PR also contains a number of texture usage flag fixes
for EEVEE Next for textures used as views.

Authored by Apple: Michael Parkin-White

Ref #96261

When creating a texture view, Metal may require that the original GPUTexture state is modified in some way. This may be a result of deferred creation, or, to cache the texture view against the source. As a result, GPUTexture passed into GPU_texture_create_view cannot be const. This PR also contains a number of texture usage flag fixes for EEVEE Next for textures used as views. Authored by Apple: Michael Parkin-White Ref #96261

Jason Fielder added 1 commit 2023-03-28 15:34:23 +02:00

d4403a84a4 GPU: Resolve runtime issues with texture views for Metal.

When creating a texture view, Metal may require that the original
GPUTexture state is modified in some way. This may be a result
of deferred creation, or, to cache the texture view against the
source.

As a result, GPUTexture passed into GPU_texture_create_view
cannot be const.

This PR also contains a number of texture usage flag fixes
for EEVEE Next for textures used as views.

Authored by Apple: Michael Parkin-White

Ref #96261

Jason Fielder requested review from Jeroen Bakker 2023-03-28 15:35:59 +02:00

Hans Goudey changed title from ~~GPU: Resolve runtime issues with texture views for Metal.~~ to GPU: Resolve runtime issues with texture views for Metal

2023-03-28 16:11:19 +02:00

Jeroen Bakker requested changes 2023-04-03 08:19:07 +02:00

Jeroen Bakker left a comment

This PR can be separated in 3 different patches. This is useful for bug tracking.
I expect a PR containing:

texture usage changes
hair/curve changes
the rest.

This PR can be separated in 3 different patches. This is useful for bug tracking. I expect a PR containing: - texture usage changes - hair/curve changes - the rest.

Michael Parkin-White commented

2023-04-20 12:43:35 +02:00

First-time contributor

Have resubmitted this as separate patches:

EEVEE Next: Ensure correct texutre usage for views #107163
#107163

Metal: TF more optimal for hair refinement #107166
#107166

Metal: Resolve runtime issues with texture views #107167
#107167

Thanks!

Have resubmitted this as separate patches: EEVEE Next: Ensure correct texutre usage for views #107163 https://projects.blender.org/blender/blender/pulls/107163 Metal: TF more optimal for hair refinement #107166 https://projects.blender.org/blender/blender/pulls/107166 Metal: Resolve runtime issues with texture views #107167 https://projects.blender.org/blender/blender/pulls/107167 Thanks!

Jason Fielder closed this pull request

2023-04-20 12:45:36 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GPU: Resolve runtime issues with texture views for Metal #106220

Pull request closed