Armature drawing code refactor #106232

Refactor of the armature drawing code. This PR introduces a strategy pattern for the implementation of the various armature drawing modes. Instead of having to switch (arm->drawtype) everywhere, one function is used to select the appropriate ArmatureBoneDrawStrategy subclass.

In the future this class could be expanded even further. Currently there are still places where there are explict checks for the draw type, making it cumbersome to add new types. For now I feel it's already a good enough move forward; future extensions can be done in later PRs.

#106230 introduces a new armature draw type, using this new strategy pattern. To be able to build it, it also contains the code from (an older version of) this PR.

Refactor of the armature drawing code. This PR introduces a [strategy pattern](https://en.wikipedia.org/wiki/Strategy_pattern) for the implementation of the various armature drawing modes. Instead of having to `switch (arm->drawtype)` everywhere, one function is used to select the appropriate `ArmatureBoneDrawStrategy` subclass. In the future this class could be expanded even further. Currently there are still places where there are explict checks for the draw type, making it cumbersome to add new types. For now I feel it's already a good enough move forward; future extensions can be done in later PRs. ------------- #106230 introduces a new armature draw type, using this new strategy pattern. To be able to build it, it also contains the code from (an older version of) this PR.

Really liking the changes to the code. A lot clearer what's going on

I assume the Sphere drawing mode should also work in edit mode? Currently it draws the default bone

Really liking the changes to the code. A lot clearer what's going on I assume the Sphere drawing mode should also work in edit mode? Currently it draws the default bone

Really liking the changes to the code. A lot clearer what's going on

👍

I assume the Sphere drawing mode should also work in edit mode? Currently it draws the default bone

That's for #106230, but no, for now sphere drawing mode won't work in edit mode. The problem is that for edit mode to work well, you need access to the bone tail, roll, etc.

A solution that was discussed is to draw the octo's in the spheres edit mode, as additional 'ghosts' next to the spheres. For this I feel more of the drawing code should be moved into the ArmatureBoneDrawStrategy classes, or ArmatureDrawContext could use some refactoring. Currently the drawing code is IMO still too linked to the drawing mode.

> Really liking the changes to the code. A lot clearer what's going on :+1: > I assume the Sphere drawing mode should also work in edit mode? Currently it draws the default bone That's for #106230, but no, for now sphere drawing mode won't work in edit mode. The problem is that for edit mode to work well, you *need* access to the bone tail, roll, etc. A solution that was discussed is to draw the octo's in the spheres edit mode, as additional 'ghosts' next to the spheres. For this I feel more of the drawing code should be moved into the `ArmatureBoneDrawStrategy` classes, or `ArmatureDrawContext` could use some refactoring. Currently the drawing code is IMO still too linked to the drawing mode.

I just force-pushed just the code refactor; the addition of sphere drawing mode will be left to another PR. That way this is just a non-functional refactor patch.

lgtm. Just a function name that I think could be more descriptive

 @ -96,0 +128,4 @@
                          const int select_id) const = 0;
   /** Should the relationship line between this bone and its parent be drawn? */
   virtual bool use_bone_relation_to_parent(const EditBone *ebone,

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Armature drawing code refactor #106232

Reviewers