Eevee: MacOS/ATI doesn't work. #106786

Closed
Jeroen Bakker wants to merge 6 commits from Jeroen-Bakker:eevee-legacy-macos-ati into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Member

Due to compatibility issues between legacy Intel drivers that doesn't
unroll macros as expected we added an underscore before the attribute
name to make a distinction between the macro name and the variable it
needs to access. This fails on MacOS/ATI resulting in failing to
render Eevee on those devices. Issue happens both on Metal and OpenGL
backend.

This is a quick fix to support both issues until we have a better
solution or that Eevee is replaced.

Introduced by: #106535
Fix: #106672
Fix: #106702

Due to compatibility issues between legacy Intel drivers that doesn't unroll macros as expected we added an underscore before the attribute name to make a distinction between the macro name and the variable it needs to access. This fails on MacOS/ATI resulting in failing to render Eevee on those devices. Issue happens both on Metal and OpenGL backend. This is a quick fix to support both issues until we have a better solution or that Eevee is replaced. Introduced by: #106535 Fix: #106672 Fix: #106702
Jeroen Bakker added 2 commits 2023-04-11 08:50:09 +02:00
Jeroen Bakker requested review from Clément Foucault 2023-04-11 08:50:24 +02:00
Jeroen Bakker added the
Module
EEVEE & Viewport
label 2023-04-11 08:50:31 +02:00
Jeroen Bakker added this to the 3.5 milestone 2023-04-11 08:50:34 +02:00
Jeroen Bakker added this to the EEVEE & Viewport project 2023-04-11 08:50:39 +02:00
Jeroen Bakker self-assigned this 2023-04-11 08:50:45 +02:00
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR106786) when ready.
Author
Member

@Sergey can you check if the package works for you (both Metal and OpenGL) should be checked.

I might have a system back home able to test the intel driver, but otherwise we should ask the community.

@Sergey can you check if the package works for you (both Metal and OpenGL) should be checked. I might have a system back home able to test the intel driver, but otherwise we should ask the community.
Clément Foucault reviewed 2023-04-11 09:07:16 +02:00
@ -260,3 +273,4 @@
# define renderPassAOVActive renderpass_block.BLOCK_ATTR(renderPassAOVActive)
/* SSSProfileBlock */
# define sss_kernel sssProfile._sss_kernel

Why is this one left unchanged?

Why is this one left unchanged?
Jeroen-Bakker marked this conversation as resolved
Jeroen Bakker added 1 commit 2023-04-11 09:13:13 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
90bc1470e7
Fix missing attribute.
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR106786) when ready.

The issue with this approach is that it might trigger recursive expansion error on some drivers (like the one fixed by #106535).

The issue with this approach is that it might trigger recursive expansion error on some drivers (like the one fixed by #106535).

@Jeroen-Bakker Unfortunately, the monkey is still invisible in my startup file :(

@Jeroen-Bakker Unfortunately, the monkey is still invisible in my startup file :(
Author
Member

Note that it has been validated that this change works on Metal, but not yet on OpenGL. I will update this patch to fix this for opengl as well as we should still
support opengl on MacOS devices for now.

Note that it has been validated that this change works on Metal, but not yet on OpenGL. I will update this patch to fix this for opengl as well as we should still support opengl on MacOS devices for now.
Jeroen Bakker added 2 commits 2023-04-11 15:17:37 +02:00
Author
Member

@blender-bot package

@blender-bot package
Member

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR106786) when ready.
Jeroen Bakker added 1 commit 2023-04-11 15:22:22 +02:00
Author
Member

Current state is that on main MacOS/ATI doesn't work using OpenGL. It does work when using Metal. This patch doesn't seem to change anything compared to main.

Next step to do is to check if the workaround is enabled when using this specific platform.

Current state is that on main MacOS/ATI doesn't work using OpenGL. It does work when using Metal. This patch doesn't seem to change anything compared to main. Next step to do is to check if the workaround is enabled when using this specific platform.
First-time contributor
  • Metal backend still produces intense flickering (strobo-like) on Viewport Shading: Rendered (Cycles Render Engine) on PR #106786 (This issue is present since: 3.6.0 14b112ef82 main 04-03-2023)

Screen Recording 2023-04-11 at 11.38.42.mov

  • OpenGL backend broken with Eeevee and Workbench. OpenGL works fine with Cycles.

Test machine:

macOS Monterey 12.6.4 (21G526)

Mac Pro (Late 2013)
2,7 GHz 12-Core Intel Xeon E5
64 GB 1866 MHz DDR3
AMD FirePro D500 3 GB

- Metal backend still produces intense flickering (strobo-like) on Viewport Shading: Rendered (Cycles Render Engine) on PR https://projects.blender.org/blender/blender/pulls/106786 (This issue is present since: 3.6.0 14b112ef82 main 04-03-2023) [Screen Recording 2023-04-11 at 11.38.42.mov](/attachments/c89587fb-6715-4c90-836f-903b4ddefb21) - OpenGL backend broken with Eeevee and Workbench. OpenGL works fine with Cycles. Test machine: macOS Monterey 12.6.4 (21G526) Mac Pro (Late 2013) 2,7 GHz 12-Core Intel Xeon E5 64 GB 1866 MHz DDR3 AMD FirePro D500 3 GB
Author
Member

@Caco-Oportot Can you create a report for that. It doesn't seem to be related to what we are trying to fix here. Thanks!

@Caco-Oportot Can you create a report for that. It doesn't seem to be related to what we are trying to fix here. Thanks!
First-time contributor

Sorry @Jeroen-Bakker, I posted here because my bug report #106702 was marked to be fixed/deleted by this. I installed the PR106786 build and all the issues persist. My bad.

Sorry @Jeroen-Bakker, I posted here because my bug report #106702 was marked to be fixed/deleted by this. I installed the PR106786 build and all the issues persist. My bad.
Jeroen Bakker closed this pull request 2023-04-13 10:25:37 +02:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106786
No description provided.