Fix #106208: Initialize socket value by declaration callback if value is data block #106816

Closed

Iliya Katushenock wants to merge 4 commits from mod_moder:default_value_cb into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Iliya Katushenock commented

2023-04-11 16:32:25 +02:00

Member

We cannot store pointer to data blocks by value, because
in this case, declarations would have to be available
for visiting by the blender id visitor in order to be
able to delete or relink these pointers. For this reason,
in order to be scalable in the future, this is a callback.
The implementation can find up-to-date value at any time.

This approach also makes it possible not to make unnecessary
updates to the declaration in order to update the actual standard value.

We cannot store pointer to data blocks by value, because in this case, declarations would have to be available for visiting by the blender id visitor in order to be able to delete or relink these pointers. For this reason, in order to be scalable in the future, this is a callback. The implementation can find up-to-date value at any time. This approach also makes it possible not to make unnecessary updates to the declaration in order to update the actual standard value.

Iliya Katushenock added 4 commits 2023-04-11 16:32:38 +02:00

78164f1edc first test commit

aea42e47d0 Merge branch 'main' into default_value_cb

700eb3bbda progress

37f1ece806 progress

Iliya Katushenock changed title from ~~Fix #106208: Initialize socket value by declaration callback if data is data block~~ to Fix #106208: Initialize socket value by declaration callback if value is data block

2023-04-11 16:32:46 +02:00

Iliya Katushenock added this to the Nodes & Physics project 2023-04-11 16:32:53 +02:00

Iliya Katushenock added the

label 2023-04-11 16:33:00 +02:00

Lukas Tönne reviewed 2023-04-12 08:58:27 +02:00

source/blender/nodes/intern/node_common.cc

						
				@ -128,0 +130,4 @@

				    bNodeTree &node_group, StringRefNull socket_name_p)

				{

				  std::string socket_name = socket_name_p;

				  return [node_group = &node_group,

Lukas Tönne commented

2023-04-12 08:58:27 +02:00

Member

I agree that we need to avoid ID pointers in the declarations. But this solves one problem by creating another: Now we have the bNodeTree bound in the callback.

A weak pointer of some kind seems to be needed here, so that ID management code does not have to worry about references stored in node declarations.

I agree that we need to avoid ID pointers in the declarations. But this solves one problem by creating another: Now we have the `bNodeTree` bound in the callback. A weak pointer of some kind seems to be needed here, so that ID management code does not have to worry about references stored in node declarations.

Iliya Katushenock commented

2023-04-12 13:09:06 +02:00

Author

Member

Trees cause refresh on their own. That is, it must be safe.
It would be possible to add a requirement to the topology cache in order to find a node from the socket and take its pointer to the tree. But this can increase the overhead. Or we can pass a node. But at one point it may require also a tree as well ... there is not enough some context

Trees cause refresh on their own. That is, it must be safe. It would be possible to add a requirement to the topology cache in order to find a node from the socket and take its pointer to the tree. But this can increase the overhead. Or we can pass a node. But at one point it may require also a tree as well ... there is not enough some context

Jacques Lucke referenced this pull request

2023-04-20 16:35:06 +02:00

Fix #106208: data-block socket defaults not used for node group #107179

Iliya Katushenock commented

2023-04-20 16:53:14 +02:00

Author

Member

https://projects.blender.org/blender/blender/pulls/107179

Iliya Katushenock closed this pull request

2023-04-20 16:53:15 +02:00

Iliya Katushenock deleted branch default_value_cb

2023-04-20 16:56:31 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#106816

No description provided.