Fix #100053: Incorrect saving asset catalogs after renaming parent item #107121

Philipp Oeser · 2023-04-19T11:23:27+02:00

Philipp Oeser commented

2023-04-19 11:23:27 +02:00

When a parent item was renamed, the TreeView was doing everything as
expected, however AssetCatalogService::update_catalog_path is supposed
to also update the catalog paths of all sub-catalogs [which it does --
but it does not tag sub-catalogs as having unsaved changes, resulting in
wrong saving of catalogs afterwards, meaning the parent item was saved
with the old name and a new item with the new name was created].

Now also tag sub-catalogs for having unsaved changes.

This should also go into 3.3 LTS

When a parent item was renamed, the `TreeView` was doing everything as expected, however `AssetCatalogService::update_catalog_path` is supposed to also update the catalog paths of all sub-catalogs [which it does -- but it does not tag sub-catalogs as having unsaved changes, resulting in wrong saving of catalogs afterwards, meaning the parent item was saved with the old name and a new item with the new name was created]. Now also tag sub-catalogs for having unsaved changes. This should also go into 3.3 LTS

Philipp Oeser added 1 commit 2023-04-19 11:23:42 +02:00

2b3fd0003d Fix #100053 : Incorrect saving asset catalogs after renaming parent item

When a parent item was renamed, the `TreeView` was doing everything as
expected, however `AssetCatalogService::update_catalog_path` is supposed
to also update the catalog paths of all sub-catalogs [which it does --
but it does not tag sub-catalogs as having unsaved changes, resulting in
wrong saving of catalogs afterwards, meaning the parent item was saved
with the old name and a new item with the new name was created].

Now also tag sub-catalogs for having unsaved changes.

This should also go into 3.3 LTS

Philipp Oeser requested review from Sybren A. Stüvel 2023-04-19 11:23:55 +02:00

Philipp Oeser added this to the Pipeline, Assets & IO project 2023-04-19 11:24:02 +02:00

Philipp Oeser added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #100053: Incorrect saving asset catalogs after renaming parent item #107121