Fix #100053: Incorrect saving asset catalogs after renaming parent item #107121

Merged
Philipp Oeser merged 1 commits from lichtwerk/blender:100053 into main 2023-04-20 11:21:39 +02:00
Member

When a parent item was renamed, the TreeView was doing everything as
expected, however AssetCatalogService::update_catalog_path is supposed
to also update the catalog paths of all sub-catalogs [which it does --
but it does not tag sub-catalogs as having unsaved changes, resulting in
wrong saving of catalogs afterwards, meaning the parent item was saved
with the old name and a new item with the new name was created].

Now also tag sub-catalogs for having unsaved changes.

This should also go into 3.3 LTS

When a parent item was renamed, the `TreeView` was doing everything as expected, however `AssetCatalogService::update_catalog_path` is supposed to also update the catalog paths of all sub-catalogs [which it does -- but it does not tag sub-catalogs as having unsaved changes, resulting in wrong saving of catalogs afterwards, meaning the parent item was saved with the old name and a new item with the new name was created]. Now also tag sub-catalogs for having unsaved changes. This should also go into 3.3 LTS
Philipp Oeser added 1 commit 2023-04-19 11:23:42 +02:00
2b3fd0003d Fix #100053: Incorrect saving asset catalogs after renaming parent item
When a parent item was renamed, the `TreeView` was doing everything as
expected, however `AssetCatalogService::update_catalog_path` is supposed
to also update the catalog paths of all sub-catalogs [which it does --
but it does not tag sub-catalogs as having unsaved changes, resulting in
wrong saving of catalogs afterwards, meaning the parent item was saved
with the old name and a new item with the new name was created].

Now also tag sub-catalogs for having unsaved changes.

This should also go into 3.3 LTS
Philipp Oeser requested review from Sybren A. Stüvel 2023-04-19 11:23:55 +02:00
Philipp Oeser added this to the Pipeline, Assets & IO project 2023-04-19 11:24:02 +02:00
Philipp Oeser added the
Interest
Asset Browser
label 2023-04-19 11:24:08 +02:00
Philipp Oeser requested review from Julian Eisel 2023-04-19 11:24:41 +02:00
Sybren A. Stüvel added the
Module
Pipeline, Assets & IO
label 2023-04-20 11:04:04 +02:00
Sybren A. Stüvel approved these changes 2023-04-20 11:04:15 +02:00
Sybren A. Stüvel left a comment
Member

Good find, thanks!

Good find, thanks!
Philipp Oeser merged commit 100f37af49 into main 2023-04-20 11:21:39 +02:00
Philipp Oeser deleted branch 100053 2023-04-20 11:21:40 +02:00
Bastien Montagne removed this from the Pipeline, Assets & IO project 2023-07-03 13:01:21 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107121
No description provided.