Refactor: Bidirectionality on Graph Editor Sliders #107173
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#107173
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "ChrisLend/blender:fix_slider_range"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Some of the sliders ingraph_slider_ops.c
were not configured correctly after the addition of the bidirectionality to the slider. This also made the overshoot locked on one side.This was fixed with #107406: Refactor: Allow to explicitly set the range on the slider UI element
Now this PR just refactors the factor ranges to be more logical
The following operators have been modified to with a range of -1/1 with the default of 0
Looks good to me!
I will put this on hold until #107406: Refactor: Allow to explicitly set the range on the slider UI element has landed
Fix: Bidirectionality on Graph Editor Slidersto WIP: Fix: Bidirectionality on Graph Editor SlidersWIP: Fix: Bidirectionality on Graph Editor Slidersto Fix: Bidirectionality on Graph Editor Slidersso after this PR #107406: Refactor: Allow to explicitly set the range on the slider UI element
the issue is actually no longer present
not sure what to do with this patch. it's more of a refactor that changes the range to -1/1 for a few operators
Fix: Bidirectionality on Graph Editor Slidersto Refactor: Bidirectionality on Graph Editor SlidersI think it makes sense to merge, since indeed these operators should probably be -1/1 range.
Actually, on second thought (and after talking to @dr.sybren), maybe this should wait until Blender 4.0.
Changing the range of the parameters for these operators is a backwards-incompatible change for the Python API.
Nathan Vegdahl referenced this pull request2023-05-12 12:48:16 +02:00
Marked for Blender 4.0.
no objections to land this in yesterdays A&R meeting
https://devtalk.blender.org/t/2023-06-01-animation-rigging-module-meeting/29693