Refactor: Bidirectionality on Graph Editor Sliders #107173

~~Some of the sliders in graph_slider_ops.c were not configured correctly after the addition of the bidirectionality to the slider. This also made the overshoot locked on one side.~~

This was fixed with #107406: Refactor: Allow to explicitly set the range on the slider UI element
Now this PR just refactors the factor ranges to be more logical

The following operators have been modified to with a range of -1/1 with the default of 0

Blend to Neighbor
Breakdown
Ease

~~Some of the sliders in `graph_slider_ops.c` were not configured correctly after the addition of the bidirectionality to the slider. This also made the overshoot locked on one side.~~ This was fixed with [#107406: Refactor: Allow to explicitly set the range on the slider UI element](https://projects.blender.org/blender/blender/pulls/107406) Now this PR just refactors the factor ranges to be more logical The following operators have been modified to with a range of -1/1 with the default of 0 * Blend to Neighbor * Breakdown * Ease

Looks good to me!

I will put this on hold until #107406: Refactor: Allow to explicitly set the range on the slider UI element has landed

I will put this on hold until [#107406: Refactor: Allow to explicitly set the range on the slider UI element](https://projects.blender.org/blender/blender/pulls/107406) has landed

so after this PR #107406: Refactor: Allow to explicitly set the range on the slider UI element
the issue is actually no longer present

not sure what to do with this patch. it's more of a refactor that changes the range to -1/1 for a few operators

so after this PR [#107406: Refactor: Allow to explicitly set the range on the slider UI element](https://projects.blender.org/blender/blender/pulls/107406) the issue is actually no longer present not sure what to do with this patch. it's more of a refactor that changes the range to -1/1 for a few operators

not sure what to do with this patch. it's more of a refactor that changes the range to -1/1 for a few operators

I think it makes sense to merge, since indeed these operators should probably be -1/1 range.

> not sure what to do with this patch. it's more of a refactor that changes the range to -1/1 for a few operators I think it makes sense to merge, since indeed these operators should probably be -1/1 range.

Actually, on second thought (and after talking to @dr.sybren), maybe this should wait until Blender 4.0.

Changing the range of the parameters for these operators is a backwards-incompatible change for the Python API.

Actually, on second thought (and after talking to @dr.sybren), maybe this should wait until Blender 4.0. Changing the range of the parameters for these operators is a backwards-incompatible change for the Python API.

Marked for Blender 4.0.

no objections to land this in yesterdays A&R meeting
https://devtalk.blender.org/t/2023-06-01-animation-rigging-module-meeting/29693

no objections to land this in yesterdays A&R meeting https://devtalk.blender.org/t/2023-06-01-animation-rigging-module-meeting/29693

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Refactor: Bidirectionality on Graph Editor Sliders #107173

Reviewers