Refactor: Bidirectionality on Graph Editor Sliders #107173

Merged
Christoph Lendenfeld merged 5 commits from ChrisLend/blender:fix_slider_range into main 2023-06-02 12:22:38 +02:00

Some of the sliders in graph_slider_ops.c were not configured correctly after the addition of the bidirectionality to the slider. This also made the overshoot locked on one side.

This was fixed with #107406: Refactor: Allow to explicitly set the range on the slider UI element
Now this PR just refactors the factor ranges to be more logical

The following operators have been modified to with a range of -1/1 with the default of 0

  • Blend to Neighbor
  • Breakdown
  • Ease
~~Some of the sliders in `graph_slider_ops.c` were not configured correctly after the addition of the bidirectionality to the slider. This also made the overshoot locked on one side.~~ This was fixed with [#107406: Refactor: Allow to explicitly set the range on the slider UI element](https://projects.blender.org/blender/blender/pulls/107406) Now this PR just refactors the factor ranges to be more logical The following operators have been modified to with a range of -1/1 with the default of 0 * Blend to Neighbor * Breakdown * Ease
Christoph Lendenfeld added the
Module
Animation & Rigging
label 2023-04-20 15:08:21 +02:00
Christoph Lendenfeld added 1 commit 2023-04-20 15:08:33 +02:00
Christoph Lendenfeld added 1 commit 2023-04-20 15:09:39 +02:00
Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-04-20 15:09:42 +02:00
Christoph Lendenfeld added this to the Animation & Rigging project 2023-04-20 15:09:49 +02:00
Nathan Vegdahl approved these changes 2023-04-25 12:44:22 +02:00
Nathan Vegdahl left a comment
Member

Looks good to me!

Looks good to me!
Christoph Lendenfeld added 1 commit 2023-04-27 11:38:04 +02:00
Author
Member
I will put this on hold until [#107406: Refactor: Allow to explicitly set the range on the slider UI element](https://projects.blender.org/blender/blender/pulls/107406) has landed
Christoph Lendenfeld changed title from Fix: Bidirectionality on Graph Editor Sliders to WIP: Fix: Bidirectionality on Graph Editor Sliders 2023-05-04 12:18:28 +02:00
Christoph Lendenfeld added 2 commits 2023-05-11 10:47:16 +02:00
Christoph Lendenfeld changed title from WIP: Fix: Bidirectionality on Graph Editor Sliders to Fix: Bidirectionality on Graph Editor Sliders 2023-05-11 10:47:33 +02:00
Christoph Lendenfeld requested review from Nathan Vegdahl 2023-05-11 10:47:55 +02:00
Author
Member

so after this PR #107406: Refactor: Allow to explicitly set the range on the slider UI element
the issue is actually no longer present

not sure what to do with this patch. it's more of a refactor that changes the range to -1/1 for a few operators

so after this PR [#107406: Refactor: Allow to explicitly set the range on the slider UI element](https://projects.blender.org/blender/blender/pulls/107406) the issue is actually no longer present not sure what to do with this patch. it's more of a refactor that changes the range to -1/1 for a few operators
Christoph Lendenfeld changed title from Fix: Bidirectionality on Graph Editor Sliders to Refactor: Bidirectionality on Graph Editor Sliders 2023-05-11 10:53:34 +02:00
Member

not sure what to do with this patch. it's more of a refactor that changes the range to -1/1 for a few operators

I think it makes sense to merge, since indeed these operators should probably be -1/1 range.

> not sure what to do with this patch. it's more of a refactor that changes the range to -1/1 for a few operators I think it makes sense to merge, since indeed these operators should probably be -1/1 range.
Nathan Vegdahl approved these changes 2023-05-12 12:40:06 +02:00
Member

Actually, on second thought (and after talking to @dr.sybren), maybe this should wait until Blender 4.0.

Changing the range of the parameters for these operators is a backwards-incompatible change for the Python API.

Actually, on second thought (and after talking to @dr.sybren), maybe this should wait until Blender 4.0. Changing the range of the parameters for these operators is a backwards-incompatible change for the Python API.
Nathan Vegdahl added this to the 4.0 milestone 2023-05-12 12:45:16 +02:00
Member

Marked for Blender 4.0.

Marked for Blender 4.0.
Author
Member

no objections to land this in yesterdays A&R meeting
https://devtalk.blender.org/t/2023-06-01-animation-rigging-module-meeting/29693

no objections to land this in yesterdays A&R meeting https://devtalk.blender.org/t/2023-06-01-animation-rigging-module-meeting/29693
Christoph Lendenfeld merged commit e73b9c95f5 into main 2023-06-02 12:22:38 +02:00
Christoph Lendenfeld deleted branch fix_slider_range 2023-06-02 12:22:39 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107173
No description provided.