I18n: improve geometry nodes field tooltips #107257

Merged

Bastien Montagne merged 1 commits from pioverfour/blender:dp_fix_geo_nodes_field_tooltips into main

2023-04-28 21:37:40 +02:00

Damien Picard commented

2023-04-23 03:40:53 +02:00

Member

Node socket tooltips suffered from several issues.

Some could not be translated because they were not properly
extracted, so extraction macros were added.
Some were extracted but included newlines at the end, which did not
get translated, such as ss << TIP_("Geometry:\n"), changed to
ss << TIP_("Geometry:") << "\n".
Some translations were not functional, such as:
TIP_(attributes_num == 1 ? " Named Attribute" : " Named Attributes");
because TIP_() needs to be around a single string.
Some extraction macros had no effect and were removed, such as:
.description(N_(leading_out_description));
This is a no-op macro which can be used only around a string literal.

I started working on this in D15996 but @hooglyboogly had reservations about it. I removed the questionable bit and will submit it in a separate PR.

Node socket tooltips suffered from several issues. - Some could not be translated because they were not properly extracted, so extraction macros were added. - Some were extracted but included newlines at the end, which did not get translated, such as `ss << TIP_("Geometry:\n")`, changed to `ss << TIP_("Geometry:") << "\n"`. - Some translations were not functional, such as: `TIP_(attributes_num == 1 ? " Named Attribute" : " Named Attributes");` because `TIP_()` needs to be around a single string. - Some extraction macros had no effect and were removed, such as: `.description(N_(leading_out_description));` This is a no-op macro which can be used only around a string literal. ----- I started working on this in [D15996](https://archive.blender.org/developer/differential/0015/0015996/) but @hooglyboogly had reservations about it. I removed the questionable bit and will submit it in a separate PR.

Damien Picard added the

Nodes & Physics

labels 2023-04-23 03:40:53 +02:00

Damien Picard requested review from Bastien Montagne 2023-04-23 03:41:28 +02:00

Damien Picard force-pushed dp_fix_geo_nodes_field_tooltips from 2d3d5a78ba to 05b22feaaa

2023-04-24 21:18:56 +02:00

Compare

Damien Picard force-pushed dp_fix_geo_nodes_field_tooltips from 05b22feaaa to cb1e8d78e4

2023-04-24 22:12:06 +02:00

Compare

Damien Picard force-pushed dp_fix_geo_nodes_field_tooltips from cb1e8d78e4 to fc6fc8edb0

2023-04-25 15:34:47 +02:00

Compare

Bastien Montagne approved these changes 2023-04-28 19:32:24 +02:00

Bastien Montagne left a comment

Owner

LGTM

LGTM

Bastien Montagne commented

2023-04-28 19:32:41 +02:00

Owner

@blender-bot build

@blender-bot build

Bastien Montagne commented

2023-04-28 19:53:22 +02:00

Owner

@blender-bot build

@blender-bot build

Bastien Montagne referenced this issue from a commit

2023-04-28 21:37:38 +02:00

I18n: improve geometry nodes field tooltips

Bastien Montagne merged commit 44103f5529 into main

2023-04-28 21:37:40 +02:00

Bastien Montagne deleted branch dp_fix_geo_nodes_field_tooltips

2023-04-28 21:37:41 +02:00

Colin Basnett referenced this issue from a commit

2023-05-02 02:35:28 +02:00

I18n: improve geometry nodes field tooltips

Howard Trickey referenced this issue from a commit

2023-05-29 02:51:43 +02:00

Merge in orign/main:

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#107257

No description provided.