Fix #97530: Overlapping Content Causing Region Scrolling #107404

Harley Acheson · 2023-04-27T17:45:53+02:00

Harley Acheson commented

2023-04-27 17:45:53 +02:00

Selecting filter in NLA/Graph Editor causes scrolling in the region
below it. This PR makes UI_but_ensure_in_view not occur if the block
has UI_BLOCK_CLIP_EVENTS.

This has been a long-standing complaint from the Animation Module. Clicking on the filter causes the list to move:

The block containing the filter overlaps the lists below it, and so sets UI_BLOCK_CLIP_EVENTS so that events on it don't reach the region underneath. But it is still the active region when we click in it, so in ui_textedit_begin we call UI_but_ensure_in_view to try to scroll the region to ensure it is visible. That causes the shift. There is no reason to call UI_but_ensure_in_view for blocks with this flag set so this PR just adds a check for that.

Selecting filter in NLA/Graph Editor causes scrolling in the region below it. This PR makes `UI_but_ensure_in_view` not occur if the block has UI_BLOCK_CLIP_EVENTS. --- This has been a long-standing complaint from the Animation Module. Clicking on the filter causes the list to move: ![FilterScroll.gif](/attachments/a3e6eb45-c3c8-4c09-8154-3cdcb081eb24) The block containing the filter overlaps the lists below it, and so sets UI_BLOCK_CLIP_EVENTS so that events on it don't reach the region underneath. But it is still the active region when we click in it, so in `ui_textedit_begin` we call `UI_but_ensure_in_view` to try to scroll the region to ensure it is visible. That causes the shift. There is no reason to call `UI_but_ensure_in_view` for blocks with this flag set so this PR just adds a check for that.

FilterScroll.gif

158 KiB

Harley Acheson added 1 commit 2023-04-27 17:46:02 +02:00

918490099a Fix #97530 : Overlapping Content Causing Region Scrolling

Selecting filter in NLA/Graph Editor causes scrolling in the region
below it. This PR makes `UI_but_ensure_in_view` not occur if the block
has UI_BLOCK_CLIP_EVENTS.

Harley Acheson added this to the User Interface project 2023-04-27 17:46:21 +02:00

Harley Acheson requested review from Campbell Barton 2023-04-27 17:46:40 +02:00

Campbell Barton approved these changes 2023-04-28 05:09:56 +02:00

Harley Acheson added 1 commit 2023-04-28 17:14:36 +02:00