blender
/
blender
133
398
Fork 578
Code Issues 6.3k Pull Requests 744 Projects 19 Wiki Activity

WM: don't skip AutoSave if modal operator is 'fileselect' #107555

Open
Germano Cavalcante wants to merge 1 commits from mano-wii/blender:autosave_relax into main
pull from: mano-wii/blender:autosave_relax
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 1 Commits 1 Files Changed 1 +7 -1

1 Commits

Author SHA1 Message Date
Germano Cavalcante 1979bd6902 WM: don't skip AutoSave if modal operator is 'fileselect' 
AutoSave is skipped if we have a file select handle open.

But a user could inadvertently minimize the window from that handle,
causing AutoSave to no longer work.

So skip this case of skipping AutoSave.

---
That's a shot in the dark.

Commit cb8f7fd385 implemented the following behavior for AutoSave:
- Autosave is postponed by 10 seconds when a modal operator is running, e.g. transform or file browsing.

But it's not clear why or which state is not safe for AutoSave.

Those conditions that skip AutoSave could be causing inconveniences that are hard to track down. It is possible for example that it is the cause commented on #107421 (comment)

That's why this PR proposes to be a little less strict for cases of skipping  AutoSave.
 2023-05-02 12:48:34 -03:00