UI: Display invalid cache as striped lines in the timeline #108481

Merged
Jacques Lucke merged 6 commits from lone_noel/blender:timeline-invalid-cache-stripes into blender-v4.0-release 2023-10-06 13:12:27 +02:00
Member

Unify the way the different state's of a cache are shown in the
timeline:

  • Baked: fully opaque
  • Cached: slightly transparent
  • Invalid cache: slightly transparent, dark diagonal stripes

This improves accessibility since patterns are easier to recognize
for colorblind or otherwise visually impaired people.

The slight transparency is done with an alpha of 0.7 and the diagonal
stripes use the cache's color at 50% value.

Implements #108196


Comparison
Different states of the cache for Cloth, Dynamic Paint, Simulation Nodes, and Soft Body. I also added a screenshot of a light theme to illustrate that the hardcoded colors still work.

baked caches
current
pull request
pull request - light
valid caches (and one baked simulation zone)
current
pull request
pull request - light
invalid caches (and one baked simulation zone)
current
pull request
pull request - light
Unify the way the different state's of a cache are shown in the timeline: * Baked: fully opaque * Cached: slightly transparent * Invalid cache: slightly transparent, dark diagonal stripes This improves accessibility since patterns are easier to recognize for colorblind or otherwise visually impaired people. The slight transparency is done with an alpha of 0.7 and the diagonal stripes use the cache's color at 50% value. Implements https://projects.blender.org/blender/blender/issues/108196 --- **Comparison** Different states of the cache for Cloth, Dynamic Paint, Simulation Nodes, and Soft Body. I also added a screenshot of a light theme to illustrate that the hardcoded colors still work. ||baked caches| |---|---| |**current**|![](https://projects.blender.org/attachments/9208276b-790f-4031-95c4-51b3088934ef)| |**pull request**|![](https://projects.blender.org/attachments/ec82acee-83a4-466c-a02b-0fa3d99e54d5)| |**pull request - light**|![](https://projects.blender.org/attachments/51982464-2758-490b-b5a9-0e490581313a)| ||valid caches (and one baked simulation zone) | |---|---| |**current**|![](https://projects.blender.org/attachments/c99cc03c-e20f-43c6-862c-00fd0cc969cf)| |**pull request**|![](https://projects.blender.org/attachments/250d95d6-5f3c-4bfc-bf51-13cc71ff8385)| |**pull request - light**|![](https://projects.blender.org/attachments/8957e318-d763-441d-9afc-408b7f922764)| ||invalid caches (and one baked simulation zone)| |---|---| |**current**|![](https://projects.blender.org/attachments/40f89b55-f941-4746-800c-97de635f31ff)| |**pull request**|![](https://projects.blender.org/attachments/a8e8d054-a998-4457-b48c-4d7effe3be17)| |**pull request - light**|![](https://projects.blender.org/attachments/ab4d1281-5c74-459f-8839-661d66f6726c)|
Leon Schittek added this to the User Interface project 2023-05-31 21:42:02 +02:00
Hans Goudey requested review from Dalai Felinto 2023-05-31 22:01:20 +02:00

I know changing the alpha was based on @pablovazquez 's feedback, but the color is a bit too punchy in my opinion. I wll check with Pablo what he thinks. It may be easier for him to play with the values locally and get back to you.

I know changing the alpha was based on @pablovazquez 's feedback, but the color is a bit too punchy in my opinion. I wll check with Pablo what he thinks. It may be easier for him to play with the values locally and get back to you.
Dalai Felinto requested review from Pablo Vazquez 2023-06-01 10:21:28 +02:00
Dalai Felinto added this to the 4.0 milestone 2023-06-12 15:34:48 +02:00
Member

I know changing the alpha was based on @pablovazquez 's feedback, but the color is a bit too punchy in my opinion.

Since the colors weren't necessarily changed in this patch (only opacity), I think it'd be best to push this mainly for the striped lines, and move the color change to another PR as part of theme tweaks.

> I know changing the alpha was based on @pablovazquez 's feedback, but the color is a bit too punchy in my opinion. Since the colors weren't necessarily changed in this patch (only opacity), I think it'd be best to push this mainly for the striped lines, and move the color change to another PR as part of theme tweaks.
Author
Member

To tone down the cache colors I decided to mix in the background color. This has a similar effect to the transparency before and makes the hardcoded colors a bit more theme agnostic.

state screenshot
baked caches tweak-baked.png
valid caches tweak-cached.png
invalid caches tweak-cached-invalid.png

The color for the dynamic paint cache is very similar to the current color for the geometry nodes cache but that was the case before and we could still tweak that further with the theme adjustments like Pablo mentioned.

To tone down the cache colors I decided to mix in the background color. This has a similar effect to the transparency before and makes the hardcoded colors a bit more theme agnostic. |state|screenshot| |---|---| |baked caches|![tweak-baked.png](/attachments/a47b59bd-7ed8-4ec2-b01b-0bf92ffc964e)| |valid caches|![tweak-cached.png](/attachments/ed9d26a3-0ebb-46d5-b6d2-46a7551bd647)| |invalid caches|![tweak-cached-invalid.png](/attachments/577a28b5-94d2-4de8-8def-44fcf743260f)| The color for the dynamic paint cache is very similar to the current color for the geometry nodes cache but that was the case before and we could still tweak that further with the theme adjustments like Pablo mentioned.
Member

Great! Much nicer. Indeed Dynamic Paint and Simulation are pretty close, will have to tweak that as a separate patch.

Great! Much nicer. Indeed Dynamic Paint and Simulation are pretty close, will have to tweak that as a separate patch.
Pablo Vazquez approved these changes 2023-09-27 12:53:19 +02:00
Leon Schittek force-pushed timeline-invalid-cache-stripes from 614a18ee62 to b7bd3f47b2 2023-10-05 12:15:36 +02:00 Compare
Leon Schittek changed title from UI: Display invalid cache as striped lines in the timeline to UI: Display invalid cache as striped lines in the timeline 2023-10-05 12:16:26 +02:00
lone_noel changed target branch from main to blender-v4.0-release 2023-10-05 12:16:28 +02:00
Jacques Lucke approved these changes 2023-10-06 13:03:46 +02:00
Jacques Lucke left a comment
Member

Very nice, looks good to me.

Very nice, looks good to me.
Dalai Felinto approved these changes 2023-10-06 13:05:21 +02:00
Jacques Lucke merged commit 8d15783a7e into blender-v4.0-release 2023-10-06 13:12:27 +02:00
Leon Schittek deleted branch timeline-invalid-cache-stripes 2023-10-06 13:44:40 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108481
No description provided.