blender
/
blender
77
265
Fork 362
Code Issues 6.0k Pull Requests 540 Projects 19 Wiki Activity

UI: Display invalid cache as striped lines in the timeline #108481

Open
Leon Schittek wants to merge 4 commits from lone_noel/blender:timeline-invalid-cache-stripes into main
pull from: lone_noel/blender:timeline-invalid-cache-stripes
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 4 Commits 4 Files Changed 1
Leon Schittek commented 2023-05-31 21:41:15 +02:00
Collaborator

Unify the way the different state's of a cache are shown in the
timeline:

  • Baked: fully opaque
  • Cached: slightly transparent
  • Invalid cache: slightly transparent, dark diagonal stripes

This improves accessibility since patterns are easier to recognize
for colorblind or otherwise visually impaired people.

The slight transparency is done with an alpha of 0.7 and the diagonal
stripes use the cache's color at 50% value.

Implements #108196

Comparison
Different states of the cache for Cloth, Dynamic Paint, Simulation Nodes, and Soft Body:

baked caches
main
pull request
valid caches
main
pull request
invalid caches
main
pull request
Unify the way the different state's of a cache are shown in the timeline: * Baked: fully opaque * Cached: slightly transparent * Invalid cache: slightly transparent, dark diagonal stripes This improves accessibility since patterns are easier to recognize for colorblind or otherwise visually impaired people. The slight transparency is done with an alpha of 0.7 and the diagonal stripes use the cache's color at 50% value. Implements https://projects.blender.org/blender/blender/issues/108196 --- **Comparison** Different states of the cache for Cloth, Dynamic Paint, Simulation Nodes, and Soft Body: ||**baked caches**| |---|---| |**main**|![](https://projects.blender.org/attachments/096bb7b0-d7be-4abf-89e8-c47fbf96a9d9)| |**pull request**|![](https://projects.blender.org/attachments/e6e8f989-5c30-4eb7-b726-cb3affd1a0f7)| ||valid caches| |---|---| |**main**|![](https://projects.blender.org/attachments/49ba82c6-57db-41a5-9756-0547538499dd)| |**pull request**|![](https://projects.blender.org/attachments/3c717173-20bd-4802-a021-66364142238f)| ||**invalid caches**| |---|---| |**main**|![](https://projects.blender.org/attachments/904f126b-7844-4433-bebf-9dbbdf816c0c)| |**pull request**|![](https://projects.blender.org/attachments/028399fa-175e-4764-82fe-cc4e3ffe2dba)|
simulation-cache-invalid_main.png
35 KiB
simulation-cache-all-baked_main.png
35 KiB
simulation-cache-all-baked_patch.png
35 KiB
simulation-cache-invalid_patch.png
37 KiB
simulation-cache-valid_patch.png
35 KiB
simulation-cache-valid_main.png
35 KiB
Leon Schittek added 1 commit 2023-05-31 21:41:26 +02:00
3963415329 UI: Display invalid cache as striped lines in the timeline 
Unify the way the different state's of a cache are shown in the
timeline:

* Baked: fully opaque
* Cached: slightly transparent
* Invalid cache: slightly transparent, dark diagonal stripes

This improves accessibility since patterns are easier to recognize
for colorblind or otherwise visually impaired people.

The slight transparency is done with an alpha of 0.7 and the diagonal
stripes use the cache's color at 50% value.

Implements #108196
Leon Schittek added this to the User Interface project 2023-05-31 21:42:02 +02:00
Hans Goudey requested review from Dalai Felinto 2023-05-31 22:01:20 +02:00
Dalai Felinto commented 2023-06-01 10:20:48 +02:00
Owner

I know changing the alpha was based on @pablovazquez 's feedback, but the color is a bit too punchy in my opinion. I wll check with Pablo what he thinks. It may be easier for him to play with the values locally and get back to you.

I know changing the alpha was based on @pablovazquez 's feedback, but the color is a bit too punchy in my opinion. I wll check with Pablo what he thinks. It may be easier for him to play with the values locally and get back to you.
👍 3
Dalai Felinto requested review from Pablo Vazquez 2023-06-01 10:21:28 +02:00
Dalai Felinto added this to the 4.0 milestone 2023-06-12 15:34:48 +02:00
Pablo Vazquez commented 2023-09-23 13:06:09 +02:00
Collaborator

I know changing the alpha was based on @pablovazquez 's feedback, but the color is a bit too punchy in my opinion.

Since the colors weren't necessarily changed in this patch (only opacity), I think it'd be best to push this mainly for the striped lines, and move the color change to another PR as part of theme tweaks.

> I know changing the alpha was based on @pablovazquez 's feedback, but the color is a bit too punchy in my opinion. Since the colors weren't necessarily changed in this patch (only opacity), I think it'd be best to push this mainly for the striped lines, and move the color change to another PR as part of theme tweaks.
Leon Schittek added 1 commit 2023-09-25 23:43:48 +02:00
Leon Schittek added 2 commits 2023-09-27 10:42:10 +02:00
Leon Schittek commented 2023-09-27 10:49:34 +02:00
Poster
Collaborator

To tone down the cache colors I decided to mix in the background color. This has a similar effect to the transparency before and makes the hardcoded colors a bit more theme agnostic.

state screenshot
baked caches tweak-baked.png
valid caches tweak-cached.png
invalid caches tweak-cached-invalid.png

The color for the dynamic paint cache is very similar to the current color for the geometry nodes cache but that was the case before and we could still tweak that further with the theme adjustments like Pablo mentioned.

To tone down the cache colors I decided to mix in the background color. This has a similar effect to the transparency before and makes the hardcoded colors a bit more theme agnostic. |state|screenshot| |---|---| |baked caches|![tweak-baked.png](/attachments/a47b59bd-7ed8-4ec2-b01b-0bf92ffc964e)| |valid caches|![tweak-cached.png](/attachments/ed9d26a3-0ebb-46d5-b6d2-46a7551bd647)| |invalid caches|![tweak-cached-invalid.png](/attachments/577a28b5-94d2-4de8-8def-44fcf743260f)| The color for the dynamic paint cache is very similar to the current color for the geometry nodes cache but that was the case before and we could still tweak that further with the theme adjustments like Pablo mentioned.
tweak-cached.png
29 KiB
tweak-baked.png
29 KiB
tweak-cached-invalid.png
31 KiB
👍 1
Pablo Vazquez commented 2023-09-27 12:53:09 +02:00
Collaborator

Great! Much nicer. Indeed Dynamic Paint and Simulation are pretty close, will have to tweak that as a separate patch.

Great! Much nicer. Indeed Dynamic Paint and Simulation are pretty close, will have to tweak that as a separate patch.
Pablo Vazquez approved these changes 2023-09-27 12:53:19 +02:00

Reviewers

Dalai Felinto was requested for review 2023-05-31 22:01:20 +02:00
Pablo Vazquez approved these changes 2023-09-27 12:53:19 +02:00
This pull request has changes conflicting with the target branch.
  • source/blender/editors/space_action/action_draw.cc
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Dalai Felinto
Pablo Vazquez
Labels
Apply labels
Clear labels   
Interest
Alembic
   
Interest
Animation & Rigging
   
Interest
Asset Browser
   
Interest
Asset Browser Project Overview
   
Interest
Audio
   
Interest
Automated Testing
   
Interest
Blender Asset Bundle
   
Interest
BlendFile
   
Interest
Collada
   
Interest
Compatibility
This issue affects/is about backward or forward compatibility   
Interest
Compositing
   
Interest
Core
   
Interest
Cycles
   
Interest
Dependency Graph
   
Interest
Development Management
   
Interest
EEVEE & Viewport
   
Interest
Freestyle
   
Interest
Geometry Nodes
   
Interest
Grease Pencil
   
Interest
ID Management
   
Interest
Images & Movies
   
Interest
Import Export
   
Interest
Line Art
   
Interest
Masking
   
Interest
Metal
   
Interest
Modeling
   
Interest
Modifiers
   
Interest
Motion Tracking
   
Interest
Nodes & Physics
   
Interest
OpenGL
   
Interest
Overrides
   
Interest
Performance
   
Interest
Physics
   
Interest
Pipeline, Assets & IO
   
Interest
Platforms, Builds & Tests
   
Interest
Python API
   
Interest
Render & Cycles
   
Interest
Render Pipeline
   
Interest
Sculpt, Paint & Texture
   
Interest
Text Editor
   
Interest
Translations
   
Interest
Triaging
   
Interest
Undo
   
Interest
USD
   
Interest
User Interface
   
Interest
UV Editing
   
Interest
VFX & Video
   
Interest
Video Sequencer
   
Interest
Virtual Reality
   
Interest
Vulkan
  
Interest: Wayland
  
Legacy
Blender 2.8 Project
   
Legacy
Milestone 1: Basic, Local Asset Browser
   
Legacy
OpenGL Error
  
Meta
Good First Issue
   
Meta
Papercut
   
Meta
Retrospective
   
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
  
Module
Animation & Rigging
   
Module
Core
   
Module
Development Management
   
Module
EEVEE & Viewport
   
Module
Grease Pencil
   
Module
Modeling
   
Module
Nodes & Physics
   
Module
Pipeline, Assets & IO
   
Module
Platforms, Builds & Tests
   
Module
Python API
   
Module
Render & Cycles
   
Module
Sculpt, Paint & Texture
   
Module
Triaging
   
Module
User Interface
   
Module
VFX & Video
  
Platform
FreeBSD
   
Platform
Linux
   
Platform
macOS
   
Platform
Windows
  
Priority
High
   
Priority
Low
   
Priority
Normal
   
Priority
Unbreak Now!
  
Status
Archived
   
Status
Confirmed
   
Status
Duplicate
   
Status
Needs Info from Developers
   
Status
Needs Information from User
   
Status
Needs Triage
   
Status
Resolved
  
Type
Bug
   
Type
Design
   
Type
Known Issue
   
Type
Patch
   
Type
Report
   
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
4.0
Projects
Set Project
Clear projects
No project
User Interface
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108481
There is no content yet.
Delete Branch "lone_noel/blender:timeline-invalid-cache-stripes"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?