blender
/
blender
131
398
Fork 577
Code Issues 6.2k Pull Requests 743 Projects 19 Wiki Activity

Fix #108573: Remove GP eraser pen pressure conditional #108579

Open
henryb wants to merge 2 commits from henryb/blender:fix-gp-eraser-pen-pressure into main
pull from: henryb/blender:fix-gp-eraser-pen-pressure
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 12 Commits 2 Files Changed 1 -12
henryb commented 2023-06-04 19:28:01 +02:00
First-time contributor
Copy Link

Removes a conditional hack (initially added by 74f291cdea)
that interfered with Grease Pencil eraser pen pressure,
as the intended behavior of 74f291cdea is no longer applicable.

Removes a conditional hack (initially added by 74f291cdea979) that interfered with Grease Pencil eraser pen pressure, as the intended behavior of 74f291cdea979 is no longer applicable.
henryb added 1 commit 2023-06-04 19:28:10 +02:00
fc71e3962a Fix #108573: Remove GP eraser pen pressure conditional 
Removes a conditional hack (initially added by 74f291cdea)
that interfered with Grease Pencil eraser pen pressure,
as the intended behavior of 74f291cdea is no longer applicable.
Blender Bot commented 2023-06-04 19:29:06 +02:00
Member
Copy Link

Only blender organization members with write access can start builds. See documentation for details.

Only blender organization members with write access can start builds. See [documentation](https://projects.blender.org/infrastructure/blender-bot/src/branch/main/README.md) for details.
henryb commented 2023-06-04 19:38:15 +02:00
Author
First-time contributor
Copy Link

... the intended behavior of 74f291cdea is no longer applicable.

If there is evidence to the contrary, please reply here or on #108573

> ... the intended behavior of 74f291cdea979 is no longer applicable. If there is evidence to the contrary, please reply here or on #108573
Iliya Katushenock added the
Interest
Grease Pencil
Interest
User Interface
 labels 2023-06-04 19:52:07 +02:00
Pratik Borhade commented 2023-06-08 06:57:14 +02:00
Member
Copy Link

@antoniov , can you check?

@antoniov , can you check?
Antonio Vazquez commented 2023-06-08 12:59:48 +02:00
Member
Copy Link

@mendio @pepe-school-land Could you check if the pressure in eraser is working with this patch. This change removes an old hack, but we need artist feedback to be sure the "feeling" of the eraser is right.

@PratikPB2123 the code change looks good, but I would like to hear artist before merge the PR.

@mendio @pepe-school-land Could you check if the pressure in eraser is working with this patch. This change removes an old hack, but we need artist feedback to be sure the "feeling" of the eraser is right. @PratikPB2123 the code change looks good, but I would like to hear artist before merge the PR.
👍 1
henryb commented 2023-06-15 05:43:42 +02:00
Author
First-time contributor
Copy Link

Pressure curves and pen feeling should not be affected at all, as this hack only activated in cases where the pen is not touching the surface of the tablet.

If everything looks good, I would be very happy to get this resolved before the June 21 deadline for 3.6 LTS bugfixes so that we can patch this in blender-v3.6-release as well.

Pressure curves and pen feeling should not be affected at all, as this hack only activated in cases where the pen is not touching the surface of the tablet. If everything looks good, I would be very happy to get this resolved before the June 21 deadline for 3.6 LTS bugfixes so that we can patch this in `blender-v3.6-release` as well.
Antonio Vazquez commented 2023-06-15 16:09:17 +02:00
Member
Copy Link

@PratikPB2123 you decide if merge or not. If the result of the test is correct, I agree to merge.

@PratikPB2123 you decide if merge or not. If the result of the test is correct, I agree to merge.
Pratik Borhade commented 2023-06-16 07:48:55 +02:00
Member
Copy Link

@antoniov , I don't have hardware to test the fix. Need confirmation before merging.
BTW, no response from artists? Maybe bring this during module meeting?

@antoniov , I don't have hardware to test the fix. Need confirmation before merging. BTW, no response from artists? Maybe bring this during module meeting?
henryb added 1 commit 2024-02-10 00:39:17 +01:00
Pratik Borhade commented 2024-02-12 12:21:54 +01:00
Member
Copy Link

@mendio @JulienKaspar hi, can you test this PR locally on tablet?

@mendio @JulienKaspar hi, can you test this PR locally on tablet?
Julien Kaspar commented 2024-02-13 11:49:26 +01:00
Member
Copy Link

I'm testing the PR and having a hard time understanding what it fixes. I cannot reproduce the referenced bug report both with the PR and in main. Although I do remember the bug and had difficulties with it in the past.
So it at least all works as expected.

I'm testing the PR and having a hard time understanding what it fixes. I cannot reproduce the referenced bug report both with the PR and in main. Although I do remember the bug and had difficulties with it in the past. So it at least all works as expected.
Pratik Borhade commented 2024-02-14 05:12:59 +01:00
Member
Copy Link

Possibly resolved already. @henryb , can you check in current main?: https://builder.blender.org/download/daily/

Possibly resolved already. @henryb , can you check in current main?: https://builder.blender.org/download/daily/
henryb commented 2024-02-29 20:29:01 +01:00
Author
First-time contributor
Copy Link

@PratikPB2123
I can still reproduce this issue on the latest daily build of main (4.2.0 Alpha, 860f3ed794)

If testing — be sure to use the .blend file attached on the original ticket (#108573) which is configured to use the Eraser Point preset and a large radius so that the issue is obvious.
— Press lightly (to erase only a small area around your pen) before slowly lifting the pen.
If the tablet sends a pressure value below 0.001f as you lift the pen, it will trigger the issue, erasing the maximum area possible.

Be aware that not all tablets necessarily send events with a pressure below 0.001f when the pen is lifted, and will be unable to trigger the issue as a result.

However, I can consistently reproduce the issue with every HUION tablet that I have used:

  • HUION H610PRO
  • HUION Q11K
  • HUION Kamvas 13

They all produce an EVT_TABLET_STYLUS event with a pressure of 0f nearly every time I lift the pen, triggering the issue.

@PratikPB2123 I can still reproduce this issue on the latest daily build of `main` (4.2.0 Alpha, 860f3ed79439) <video height="200" src="/attachments/68cb24f2-ecc5-44ac-b3ae-be7d82f7fa41" title="pen_pressure_release_bug_2024_02_29.mp4" controls></video> If testing — be sure to use the .blend file attached on the original ticket (#108573) which is configured to use the _Eraser Point_ preset and a large radius so that the issue is obvious. — Press lightly (to erase only a small area around your pen) before slowly lifting the pen. If the tablet sends a pressure value below `0.001f` as you lift the pen, _it will trigger the issue_, erasing the maximum area possible. **Be aware** that _not all tablets_ necessarily send events with a pressure below `0.001f` when the pen is lifted, and will be unable to trigger the issue as a result. However, I can consistently reproduce the issue with every HUION tablet that I have used: - HUION H610PRO - HUION Q11K - HUION Kamvas 13 They all produce an `EVT_TABLET_STYLUS` event with a pressure of `0f` nearly every time I lift the pen, triggering the issue.
bug-2024-02-29.mp4
237 KiB
Pratik Borhade commented 2024-03-01 03:50:12 +01:00
Member
Copy Link

Thanks. Guess we don't have similar hardware to check. @antoniov , can you ask about this in next GP module meeting?

Thanks. Guess we don't have similar hardware to check. @antoniov , can you ask about this in next GP module meeting?
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-gp-eraser-pen-pressure:henryb-fix-gp-eraser-pen-pressure
git checkout henryb-fix-gp-eraser-pen-pressure
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108579
No description provided.
Delete Branch "henryb/blender:fix-gp-eraser-pen-pressure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?