blender/blender
165
519
Fork 792
Code Issues 6.8k Pull Requests 950 Projects 21 Wiki Activity

Fix #108527: Fixing Vertex Group operators to default back to Active Vertex Group #108902

Merged
Nate Rupsis merged 2 commits from nrupsis/blender:108527-vertex-group-fix into blender-v3.6-release 2023-06-15 15:36:06 +02:00
Conversation 9 Commits 2 Files Changed 1 +7 -7
Nate Rupsis commented 2023-06-12 17:04:23 +02:00
Member
Copy Link

Reverting changes made in D14961 to default to Deform Bone for objects with armatures. Instead create explicit method to pass default subset.

Reverting changes made in [D14961](https://archive.blender.org/developer/D14961) to default to `Deform Bone` for objects with armatures. Instead create explicit method to pass default subset.
🚀 1
Nate Rupsis added the
Module
Animation & Rigging
 label 2023-06-12 17:04:23 +02:00
Nate Rupsis added this to the Module: Animation & Rigging project 2023-06-12 17:04:47 +02:00
Nate Rupsis requested review from Daniel Salazar 2023-06-12 17:04:57 +02:00
Nate Rupsis requested review from Sybren A. Stüvel 2023-06-12 17:05:05 +02:00
Nate Rupsis commented 2023-06-12 18:34:07 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-06-12 18:34:11 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR108902) when ready.
Daniel Salazar commented 2023-06-13 09:10:45 +02:00
Member
Copy Link

The only problem I find is when you use Normalize All on a mesh that has no mesh-armature relationship you get this:

image

As well as Error: No vertex groups to operate on

To test this, add a couple of vgroups to a cube and run Normalize All.

In this case the correct option should be All Groups

image

The only problem I find is when you use _Normalize All_ on a mesh that has no mesh-armature relationship you get this: ![image](/attachments/42103083-ab78-41dc-9e4c-1cc6c8961f56) As well as _Error: No vertex groups to operate on_ To test this, add a couple of vgroups to a cube and run _Normalize All_. In this case the correct option should be _All Groups_ ![image](/attachments/4016974f-dca6-45ff-9dcf-8378646bdce6)
image.png
7.2 KiB
image.png
7.9 KiB
Sybren A. Stüvel commented 2023-06-13 10:38:08 +02:00
Member
Copy Link

The only problem I find is when you use Normalize All on a mesh that has no mesh-armature relationship you get this:

@zanqdo feel free to press the big red 'Request Changes' button. Unfortunately to do that you have to go to the 'Files' tab, then press the 'Review' button, and then type your comment there.

> The only problem I find is when you use Normalize All on a mesh that has no mesh-armature relationship you get this: @zanqdo feel free to press the big red 'Request Changes' button. Unfortunately to do that you have to go to the 'Files' tab, then press the 'Review' button, and then type your comment there.
Daniel Salazar commented 2023-06-14 01:07:31 +02:00
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-06-14 01:07:34 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR108902) when ready.
Daniel Salazar approved these changes 2023-06-14 02:25:33 +02:00
Daniel Salazar left a comment
Member
Copy Link

LGTM! Thank you 🧡

LGTM! Thank you 🧡
❤️ 1
Nate Rupsis force-pushed 108527-vertex-group-fix from c0c713f0e4 to 75065e5b2f 2023-06-14 03:38:56 +02:00 Compare
Nate Rupsis changed title from Fix #108527: Fixing Vertex Group operators to default back to Active Vertex Group to Fix #108527: Fixing Vertex Group operators to default back to Active Vertex Group 2023-06-14 03:39:11 +02:00
Nate Rupsis changed target branch from main to blender-v3.6-release 2023-06-14 03:39:13 +02:00
Nate Rupsis added this to the 3.6 LTS milestone 2023-06-14 03:39:21 +02:00
Nate Rupsis commented 2023-06-14 03:40:29 +02:00
Author
Member
Copy Link

Targeting 3.6 as discussed in today's module meeting

Targeting 3.6 as discussed in [today's module meeting](https://devtalk.blender.org/t/2023-06-13-animation-rigging-module-meeting/29855#patch-review-decision-time-6)
Sybren A. Stüvel approved these changes 2023-06-15 11:25:42 +02:00
Sybren A. Stüvel left a comment
Member
Copy Link

Code LGTM, just one note about a comment that can be handled when landing the PR.

Code LGTM, just one note about a comment that can be handled when landing the PR.
source/blender/editors/object/object_vgroup.cc Outdated
@ -2908,2 +2902,4 @@
{
Object *ob = ED_object_context(C);
/* A bit of a hack to set the default group subset. If armature is present, default to `Deform
Sybren A. Stüvel commented 2023-06-15 11:25:27 +02:00
Member
Copy Link

Why is this 'a bit of a hack'? Either add the explanation in the comment, so that someone who stumbles upon this knows a bit more of the issue at hand, or just remove the sentence.

Why is this 'a bit of a hack'? Either add the explanation in the comment, so that someone who stumbles upon this knows a bit more of the issue at hand, or just remove the sentence.
Nate Rupsis added 1 commit 2023-06-15 15:34:03 +02:00
Nate Rupsis merged commit f78aa6c034 into blender-v3.6-release 2023-06-15 15:36:06 +02:00
Nate Rupsis deleted branch 108527-vertex-group-fix 2023-06-15 15:36:10 +02:00
Pratik Borhade commented 2023-09-15 13:47:17 +02:00
Member
Copy Link

The only problem I find is when you use Normalize All on a mesh that has no mesh-armature relationship you get this:

@zanqdo feel free to press the big red 'Request Changes' button. Unfortunately to do that you have to go to the 'Files' tab, then press the 'Review' button, and then type your comment there.

We now have a bug report for similar problem: #110946

> > The only problem I find is when you use Normalize All on a mesh that has no mesh-armature relationship you get this: > > @zanqdo feel free to press the big red 'Request Changes' button. Unfortunately to do that you have to go to the 'Files' tab, then press the 'Review' button, and then type your comment there. > We now have a bug report for similar problem: https://projects.blender.org/blender/blender/issues/110946
Philipp Oeser commented 2023-09-15 14:48:16 +02:00
Member
Copy Link

Probably a bit OT, but I wonder if we should not inherit the last choice (at least not All Groups) when calling an operator for a specific vertex group from the list in the Properties Editor, see #112171

Probably a bit OT, but I wonder if we should not inherit the last choice (at least not `All Groups`) when calling an operator for a specific vertex group from the list in the Properties Editor, see #112171
Sign in to join this conversation.
Reviewers
No reviewers
Daniel Salazar
Sybren A. Stüvel
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Asset System
Asset datablocks, libraries, browser and shelf

  
Module
Asset System

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
3.6 LTS
Projects
Clear projects
No project
Module: Animation & Rigging
Assignees
Clear assignees
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#108902
No description provided.
Delete Branch "nrupsis/blender:108527-vertex-group-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?