VSE: Changes to strip title and preview drawing #109472

ok what · 2023-06-28T21:20:35+02:00

ok what commented

2023-06-28 21:20:35 +02:00

This is based on this patch, but includes additional changes.

Visual changes

All strip previews are now drawn under the title bar:
Before:

After:

All strip previews now disappear when there isn't enough space for them.
Like the sound strip, the color strip expands to fill the whole strip when there is little vertical space, "taking over" the strip title. The color itself is likely a more important visual indicator than the name of the color strip.

Bug fixes

Disabling the strip title no longer disables the strip handle frame previews.
All strip previews should now be affected by the "Show overlays" toggle.
Turning off strip text overlay no longer makes the color strip preview disappear.

Other

Variables were renamed and additional comments were added in the areas relevant to this change, to hopefully make the code easier to read. The transition drawing was split into its own function.

In the previous patch there was a discussion about the color of the transition strip. Using the saturation level of source strips was suggested. I kept the color used in the second version of the patch as it's the best I could find. If someone has a specific hex code in mind that would work better I'm open to other suggestions.

This is based on [this patch](https://archive.blender.org/developer/differential/0016/0016205/index.html), but includes additional changes. # Visual changes **All strip previews are now drawn under the title bar:** Before: ![image](/attachments/02bd3773-b4f9-4380-9c37-21f3eabe6416) After: ![image](/attachments/269bd015-3d95-45d7-9535-51f4188cc71d) - **All strip previews now disappear when there isn't enough space for them.** - **Like the sound strip, the color strip expands to fill the whole strip when there is little vertical space, "taking over" the strip title. The color itself is likely a more important visual indicator than the name of the color strip.** ![Before](/attachments/1183f338-6194-42bb-a2fa-fede7de3d6a8) ![After](/attachments/9784cc9f-930c-4450-91a6-dd9c3d451128) # Bug fixes - Disabling the strip title no longer disables the strip handle frame previews. - All strip previews should now be affected by the "Show overlays" toggle. - Turning off strip text overlay no longer makes the color strip preview disappear. # Other - Variables were renamed and additional comments were added in the areas relevant to this change, to hopefully make the code easier to read. The transition drawing was split into its own function. In the [previous patch](https://archive.blender.org/developer/differential/0016/0016205/index.html) there was a discussion about the color of the transition strip. Using the saturation level of source strips was suggested. I kept the color used in the second version of the patch as it's the best I could find. If someone has a specific hex code in mind that would work better I'm open to other suggestions.

after.webm

1.6 MiB

before.webm

2.3 MiB

image.png

6.0 KiB

image.png

5.4 KiB

ok what added 2 commits 2023-06-28 21:20:50 +02:00

637f33e93e VSE: Changes to strip title and preview drawing

35ed9d5d60 Merge branch 'main' into vse-strip-title-pr

ok what added 2 commits 2023-07-27 13:59:42 +02:00